[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #32 from Fedora Update System  ---
hgsubversion-1.8.3-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #31 from Fedora Update System  ---
hgsubversion-1.8.3-1.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #30 from Fedora Update System  ---
hgsubversion-1.8.3-1.fc22 has been pushed to the Fedora 22 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-12-22 02:24:30



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #27 from Fedora Update System  ---
hgsubversion-1.8.3-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update hgsubversion'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-1d7e91d6ea

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #25 from Fedora Update System  ---
hgsubversion-1.8.3-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-817fc7a829

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #25 from Fedora Update System  ---
hgsubversion-1.8.3-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-817fc7a829

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #29 from Fedora Update System  ---
hgsubversion-1.8.3-1.fc23 has been pushed to the Fedora 23 testing repository.
If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update hgsubversion'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-817fc7a829

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #28 from Fedora Update System  ---
hgsubversion-1.8.3-1.fc22 has been pushed to the Fedora 22 testing repository.
If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update hgsubversion'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-2d463375a9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459

Antonio Trande  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #23 from Antonio Trande  ---
Package approved.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 204 files have
 unknown license. Detailed output of licensecheck in
 /home/sagitter/1221459-hgsubversion/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Packager, Vendor, 

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #22 from Dave Johansen  ---
(In reply to Antonio Trande from comment #21)
> (In reply to Dave Johansen from comment #20)
> > (In reply to Antonio Trande from comment #19)
> > > - You can use 'nose' for an explicit output of tests.
> > I'm unfamiliar with 'nose'. Where would the change in the spec file be made
> > and what would it be?
> 
> hgsubversion's upstream maintainer uses python-nose for his tests:
> https://pypi.python.org/pypi/nose/1.3.7
> 
> - Edit:
> 
> %check
> nosetests -v
Fixed.

> - Please, define what this package provides with:
> 
> %{?python_provide:%python_provide python2-%{name}}

Since this is a mercurial extension, I'm not sure how useful it is as a
standalone Python package, but I guess it doesn't hurt to add this and so I
did.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #19 from Antonio Trande  ---
- Why not a package for Python3 ?

- You can use 'nose' for an explicit output of tests.

- %{python_sitelib}/* --> %{python2_sitelib}/*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #20 from Dave Johansen  ---
(In reply to Antonio Trande from comment #19)
> - Why not a package for Python3 ?
Mercurial is Python 2 with no plans to move to Python 3 (
https://www.mercurial-scm.org/wiki/SupportedPythonVersions#Python_3.x_support
).

> - You can use 'nose' for an explicit output of tests.
I'm unfamiliar with 'nose'. Where would the change in the spec file be made and
what would it be?

> - %{python_sitelib}/* --> %{python2_sitelib}/*
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459

Dave Johansen  changed:

   What|Removed |Added

 Whiteboard|NotReady|



--- Comment #18 from Dave Johansen  ---
The issue has been resolved and all tests now pass on F23 and rawhide. The
updated files can be found at:
Spec URL:
https://daveisfera.fedorapeople.org/hgsubversion_1.8/hgsubversion.spec
SRPM URL:
https://daveisfera.fedorapeople.org/hgsubversion_1.8/hgsubversion-1.8.3-1.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459

Antonio Trande  changed:

   What|Removed |Added

 Whiteboard||NotReady



--- Comment #17 from Antonio Trande  ---
It should work in rawhide to be approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #16 from Dave Johansen  ---
This appears to be an issue related to subversion 1.9 (
https://groups.google.com/d/msg/hgsubversion/q47xvqDDmS0/mDIgsT8gFQAJ ). You
can either wait until the issue is resolved or start the review with F22 since
it is still using subversion 1.8.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #15 from Antonio Trande  ---
Some tests fail.
Please, check them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #14 from Dave Johansen davejohan...@gmail.com ---
(In reply to Marcin Haba from comment #13)
 Hello,
 
 (In reply to Dave Johansen from comment #12)
  (In reply to Marcin Haba from comment #10)
   1) add to Spec Requires and BuildRequires tags appropriate subversion
   dependecies (= 1.8.13-7)
  
  I don't think that this is worth the trouble. Plus, it wouldn't be correct
  for all Fedora/EPEL releases.
 
 Yes, it is worth the trouble. If somebody will try to use your Spec and
 SRPM to build hgsubversion with subversion  1.8.13-7 then occur the same
 problem with swig - Traceback and segfaults. I think that it is obligatory
 to add dependecies that have chance to work with result RPM package.

This was technically an issue with subversion and not hgsubversion. It's been
fixed in the repos and the fix doesn't require any change or rebuild on the
part of hgsubversion. Basically, if hgsubversion had already been packaged,
then this issue would have been introduced and then resolved without anything
being required from hgsubversion, so having an explicit Requires or
BuildRequires isn't completely true. Yes, to be bug free the requires is
correct, but I don't believe that sort of information is intended to be
captured in the packaging/.spec file and that's what Bugzilla and other issue
trackers are for.

Plus, I'm planning on including hgsubversion in EPEL 7 which has subversion 1.7
and so putting a specific version on the Requires would be conditional, really
complicated and honestly just doesn't make a lot of sense to me.

   2) add a sample rc file /etc/mercurial/hgrc.d/ to enable hgsubversion
   extension
  
  I'll check with upstream on the recommended way to handle this. With most
  Mercurial extensions, they default to off and have to be enabled. I realize
  that this one is a bit different, so I just want to make sure that upstream
  is ok with the enabled by default approach.
 
 OK. Thanks. I will be waiting on response in this subject.

hggit has to be enabled by the user after install (like basically all Mercurial
extensions), and upstream agreed that this is the right model to continue using
( https://groups.google.com/forum/#!topic/hgsubversion/ek0rNLCPZ7E ).

   I a have question about tests cases from hgsubversion:
   
   1) Why all tests executed by run.py finished successfully with installed
   subversion(-libs|-python) 1.8.13-2 that version caused segfault on clone
   action call?
  
  I'm not sure. Is this reproducible with the current version? If not, it's
  probably not worth spending any time on.
 
 No. Current version is OK with subversion = 1.8.13-7. I double checked.

Ok, so I believe that there's nothing required of hgsubversion and the
packaging of it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #13 from Marcin Haba marcin.h...@bacula.pl ---
Hello,

(In reply to Dave Johansen from comment #12)
 (In reply to Marcin Haba from comment #10)
  1) add to Spec Requires and BuildRequires tags appropriate subversion
  dependecies (= 1.8.13-7)
 
 I don't think that this is worth the trouble. Plus, it wouldn't be correct
 for all Fedora/EPEL releases.

Yes, it is worth the trouble. If somebody will try to use your Spec and SRPM
to build hgsubversion with subversion  1.8.13-7 then occur the same problem
with swig - Traceback and segfaults. I think that it is obligatory to add
dependecies that have chance to work with result RPM package.

  2) add a sample rc file /etc/mercurial/hgrc.d/ to enable hgsubversion
  extension
 
 I'll check with upstream on the recommended way to handle this. With most
 Mercurial extensions, they default to off and have to be enabled. I realize
 that this one is a bit different, so I just want to make sure that upstream
 is ok with the enabled by default approach.

OK. Thanks. I will be waiting on response in this subject.

  I a have question about tests cases from hgsubversion:
  
  1) Why all tests executed by run.py finished successfully with installed
  subversion(-libs|-python) 1.8.13-2 that version caused segfault on clone
  action call?
 
 I'm not sure. Is this reproducible with the current version? If not, it's
 probably not worth spending any time on.

No. Current version is OK with subversion = 1.8.13-7. I double checked.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #12 from Dave Johansen davejohan...@gmail.com ---
(In reply to Marcin Haba from comment #10)
 1) add to Spec Requires and BuildRequires tags appropriate subversion
 dependecies (= 1.8.13-7)

I don't think that this is worth the trouble. Plus, it wouldn't be correct for
all Fedora/EPEL releases.

 2) add a sample rc file /etc/mercurial/hgrc.d/ to enable hgsubversion
 extension

I'll check with upstream on the recommended way to handle this. With most
Mercurial extensions, they default to off and have to be enabled. I realize
that this one is a bit different, so I just want to make sure that upstream is
ok with the enabled by default approach.

 I a have question about tests cases from hgsubversion:
 
 1) Why all tests executed by run.py finished successfully with installed
 subversion(-libs|-python) 1.8.13-2 that version caused segfault on clone
 action call?

I'm not sure. Is this reproducible with the current version? If not, it's
probably not worth spending any time on.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #11 from Marcin Haba marcin.h...@bacula.pl ---
Hello Dave,

Do you have any news or comments in this ticket?

I am ready to perform informal review if you are interested, of course.

Thanks in advance for reply.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #6 from Marcin Haba marcin.h...@bacula.pl ---
One more info.

On system where I built hgsubversion result RPM I have the subversion libs that
causes SWIG problem:

# dnf list installed subversion*
Last metadata expiration check performed 2:34:25 ago on Wed Jul 22 17:40:34
2015.
Zainstalowane pakiety
subversion.x86_64 1.8.13-2.fc22  @System
subversion-libs.x86_641.8.13-2.fc22  @System
subversion-python.x86_64  1.8.13-2.fc22  @System


On system where I installed the result RPM I have the same subversion libs that
causes SWIG problem:

# dnf list installed subversion*
Last metadata expiration check performed 1:06:36 ago on Wed Jul 22 19:02:04
2015.
Zainstalowane pakiety
subversion-libs.x86_64  1.8.13-2.fc22@System
subversion-python.x86_641.8.13-2.fc22@System

On system where I installed the result RPM also I experienced the same SWIG
traceback:

 import hgsubversion
Traceback (most recent call last):
  File stdin, line 1, in module
  File /usr/lib/python2.7/site-packages/hgsubversion/__init__.py, line 49, in
module
import svncommands
  File /usr/lib/python2.7/site-packages/hgsubversion/svncommands.py, line 16,
in module
import svnwrap
  File /usr/lib/python2.7/site-packages/hgsubversion/svnwrap/__init__.py,
line 28, in module
from svn_swig_wrapper import *
  File
/usr/lib/python2.7/site-packages/hgsubversion/svnwrap/svn_swig_wrapper.py,
line 20, in module
from svn import client
  File /usr/lib64/python2.7/site-packages/svn/client.py, line 26, in module
from libsvn.client import *
  File /usr/lib64/python2.7/site-packages/libsvn/client.py, line 105, in
module
import libsvn.core
  File /usr/lib64/python2.7/site-packages/libsvn/core.py, line 7285, in
module
svn_pool_create()
TypeError: svn_pool_create() takes exactly 2 arguments (0 given)

So, my question is - why previously during first test the same version Spec and
SRPM threw traceback during building, but now it does not throw this traceback
during build process ?

At the end, I would mention that the subversion 1.8.13-7 is not available yet
in repository:

# LANG=en dnf update subversion-libs subversion-python
Failed to set locale, defaulting to C
Last metadata expiration check performed 1:25:18 ago on Wed Jul 22 19:02:04
2015.
Dependencies resolved.
Nothing to do.
Complete!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #5 from Marcin Haba marcin.h...@bacula.pl ---
Hello,

@Dave:

I noticed that the SWIG bindings bug is already fixed, so I have started review
feature request hgsubversion package.

The result RPM package builds successfully without errors or tracebacks. That
is nice.

Also all unit tests cases finished well:

Ran 362 tests in 782.711s
OK

Installation went perfect either by:

dnf install ./hgsubversion-1.8.1-1.fc21.noarch.rpm

For know the hgsubversion usage I read begining of the documentation from here:

/home/gani/1221459-hgsubversion/rpms-unpacked/hgsubversion-1.8.1-1.fc21.noarch.rpm/usr/share/doc/hgsubversion/hgsubversion.html

that says:


 To create a new Mercurial clone, you can use a command such as the following:

 $ hg clone repository URI [destination]

   Or with a real example:

 $ hg clone http://python-nose.googlecode.com/svn nose-hg


For test I used a random selected SVN repository from fedorahosted:

$ hg clone http://svn.fedorahosted.org/svn/xmlto/ xmlto-hg
abort: 'http://svn.fedorahosted.org/svn/xmlto/' does not appear to be an hg
repository:
---%--- (text/html; charset=UTF-8)
htmlheadtitlexmlto - Revision 82: //title/head
body
 h2xmlto - Revision 82: //h2
 ul
  lia href=AUTHORSAUTHORS/a/li
  lia href=COPYINGCOPYING/a/li
  lia href=ChangeLogChangeLog/a/li
  lia href=FAQFAQ/a/li
  lia href=INSTALLINSTALL/a/li
  lia href=Makefile.amMakefile.am/a/li
  lia href=NEWSNEWS/a/li
  lia href=READMEREADME/a/li
  lia href=THANKSTHANKS/a/li
  lia href=config.h.inconfig.h.in/a/li
  lia href=configure.inconfigure.in/a/li
  lia href=doc/doc//a/li
  lia href=format/format//a/li
  lia href=xmlif/xmlif//a/li
  lia href=xmlto.inxmlto.in/a/li
  lia href=xmlto.makxmlto.mak/a/li
  lia href=xmlto.spec.inxmlto.spec.in/a/li
 /ul
 hr noshadeemPowered by a
href=http://subversion.tigris.org/;Subversion/a version 1.6.11
(r934486)./em
/body/html
---%---
!

I also tried to use --layout single switcher, but without success:

$ hg clone --layout single http://svn.fedorahosted.org/svn/xmlto/ xmlto-hg
hg clone: option --layout not recognized
hg clone [OPTION]... SOURCE [DEST]

make a copy of an existing repository

options ([+] can be repeated):

 -U --noupdate  the clone will include an empty working copy (only a
repository)
 -u --updaterev REV revision, tag or branch to check out
 -r --rev REV [+]   include the specified changeset
 -b --branch BRANCH [+] clone only the specified branch
--pull  use pull protocol to copy metadata
--uncompressed  use uncompressed transfer (fast over LAN)
 -e --ssh CMD   specify ssh command to use
--remotecmd CMD specify hg command to run on the remote side
--insecure  do not verify server certificate (ignoring web.cacerts
config)

(use hg clone -h to show more help)


At the end I tried to checkout the same repository by subversion:

$ svn checkout http://svn.fedorahosted.org/svn/xmlto/
Axmlto/xmlif
Axmlto/xmlif/test
Axmlto/xmlif/test/result-foo
Axmlto/xmlif/test/result-bar
Axmlto/xmlif/test/result-html
Axmlto/xmlif/test/run-test
Axmlto/xmlif/test/result-unrelated-condition
Axmlto/xmlif/test/result-pdf
Axmlto/xmlif/test/result-baz
Axmlto/xmlif/test/result-no-condition
Axmlto/xmlif/test/result-ps
Axmlto/xmlif/test/test.xml
Axmlto/xmlif/xmlif.c
Axmlto/xmlif/xmlif.l
Axmlto/AUTHORS
Axmlto/configure.in
Axmlto/ChangeLog
Axmlto/THANKS
Axmlto/format
Axmlto/format/docbook
Axmlto/format/docbook/txt
Axmlto/format/docbook/xhtml-nochunks
Axmlto/format/docbook/dvi
Axmlto/format/docbook/ps
Axmlto/format/docbook/html-nochunks
Axmlto/format/docbook/javahelp
Axmlto/format/docbook/awt
Axmlto/format/docbook/epub
Axmlto/format/docbook/xhtml
Axmlto/format/docbook/svg
Axmlto/format/docbook/fo
Axmlto/format/docbook/html
Axmlto/format/docbook/pdf
Axmlto/format/docbook/man
Axmlto/format/docbook/mif
Axmlto/format/docbook/htmlhelp
Axmlto/format/docbook/pcl
Axmlto/format/fo
Axmlto/format/fo/svg
Axmlto/format/fo/txt
Axmlto/format/fo/dvi
Axmlto/format/fo/ps
Axmlto/format/fo/pdf
Axmlto/format/fo/awt
Axmlto/format/fo/mif
Axmlto/format/fo/pcl
Axmlto/format/xhtml1
Axmlto/format/xhtml1/svg
Axmlto/format/xhtml1/txt
Axmlto/format/xhtml1/dvi
Axmlto/format/xhtml1/ps
Axmlto/format/xhtml1/fo
Axmlto/format/xhtml1/pdf
Axmlto/format/xhtml1/awt
Axmlto/format/xhtml1/mif
Axmlto/format/xhtml1/pcl
Axmlto/README
Axmlto/config.h.in
Axmlto/xmlto.spec.in
Axmlto/doc
Axmlto/doc/xmlto.xml
Axmlto/doc/xmlif.xml
Axmlto/INSTALL
Axmlto/FAQ
Axmlto/COPYING
Axmlto/xmlto.in
Axmlto/Makefile.am
Axmlto/xmlto.mak
Axmlto/NEWS

This test confirms that it is valid SVN repository.

THe hgsubversion is on 

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #7 from Dave Johansen davejohan...@gmail.com ---
(In reply to Marcin Haba from comment #5)
 For test I used a random selected SVN repository from fedorahosted:
 
 $ hg clone http://svn.fedorahosted.org/svn/xmlto/ xmlto-hg
 abort: 'http://svn.fedorahosted.org/svn/xmlto/' does not appear to be an hg
 repository:
 
 Could you tell me if documentation is wrong or I missed something.

Did you enable hgsubversion (
https://mercurial.selenic.com/wiki/HgSubversion#Installation_and_Configuration
)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #8 from Marcin Haba marcin.h...@bacula.pl ---
Hello,

Thanks for quick reply.

No, I did not enable hgsubversion. Thanks for the link. I have never used
Mercurial before ;-)

It might be good to mention about this step (adding rc file) in documentation,
or provide this rc file in hgsubversion RPM package. What do you think about
it?

So, I added rc file to /etc/mercurial/hgrc.d/ as below:

# cat /etc/mercurial/hgrc.d/hgsubversion.rc 
[extensions]
hgsubversion = /usr/lib/python2.7/site-packages/hgsubversion


And then I tried to use the same hg call as previously:
$ hg clone http://svn.fedorahosted.org/svn/xmlto/ xmlto-hg

As result I noticed segfault in dmesg:

[47575.983918] hg[25781]: segfault at 0 ip 7f5b12b58abd sp 7ffc310c4540
error 6 in libpython2.7.so.1.0[7f5b12ad8000+17c000]

I tried to use gdb as below:

gdb /usr/bin/python2.7
run /usr/bin/hg clone http://svn.fedorahosted.org/svn/xmlto/ xmlto-hg


Starting program: /usr/bin/python2.7 /usr/bin/hg clone
http://svn.fedorahosted.org/svn/xmlto/ xmlto-hg
[Thread debugging using libthread_db enabled]
Using host libthread_db library /lib64/libthread_db.so.1.

Program received signal SIGSEGV, Segmentation fault.
0x77a93abd in dict_set_item_by_hash_or_entry () from
/lib64/libpython2.7.so.1.0
...
...
(gdb) thread apply all bt
#0  0x77a93abd in dict_set_item_by_hash_or_entry () from
/lib64/libpython2.7.so.1.0
#1  0x77a95ef4 in PyDict_SetItemString () from
/lib64/libpython2.7.so.1.0
#2  0x7fffeb6c2219 in SWIG_Python_SetConstant () from
/usr/lib64/python2.7/site-packages/libsvn/_client.so
#3  0x7fffeb6c2415 in svn_swig_py_get_commit_log_func_swigconstant () from
/usr/lib64/python2.7/site-packages/libsvn/_client.so
#4  0x77af58be in PyEval_EvalFrameEx () from /lib64/libpython2.7.so.1.0
#5  0x77af66b4 in PyEval_EvalCodeEx () from /lib64/libpython2.7.so.1.0
#6  0x77af67d9 in PyEval_EvalCode () from /lib64/libpython2.7.so.1.0
#7  0x77b064dc in PyImport_ExecCodeModuleEx () from
/lib64/libpython2.7.so.1.0
#8  0x77b06762 in load_source_module () from /lib64/libpython2.7.so.1.0
#9  0x77b073f0 in import_submodule () from /lib64/libpython2.7.so.1.0
#10 0x77b0767f in load_next () from /lib64/libpython2.7.so.1.0
#11 0x77b08098 in PyImport_ImportModuleLevel () from
/lib64/libpython2.7.so.1.0
#12 0x77aede48 in builtin___import__ () from /lib64/libpython2.7.so.1.0
#13 0x77af4f43 in PyEval_EvalFrameEx () from /lib64/libpython2.7.so.1.0
#14 0x77af66b4 in PyEval_EvalCodeEx () from /lib64/libpython2.7.so.1.0
#15 0x77af55c6 in PyEval_EvalFrameEx () from /lib64/libpython2.7.so.1.0
#16 0x77af66b4 in PyEval_EvalCodeEx () from /lib64/libpython2.7.so.1.0
#17 0x77a825ac in function_call () from /lib64/libpython2.7.so.1.0
#18 0x77a5db03 in PyObject_Call () from /lib64/libpython2.7.so.1.0
#19 0x77aefac7 in PyEval_CallObjectWithKeywords () from
/lib64/libpython2.7.so.1.0
#20 0x77af261b in PyEval_EvalFrameEx () from /lib64/libpython2.7.so.1.0
#21 0x77af66b4 in PyEval_EvalCodeEx () from /lib64/libpython2.7.so.1.0
#22 0x77af67d9 in PyEval_EvalCode () from /lib64/libpython2.7.so.1.0
#23 0x77b064dc in PyImport_ExecCodeModuleEx () from
/lib64/libpython2.7.so.1.0
#24 0x77b06762 in load_source_module () from /lib64/libpython2.7.so.1.0
#25 0x77b073f0 in import_submodule () from /lib64/libpython2.7.so.1.0
#26 0x77b07918 in ensure_fromlist () from /lib64/libpython2.7.so.1.0
#27 0x77b0815a in PyImport_ImportModuleLevel () from
/lib64/libpython2.7.so.1.0
#28 0x77aede48 in builtin___import__ () from /lib64/libpython2.7.so.1.0
#29 0x77af4f43 in PyEval_EvalFrameEx () from /lib64/libpython2.7.so.1.0
#30 0x77af66b4 in PyEval_EvalCodeEx () from /lib64/libpython2.7.so.1.0
#31 0x77af55c6 in PyEval_EvalFrameEx () from /lib64/libpython2.7.so.1.0
#32 0x77af66b4 in PyEval_EvalCodeEx () from /lib64/libpython2.7.so.1.0
#33 0x77a825ac in function_call () from /lib64/libpython2.7.so.1.0
#34 0x77a5db03 in PyObject_Call () from /lib64/libpython2.7.so.1.0
#35 0x77aefac7 in PyEval_CallObjectWithKeywords () from
/lib64/libpython2.7.so.1.0
#36 0x77af261b in PyEval_EvalFrameEx () from /lib64/libpython2.7.so.1.0
#37 0x77af66b4 in PyEval_EvalCodeEx () from /lib64/libpython2.7.so.1.0
#38 0x77af67d9 in PyEval_EvalCode () from /lib64/libpython2.7.so.1.0
#39 0x77b064dc in PyImport_ExecCodeModuleEx () from
/lib64/libpython2.7.so.1.0
#40 0x77b06762 in load_source_module () from /lib64/libpython2.7.so.1.0
#41 0x77b073f0 in import_submodule () from /lib64/libpython2.7.so.1.0
#42 0x77b0767f in load_next () from /lib64/libpython2.7.so.1.0
#43 0x77b0805d in PyImport_ImportModuleLevel () from
/lib64/libpython2.7.so.1.0

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #9 from Marcin Haba marcin.h...@bacula.pl ---
Same plugin is loaded as shows below command:

# hg help hgsubversion
hgsubversion extension - integration with Subversion repositories

hgsubversion is an extension for Mercurial that allows it to act as a
Subversion client, offering fast, incremental and bidirectional
synchronisation.

At this point, hgsubversion is usable by users reasonably familiar with
Mercurial as a VCS. It's not recommended to dive into hgsubversion as an
introduction to Mercurial, since hgsubversion bends the rules a little and
violates some of the typical assumptions of early Mercurial users.

Before using hgsubversion, we *strongly* encourage running the automated
tests. See 'README' in the hgsubversion directory for details.

For more information and instructions, see hg help subversion.

list of commands:

 svn   subcommands for Subversion integration

(use hg help -v hgsubversion to show built-in aliases and global options)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #10 from Marcin Haba marcin.h...@bacula.pl ---
Hello,

After download latest subversion 1.8.13-7 packages from here:

http://koji.fedoraproject.org/koji/buildinfo?buildID=669141

and update:

# dnf update subversion-libs-1.8.13-7.fc22.x86_64.rpm
subversion-1.8.13-7.fc22.x86_64.rpm subversion-python-1.8.13-7.fc22.x86_64.rpm

the hgsubversion started working:

$ hg clone http://svn.fedorahosted.org/svn/xmlto/ xmlto-hg
[r1] ovasik: xmlto release 0.0.21
[r2] ovasik: Initial commit to Fedorahosted XMLTO svn (version 0.0.21)
[r3] ovasik: fix broken stringparam option
[r4] ovasik: add --nonet and --noent option to xmllint validation check(fixes
debian #516253)
...
...
...
[r81] ovasik: xmlif: fix segfault with malformed end attribute
[r82] ovasik: xmlif/xmlif.{c,l}: fix double free with invalid end attribute
pulled 82 revisions
updating to branch default
62 files updated, 0 files merged, 0 files removed, 0 files unresolved

It looks that the SWIG problem in subversion was the reason.

So, I have following suggestions:

1) add to Spec Requires and BuildRequires tags appropriate subversion
dependecies (= 1.8.13-7)
2) add a sample rc file /etc/mercurial/hgrc.d/ to enable hgsubversion extension

I a have question about tests cases from hgsubversion:

1) Why all tests executed by run.py finished successfully with installed
subversion(-libs|-python) 1.8.13-2 that version caused segfault on clone action
call?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459
Bug 1221459 depends on bug 1216264, which changed state.

Bug 1216264 Summary: subversion-python broken: causing ViewVC to fail
https://bugzilla.redhat.com/show_bug.cgi?id=1216264

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #3 from Dave Johansen davejohan...@gmail.com ---
(In reply to Marcin Haba from comment #1)
 During build process occurs following traceback:
This is a problem with the SWIG bindings in subversion-python. See blocker
bugzilla (#1216264).

(In reply to Marcin Haba from comment #2)
 Because your package requires mercurial module for work (from global
 namespace of setup.py):
 in Spec you probably need to add:
 Requires: mercurial
Good catch. Added along with a Requires for subversion-python.

 and define as Requires other Mercurial dependencies in Spec file if any.
Mercurial's only dependency is on python, but even if there were others I don't
believe it would be required to add them here because a dependence on Mercurial
implies a dependence on everything it depends on.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #4 from Marcin Haba marcin.h...@bacula.pl ---
Hello Dave,

About blocker #1216264, right. I missed this blocker in this ticket. Thanks for
point me this SWIG binding bug in subversion-python.

Also thanks for explain Mercurial me dependecies.

I will back here to review, when subversion-python blocker be fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459

Marcin Haba marcin.h...@bacula.pl changed:

   What|Removed |Added

 CC||marcin.h...@bacula.pl



--- Comment #1 from Marcin Haba marcin.h...@bacula.pl ---
Hello,

During build process occurs following traceback:

 /usr/bin/python2 setup.py build
Traceback (most recent call last):
  File setup.py, line 106, in module
from hgsubversion.svnwrap import svn_swig_wrapper
  File
/builddir/build/BUILD/durin42-hgsubversion-dde1ade36a49/hgsubversion/__init__.py,
line 49, in module
import svncommands
  File
/builddir/build/BUILD/durin42-hgsubversion-dde1ade36a49/hgsubversion/svncommands.py,
line 16, in module
import svnwrap
  File
/builddir/build/BUILD/durin42-hgsubversion-dde1ade36a49/hgsubversion/svnwrap/__init__.py,
line 28, in module
from svn_swig_wrapper import *
  File
/builddir/build/BUILD/durin42-hgsubversion-dde1ade36a49/hgsubversion/svnwrap/svn_swig_wrapper.py,
line 20, in module
from svn import client
  File /usr/lib64/python2.7/site-packages/svn/client.py, line 26, in module
from libsvn.client import *
  File /usr/lib64/python2.7/site-packages/libsvn/client.py, line 105, in
module
import libsvn.core
  File /usr/lib64/python2.7/site-packages/libsvn/core.py, line 7285, in
module
svn_pool_create()
TypeError: svn_pool_create() takes exactly 2 arguments (0 given)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #2 from Marcin Haba marcin.h...@bacula.pl ---
I am not Fedora packages maintainer and even not Python developer, from these
reasons my review notices are informal.

Because your package requires mercurial module for work (from global namespace
of setup.py):


try:
import mercurial
except ImportError:
requires.append('mercurial')


in Spec you probably need to add:


Requires: mercurial


and define as Requires other Mercurial dependencies in Spec file if any.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459

Dave Johansen davejohan...@gmail.com changed:

   What|Removed |Added

 Depends On||1216264




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1216264
[Bug 1216264] subversion-python broken: causing ViewVC to fail
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review