[Bug 1221469] Review Request: jruby-maven-plugins - JRuby Maven plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1221469 Michal Srb m...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||jruby-maven-plugins-1.0.10- ||2.fc23 Resolution|--- |RAWHIDE Last Closed||2015-05-18 03:18:10 --- Comment #9 from Michal Srb m...@redhat.com --- Thanks for the review and the repo. The package is now in Rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221469] Review Request: jruby-maven-plugins - JRuby Maven plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1221469 --- Comment #6 from Michal Srb m...@redhat.com --- Fixed spec+srpm: Spec URL: https://msrb.fedorapeople.org/review/2/jruby-maven-plugins.spec SRPM URL: https://msrb.fedorapeople.org/review/2/jruby-maven-plugins-1.0.10-2.fc23.src.rpm I removed bundled files and disabled rails3-maven-plugin. I don't expect it to be needed anytime soon in Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221469] Review Request: jruby-maven-plugins - JRuby Maven plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1221469 Michal Srb m...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Michal Srb m...@redhat.com --- Thanks for the review! New Package SCM Request === Package Name: jruby-maven-plugins Short Description: JRuby Maven plugins Upstream URL: https://github.com/torquebox/jruby-maven-plugins Owners: msrb mizdebsk msimacek Branches: f22 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221469] Review Request: jruby-maven-plugins - JRuby Maven plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1221469 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221469] Review Request: jruby-maven-plugins - JRuby Maven plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1221469 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221469] Review Request: jruby-maven-plugins - JRuby Maven plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1221469 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221469] Review Request: jruby-maven-plugins - JRuby Maven plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1221469 gil cattaneo punto...@libero.it changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221469] Review Request: jruby-maven-plugins - JRuby Maven plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1221469 Michal Srb m...@redhat.com changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221469] Review Request: jruby-maven-plugins - JRuby Maven plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1221469 gil cattaneo punto...@libero.it changed: What|Removed |Added CC||punto...@libero.it Assignee|nob...@fedoraproject.org|punto...@libero.it Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221469] Review Request: jruby-maven-plugins - JRuby Maven plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1221469 gil cattaneo punto...@libero.it changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from gil cattaneo punto...@libero.it --- NON blocking issues -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221469] Review Request: jruby-maven-plugins - JRuby Maven plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1221469
--- Comment #1 from gil cattaneo punto...@libero.it ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
Note: Cannot find license.txt in rpm(s)
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
IGNORE
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 284 files have unknown license. Detailed output
of licensecheck in /home/gil/1221469-jruby-maven-plugins/review-jruby-
maven-plugins/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/licenses, /usr/share/maven-metadata
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/licenses, /usr/share
/maven-metadata
[?]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
jruby-openssl:0.8.2 see
./ruby-tools/src/main/java/de/saumya/mojo/ruby/gems/GemsInstaller.java
https://github.com/jruby/jruby-openssl
[?]: Package contains no bundled libraries without FPC exception.
./ruby-tools/src/main/resources/rails-templates/datamapper/application.rb
./ruby-tools/src/main/resources/rails-templates/datamapper/config.rb
./ruby-tools/src/main/resources/rails-templates/datamapper/database.yml.rb
./ruby-tools/src/main/resources/rails-templates/datamapper/gemfile.rb
https://github.com/datamapper
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including metadata) even
when building with ant
[Bug 1221469] Review Request: jruby-maven-plugins - JRuby Maven plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1221469 --- Comment #3 from gil cattaneo punto...@libero.it --- forgotten: ./History.txt ./README.md .TODO can you manage the above txt file with %%doc macro? suppress this warning jruby-maven-plugins.noarch: W: no-documentation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221469] Review Request: jruby-maven-plugins - JRuby Maven plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1221469 --- Comment #4 from Michal Srb m...@redhat.com --- (In reply to gil cattaneo from comment #1) [?]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. jruby-openssl:0.8.2 see ./ruby-tools/src/main/java/de/saumya/mojo/ruby/gems/GemsInstaller.java https://github.com/jruby/jruby-openssl This fine should by fine IMO. [?]: Package contains no bundled libraries without FPC exception. ./ruby-tools/src/main/resources/rails-templates/datamapper/application.rb ./ruby-tools/src/main/resources/rails-templates/datamapper/config.rb ./ruby-tools/src/main/resources/rails-templates/datamapper/database.yml.rb ./ruby-tools/src/main/resources/rails-templates/datamapper/gemfile.rb https://github.com/datamapper Good catch. I missed those. I will check whether those are needed for now. If not, I will remove them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221469] Review Request: jruby-maven-plugins - JRuby Maven plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1221469 --- Comment #5 from Michal Srb m...@redhat.com --- (In reply to gil cattaneo from comment #3) forgotten: ./History.txt ./README.md .TODO can you manage the above txt file with %%doc macro? suppress this warning jruby-maven-plugins.noarch: W: no-documentation Will do, probably without TODO file - it shouldn't be needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
