[Bug 1221474] Review Request: rrd4j - A high performance data logging and graphing system for time series data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221474

Mikolaj Izdebski  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1221474
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

needinfo canceled: [Bug 1221474] Review Request: rrd4j - A high performance data logging and graphing system for time series data

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Package Review  has canceled Package
Review 's request for gil cattaneo
's needinfo:
Bug 1221474: Review Request: rrd4j - A high performance data logging and
graphing system for time series data
https://bugzilla.redhat.com/show_bug.cgi?id=1221474



--- Comment #7 from Package Review  ---
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1221474] Review Request: rrd4j - A high performance data logging and graphing system for time series data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221474



--- Comment #5 from Fabrice Bacchella  ---
I think that a 
+ex.printStackTrace();
+System.err.println("Font not loaded.");
 in a library is never a good idea.

I would rather wrap the Exception in a RuntimeException.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1221474] Review Request: rrd4j - A high performance data logging and graphing system for time series data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221474

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #4 from Robert-André Mauchin  ---
Hello,

If you're still willing to package this:

 - Update the SPEC to version 3.2

→ New BR for this:

BuildRequires: mvn(com.sleepycat:je)
BuildRequires: mvn(junit:junit)
BuildRequires: mvn(org.mongodb:mongo-java-driver)
BuildRequires: mvn(org.mongodb:mongodb-driver)
BuildRequires: mvn(org.sonatype.oss:oss-parent:pom:)
BuildRequires: mvn(org.easymock:easymock)
BuildRequires: mvn(org.jacoco:jacoco-maven-plugin)

→ Remove:

%pom_change_dep :mongo-java-driver ::2

→ Updated patch for the fonts:

diff -up
rrd4j-3.2/src/main/java/org/rrd4j/graph/RrdGraphConstants.java.use-system-fonts
rrd4j-3.2/src/main/java/org/rrd4j/graph/RrdGraphConstants.java
---
rrd4j-3.2/src/main/java/org/rrd4j/graph/RrdGraphConstants.java.use-system-fonts
   2017-11-11 13:33:45.0 +0100
+++ rrd4j-3.2/src/main/java/org/rrd4j/graph/RrdGraphConstants.java   
2017-11-29 00:02:05.325110896 +0100
@@ -1,6 +1,8 @@
 package org.rrd4j.graph;

 import java.awt.*;
+import java.io.BufferedInputStream;
+import java.io.FileInputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.util.Calendar;
@@ -272,13 +274,22 @@ public interface RrdGraphConstants {
  * @return a new {@link java.awt.Font} instance
  */
 public static Font getFont(int type, int size) {
+
+InputStream fontstream = null;
+
 String fontPath;
+
 if (type == Font.BOLD)
-fontPath = "/DejaVuSansMono-Bold.ttf";
+fontPath = "/usr/share/fonts/dejavu/DejaVuSansMono-Bold.ttf";
 else
-fontPath = "/DejaVuSansMono.ttf";
+fontPath = "/usr/share/fonts/dejavu/DejaVuSansMono.ttf";

-InputStream fontstream =
RrdGraphConstants.class.getResourceAsStream(fontPath);
+try {
+fontstream = new BufferedInputStream(new
FileInputStream(fontPath));
+} catch (Exception ex) {
+ex.printStackTrace();
+System.err.println("Font not loaded.");
+}
 try {
 return Font.createFont(Font.TRUETYPE_FONT,
fontstream).deriveFont(type == Font.BOLD ? Font.BOLD : Font.PLAIN, size);
 } catch (FontFormatException e) {


→ Changelog:

* Tue Nov 28 2017 Gil Cattaneo  3.2-1
- update to 3.2


 - Use a more meaningful name for your archive, with:

Source0:  
https://github.com/rrd4j/rrd4j/archive/%{version}/%{name}-%{version}.tar.gz

 - Not needed:

Requires(post): desktop-file-utils
Requires(postun): desktop-file-utils

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1221474] Review Request: rrd4j - A high performance data logging and graphing system for time series data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221474
Bug 1221474 depends on bug 1302003, which changed state.

Bug 1302003 Summary: Review Request: mongo-java-driver2 - MongoDB Java driver
https://bugzilla.redhat.com/show_bug.cgi?id=1302003

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221474] Review Request: rrd4j - A high performance data logging and graphing system for time series data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221474

gil cattaneo  changed:

   What|Removed |Added

 Depends On||1302003




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1302003
[Bug 1302003] Review Request: mongo-java-driver2 - The MongoDB Java driver
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221474] Review Request: rrd4j - A high performance data logging and graphing system for time series data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221474

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221474] Review Request: rrd4j - A high performance data logging and graphing system for time series data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221474



--- Comment #3 from Upstream Release Monitoring 
 ---
gil's scratch build of rrd4j-2.2.1-1.fc23.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12051015

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221474] Review Request: rrd4j - A high performance data logging and graphing system for time series data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221474



--- Comment #2 from gil cattaneo  ---
Spec URL: https://gil.fedorapeople.org/rrd4j.spec
SRPM URL: https://gil.fedorapeople.org/rrd4j-2.2.1-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221474] Review Request: rrd4j - A high performance data logging and graphing system for time series data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221474



--- Comment #1 from gil cattaneo punto...@libero.it ---
Spec URL: https://gil.fedorapeople.org/rrd4j.spec
SRPM URL: https://gil.fedorapeople.org/rrd4j-2.2.1-1.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review