[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Bug 1223455 depends on bug 1221559, which changed state. Bug 1221559 Summary: Mono 4 https://bugzilla.redhat.com/show_bug.cgi?id=1221559 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 --- Comment #18 from Fedora Update System --- mysql-connector-net-6.9.8-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2015-11-04 15:54:38 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System --- mysql-connector-net-6.9.8-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update mysql-connector-net' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-677d4e8167 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 --- Comment #16 from Fedora Update System --- mysql-connector-net-6.9.8-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-677d4e8167 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- mysql-connector-net-6.9.7-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update mysql-connector-net' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-0bc0cfc898 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 --- Comment #14 from Fedora Update System --- mysql-connector-net-6.9.7-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-0bc0cfc898 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 --- Comment #13 from Claudio Rodrigo Pereyra DIaz --- (In reply to Raphael Groner from comment #12) > Looks now good to me. APPROVED > > Why do you use GPLv2 only but not GPLv2+ (mind the plus) that would also > allow GPLv3 (and above)? See end of README file in the source mark use explicitly only GPLv2 GPLv2 Disclaimer For the avoidance of doubt, except that if any license choice other than GPL or LGPL is available it will apply instead, Oracle elects to use only the General Public License version 2 (GPLv2) at this time for any software where a choice of GPL license versions is made available with the language indicating that GPLv2 or any later version may be used, or where a choice of which version of the GPL is applied is otherwise unspecified. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Raphael Groner changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #12 from Raphael Groner --- Looks now good to me. APPROVED Why do you use GPLv2 only but not GPLv2+ (mind the plus) that would also allow GPLv3 (and above)? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 --- Comment #11 from Claudio Rodrigo Pereyra DIaz --- Spec URL: https://elsupergomez.fedorapeople.org/SPECS/mysql-connector-net.spec SRPM URL: https://elsupergomez.fedorapeople.org/SRPMS/mysql-connector-net-6.9.7-1.fc22.src.rpm Update to last version. Remove patch for build using framework 4.5, use xbuild parameter to set the target. Fix the license -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455
--- Comment #10 from Claudio Rodrigo Pereyra DIaz
---
(In reply to Raphael Groner from comment #7)
> There's already a package in PkgDB, 2 monthes old. Why a new review request?
> http://pkgs.fedoraproject.org/cgit/mysql-connector-net.git/commit/?h=f23
> https://admin.fedoraproject.org/pkgdb/package/mysql-connector-net/
>
> Package Review
> ==
>
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
>
>
> Issues:
> ===
> - Package does not use a name that already exists.
> Note: A package with this name already exists. Please check
> https://admin.fedoraproject.org/pkgdb/acls/name/mysql-connector-net
> See:
This is a Re-Review for unretired this package. That is way use the same name.
See https://fedorahosted.org/rel-eng/ticket/6222.
>
> https://fedoraproject.org/wiki/Packaging/
> NamingGuidelines#Conflicting_Package_Names
> - License is "GPLv2+ and BSD", not "GPLv2 or BSD". I fail to find any
> prevention of GPLv3+.
> - There's a new version 6.9.7 available at upstream, please update.
>
I will check this.
> = MUST items =
>
> Generic:
> [x]: Package is licensed with an open-source compatible license and meets
> other legal requirements as defined in the legal section of Packaging
> Guidelines.
> [!]: License field in the package spec file matches the actual license.
> Note: Checking patched sources after %prep for licenses. Licenses
> found: "BSD (3 clause)", "GPL (v2) (with incorrect FSF address)", "GPL
> (v2)", "Unknown or generated". 272 files have unknown license.
> Detailed output of licensecheck in /home/builder/fedora-review/1223455
> -mysql-connector-net/licensecheck.txt
> [x]: License file installed when any subpackage combination is installed.
> [!]: If the package is under multiple licenses, the licensing breakdown
> must be documented in the spec.
> [x]: %build honors applicable compiler flags or justifies otherwise.
> [x]: Package contains no bundled libraries without FPC exception.
> [x]: Changelog in prescribed format.
> [x]: Sources contain only permissible code or content.
> [-]: Package contains desktop file if it is a GUI application.
> [-]: Development files must be in a -devel package
> [x]: Package uses nothing in %doc for runtime.
> [x]: Package consistently uses macros (instead of hard-coded directory
> names).
> [x]: Package is named according to the Package Naming Guidelines.
> [x]: Package does not generate any conflict.
> [x]: Package obeys FHS, except libexecdir and /usr/target.
> [-]: If the package is a rename of another package, proper Obsoletes and
> Provides are present.
> [x]: Requires correct, justified where necessary.
> [x]: Spec file is legible and written in American English.
> [-]: Package contains systemd file(s) if in need.
> [-]: Useful -debuginfo package or justification otherwise.
> => Mono can not provide external debuginfo.
> [x]: Package is not known to require an ExcludeArch tag.
> [-]: Large documentation must go in a -doc subpackage. Large could be size
> (~1MB) or number of files.
> Note: Documentation size is 10240 bytes in 2 files.
> [!]: Package complies to the Packaging Guidelines
Why? Please help me to fix this point.
> [x]: Package successfully compiles and builds into binary rpms on at least
> one supported primary architecture.
> [x]: Package installs properly.
> [x]: Rpmlint is run on all rpms the build produces.
> Note: There are rpmlint messages (see attachment).
> [x]: If (and only if) the source package includes the text of the
> license(s) in its own file, then that file, containing the text of the
> license(s) for the package is included in %license.
> [x]: Package requires other packages for directories it uses.
> [x]: Package must own all directories that it creates.
> [x]: Package does not own files or directories owned by other packages.
> [x]: All build dependencies are listed in BuildRequires, except for any
> that are listed in the exceptions section of Packaging Guidelines.
> [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
> [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
> beginning of %install.
> [x]: Macros in Summary, %description expandable at SRPM build time.
> [x]: Dist tag is present.
> [x]: Package does not contain duplicates in %files.
> [x]: Permissions on files are set properly.
> [x]: Package use %makeinstall only when make install DESTDIR=... doesn't
> work.
> [x]: Package is named using only allowed ASCII characters.
> [x]: Package is not relocatable.
> [x]: Sources used to build the package match the upstream source, as
> provided in the spec URL.
> [x]: Spec file name must match the spec package %{name}, in the format
> %{name}.spec.
> [x]: File names are valid UTF-8.
> [x]: Packages must not store files under /srv, /opt or /
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 --- Comment #9 from Raphael Groner --- - Maybe consider to execute Tests/ files in %check. - Please put Documentation/* files into a -doc package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 --- Comment #8 from Raphael Groner --- Created attachment 1082104 --> https://bugzilla.redhat.com/attachment.cgi?id=1082104&action=edit licensecheck.txt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455
--- Comment #7 from Raphael Groner ---
There's already a package in PkgDB, 2 monthes old. Why a new review request?
http://pkgs.fedoraproject.org/cgit/mysql-connector-net.git/commit/?h=f23
https://admin.fedoraproject.org/pkgdb/package/mysql-connector-net/
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://admin.fedoraproject.org/pkgdb/acls/name/mysql-connector-net
See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
- License is "GPLv2+ and BSD", not "GPLv2 or BSD". I fail to find any
prevention of GPLv3+.
- There's a new version 6.9.7 available at upstream, please update.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "GPL (v2) (with incorrect FSF address)", "GPL
(v2)", "Unknown or generated". 272 files have unknown license.
Detailed output of licensecheck in /home/builder/fedora-review/1223455
-mysql-connector-net/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
=> Mono can not provide external debuginfo.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[?]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Raphael Groner changed: What|Removed |Added Assignee|timotheus.pokorra@solidchar |projects...@smart.ms |ity.com | Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Timotheus Pokorra changed: What|Removed |Added Flags|fedora-review? | --- Comment #6 from Timotheus Pokorra --- @Raphael: I would appreciate that! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Raphael Groner changed: What|Removed |Added CC||projects...@smart.ms --- Comment #5 from Raphael Groner --- I could take the reviewer job here, if you may like. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Timotheus Pokorra changed: What|Removed |Added Status|NEW |ASSIGNED CC||timotheus.pokorra@solidchar ||ity.com Assignee|nob...@fedoraproject.org|timotheus.pokorra@solidchar ||ity.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Eduardo Mayorga changed: What|Removed |Added CC||e...@mayorgalinux.com Flags|fedora-review+ | --- Comment #4 from Eduardo Mayorga --- You cannot approve your own packages. Please stick to the procedure described in https://fedoraproject.org/wiki/Package_Review_Process -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Claudio Rodrigo Pereyra DIaz changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455
Claudio Rodrigo Pereyra DIaz changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from Claudio Rodrigo Pereyra DIaz
---
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "GPL (v2)", "*No copyright* GPL (v2)",
"Unknown or generated". 35 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/licenses/mysql-
connector-net(languages, langpacks:, enabled, are, No), /usr/lib/mono
/mysql-connector-net(languages, langpacks:, enabled, are, No)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not pre
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 --- Comment #2 from Claudio Rodrigo Pereyra DIaz --- Spec URL: https://elsupergomez.fedorapeople.org/SPECS/mysql-connector-net.spec SRPM URL: https://elsupergomez.fedorapeople.org/SRPMS/mysql-connector-net-6.9.6-4.fc24.src.rpm Description: Mono ADO.NET driver for MySQL Fedora Account System Username: elsupergomez -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Claudio Rodrigo Pereyra DIaz changed: What|Removed |Added Blocks|1221559 | Depends On||1221559 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1221559 [Bug 1221559] Mono 4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Claudio Rodrigo Pereyra DIaz changed: What|Removed |Added Blocks||1244899 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1244899 [Bug 1244899] Review Request: monodevelop-database - Database Add-in for MonoDevelop -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Claudio Rodrigo Pereyra DIaz changed: What|Removed |Added Blocks||1221559 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1221559 [Bug 1221559] Mono 4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Claudio Rodrigo Pereyra DIaz changed: What|Removed |Added Blocks||163779 (FE-ACCEPT) CC||p...@all-the-johnsons.co.uk --- Comment #1 from Claudio Rodrigo Pereyra DIaz --- *** Bug 177512 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=163779 [Bug 163779] Tracker: Extras packages accepted -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
