[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|composer-1.0.0-0.5.20150620 |composer-1.0.0-0.5.20150620 |gitd0ff016.fc21 |gitd0ff016.el7 --- Comment #23 from Fedora Update System upda...@fedoraproject.org --- composer-1.0.0-0.5.20150620gitd0ff016.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||composer-1.0.0-0.5.20150620 ||gitd0ff016.fc22 Resolution|--- |ERRATA Last Closed||2015-07-03 14:33:36 --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- composer-1.0.0-0.5.20150620gitd0ff016.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|composer-1.0.0-0.5.20150620 |composer-1.0.0-0.5.20150620 |gitd0ff016.fc22 |gitd0ff016.fc21 --- Comment #22 from Fedora Update System upda...@fedoraproject.org --- composer-1.0.0-0.5.20150620gitd0ff016.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- composer-1.0.0-0.5.20150620gitd0ff016.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- composer-1.0.0-0.5.20150620gitd0ff016.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/composer-1.0.0-0.5.20150620gitd0ff016.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- composer-1.0.0-0.5.20150620gitd0ff016.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/composer-1.0.0-0.5.20150620gitd0ff016.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- composer-1.0.0-0.5.20150620gitd0ff016.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/composer-1.0.0-0.5.20150620gitd0ff016.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 --- Comment #19 from Shawn Iwinski shawn.iwin...@gmail.com --- @remi I forgot to mention, with Symfony 2.7 coming soon, you'll want to update your autoloader to use ClassLoader instead of UniversalClassLoader (deprecated since version 2.4, to be removed in 3.0. Use the ClassLoader class instead). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 --- Comment #15 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 --- Comment #10 from Shawn Iwinski shawn.iwin...@gmail.com --- Created attachment 1041463 -- https://bugzilla.redhat.com/attachment.cgi?id=1041463action=edit phpcompatinfo-all.log phpCompatInfo version 4.2.0 DB built May 22 2015 19:29:18 CEST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 --- Comment #11 from Shawn Iwinski shawn.iwin...@gmail.com --- Created attachment 1041464 -- https://bugzilla.redhat.com/attachment.cgi?id=1041464action=edit phpcompatinfo-src.log phpCompatInfo version 4.2.0 DB built May 22 2015 19:29:18 CEST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #14 from Remi Collet fed...@famillecollet.com --- Thanks for this review ! New Package SCM Request === Package Name: composer Short Description: Dependency Manager for PHP Upstream URL: https://getcomposer.org/ Owners: remi Branches: f21 f22 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134
Shawn Iwinski shawn.iwin...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #13 from Shawn Iwinski shawn.iwin...@gmail.com ---
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm 4.4
Note: %defattr present but not needed
[!]: Buildroot is not present
Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
As usual, remove EPEL5 bits after initial import.
The phpcompatinfo regular requires seem to be a mix of build requires and
regular requires while the build requires seem very sparse. Also, the regular
requires is missing php-dom. I'll let you choose the details there though.
No blockers.
= APPROVED =
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 --- Comment #12 from Shawn Iwinski shawn.iwin...@gmail.com --- Created attachment 1041490 -- https://bugzilla.redhat.com/attachment.cgi?id=1041490action=edit fedora-review.txt Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1225134 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|shawn.iwin...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 --- Comment #9 from Remi Collet fed...@famillecollet.com --- Update: https://github.com/remicollet/remirepo/commit/6af0c68c6b681acad788cec7f9d6753a4901aab2 Spec: https://raw.githubusercontent.com/remicollet/remirepo/ef5c018778b1c35d7e9d291665062fa98c35579c/composer/composer.spec Srpm: http://rpms.famillecollet.com/SRPMS/composer-1.0.0-0.5.20150620gitd0ff016.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 --- Comment #7 from Shawn Iwinski shawn.iwin...@gmail.com --- See attachment fedora-review-build-2015-06-20.log from comment #6 for fedora-review build failure. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 --- Comment #6 from Shawn Iwinski shawn.iwin...@gmail.com --- Created attachment 1041338 -- https://bugzilla.redhat.com/attachment.cgi?id=1041338action=edit fedora-review-build-2015-06-20.log -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 --- Comment #8 from Remi Collet fed...@famillecollet.com --- Damn test which need internet... I open https://github.com/composer/composer/pull/4169 And so: http://koji.fedoraproject.org/koji/taskinfo?taskID=10172691 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 --- Comment #5 from Remi Collet fed...@famillecollet.com --- Spec: https://raw.githubusercontent.com/remicollet/remirepo/06ff2084094794e8e88521ff3c5c5b0505e9b711/composer/composer.spec Srpm: http://rpms.famillecollet.com/SRPMS/composer-1.0.0-0.5.20150614git8e9659b.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 --- Comment #4 from Remi Collet fed...@famillecollet.com --- (In reply to Shawn Iwinski from comment #3) I thought at one point you mentioned it would be nice to have a location to put composer.json files other than /usr/share/doc/PKG/. This is what I was thinking with this comment. Yes, but such change will imply that all packages dropping a file in this directory will have to require composer for directory ownership, when it is really unneeded at runtime. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 --- Comment #3 from Shawn Iwinski shawn.iwin...@gmail.com --- (In reply to Remi Collet from comment #2) (In reply to Shawn Iwinski from comment #1) Perhaps /usr/share/composer/res could change to /usr/share/composer/COMPOSER_VENDOR/COMPOSER_PROJECT/res and then we could reuse /usr/share/composer for all packages to put their non-license, non-doc, and non-lib files in? Each package can own its /usr/share/package directory... I don't see the benefit of this proposal... (as explain in description, I don't plan to change packaging Guildelines, just want to offer the composer command) I thought at one point you mentioned it would be nice to have a location to put composer.json files other than /usr/share/doc/PKG/. This is what I was thinking with this comment. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 --- Comment #2 from Remi Collet fed...@famillecollet.com --- (In reply to Shawn Iwinski from comment #1) Perhaps /usr/share/composer/res could change to /usr/share/composer/COMPOSER_VENDOR/COMPOSER_PROJECT/res and then we could reuse /usr/share/composer for all packages to put their non-license, non-doc, and non-lib files in? Each package can own its /usr/share/package directory... I don't see the benefit of this proposal... (as explain in description, I don't plan to change packaging Guildelines, just want to offer the composer command) Since all files are RPM packaged and versioned, don't we (or shouldn't we) need to remove \Composer\Util\SpdxLicensesUpdater::update()? This is only dead code, as we don't provide the update-spdx-licenses command Nice... I didn't see the removal of the self update command in the spec but I notice upstream now only loads that command if using Composer as a PHAR :) ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225134] Review Request: composer - Dependency Manager for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1225134 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added CC||shawn.iwin...@gmail.com --- Comment #1 from Shawn Iwinski shawn.iwin...@gmail.com --- Perhaps /usr/share/composer/res could change to /usr/share/composer/COMPOSER_VENDOR/COMPOSER_PROJECT/res and then we could reuse /usr/share/composer for all packages to put their non-license, non-doc, and non-lib files in? Since all files are RPM packaged and versioned, don't we (or shouldn't we) need to remove \Composer\Util\SpdxLicensesUpdater::update()? Nice... I didn't see the removal of the self update command in the spec but I notice upstream now only loads that command if using Composer as a PHAR :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
