[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903



--- Comment #18 from Fedora Update System  ---
NetworkManager-sstp-1.2.0-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903



--- Comment #17 from Fedora Update System  ---
NetworkManager-sstp-1.2.0-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-09-08 17:15:06



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903



--- Comment #16 from Fedora Update System  ---
NetworkManager-sstp-1.2.0-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-dc25b53d8d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
NetworkManager-sstp-1.2.0-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9708701139

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903



--- Comment #13 from Fedora Update System  ---
NetworkManager-sstp-1.2.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-dc25b53d8d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903



--- Comment #14 from Fedora Update System  ---
NetworkManager-sstp-1.2.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9708701139

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903



--- Comment #12 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/NetworkManager-sstp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903

Lubomir Rintel  changed:

   What|Removed |Added

   Assignee|i...@cicku.me  |lkund...@v3.sk
  Flags|fedora-review?  |fedora-review+
   |needinfo?(i...@cicku.me)   |



--- Comment #11 from Lubomir Rintel  ---
*Sponsor hat on*
No response from the reviewer.

Thanks for packaging this. The package now addresses all points risen in review
and looks good.

APPROVED

Please note that there has been many updates for the plugin for NetworkManager
1.2 that's in Fedora 24. I asked the upstream to do a 1.2.0 release and they
will probably do that anytime soon

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903

Lubomir Rintel  changed:

   What|Removed |Added

  Flags||needinfo?(i...@cicku.me)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903

Lubomir Rintel  changed:

   What|Removed |Added

 CC||lkund...@v3.sk



--- Comment #10 from Lubomir Rintel  ---
This review seems stalled on Reviewer.

I'm now formally asking the reviewer to continue the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903



--- Comment #8 from Marcin Zajaczkowski  ---
IT took me a while, but I was able to manage it

> [!]: Buildroot is not present

Removed

> [!]: Package should not use obsolete m4 macros
> Note: Some obsoleted macros found, see the attachment.
> AC_PROG_LIBTOOL found in: NetworkManager-sstp-0.9.10/configure.ac:17

I can ask the project author to replace it with LT_INIT by the next version. Do
you see it as a blocker and I need to create a patch?

> 3. Drop changelog not from you. ALSO, leave a blank for each changelog entry.

I'm not convinced to drop the old changelog entries. There is a history how the
package evolved before it became a part of Fedora. In many packages available
in Fedora there is that history kept.

> 4. Epoch: 1
> This doesn't make sense at all.

The original specification author took it for unknown reasons. The benefit of
using it would be an ability to upgrade to the never version when available in
Fedora (in other case it would have to be done manually by removing old
package). Nevertheless you think it would be a good move I can remove it.

> 5. Drop all Group tags.

Done

> 6. RPM is not dumb like past, drop eplicit requires unless RPM can't detect 
> and pull in.

I was able to remove NetworkManager-devel from BuildRequires and gtk3 from
Requires. Looking at the generated requires maybe also dbus could be removed
from Requires as there is a reference to libdbus-1.so.3, but dbus-libs in
theory could be installed without a dbus package.

> 7. %if 0%{?fedora} > 17

Done

> 8. Requires: ppp
> Not enough, once ppp bumps the version, this plugin will be broken.

I changed the minimal ppp version to 2.4.6. In Fedora 23 there is 2.4.7 and it
seems to work fine. Do you suggest to set 2.4.7 as the highest allowed version?
I don't if changes in 2.4.8 will be compatible with sstp plugin or not, but
maybe it is too strict constraint?

> 9. %setup -q -n %{name}-%{version}
> 10. if [ ! -f configure ]; then

Done

> Would you stop copying the spec form others wholesale?

I could do it from scratch, but it seemed a better solution for me to reuse
existing spec file for a sibling project which is already in Fedora (which
should be quite ok as it passed the initial review - in hindsight I see that
the pptp package is quite old (2007) and could stand our from the current
standards).

>> This package contains software for integrating VPN capabilities with the 
>> SSTP server with NetworkManager (GNOME files).
> Please rework the description, `with...with...` sounds redundant and not 
> grammatical.

The description is exactly the same in all NetworkManager-*-gnome I've seen.
Nevertheless I changes it to:
> This package contains software for integrating VPN capabilities using the 
> SSTP server with NetworkManager (GNOME files).

English is not my mother tongue, so please propose something else if you don't
like it.

SPEC URL:
https://raw.githubusercontent.com/szpak/network-manager-sstp/c4d04a21428183a5d3f5ba2165666dc32851d998/NetworkManager-sstp.spec
SRPM URL:
http://timeoff.wsisiz.edu.pl/rpms/NetworkManager-sstp/NetworkManager-sstp-0.9.10-6.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903



--- Comment #9 from Marcin Zajaczkowski  ---
Regarding AC_PROG_LIBTOOL I disabled using autogen.sh, so the only thing I can
do is to report it upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903



--- Comment #6 from Göran Uddeborg  ---
This seems to have fallen asleep.  Do you still have the ambition to package
NetworkManager-sstp for Fedora?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903



--- Comment #7 from Marcin Zajaczkowski  ---
Thanks Goran for the reminder. And big thanks Christopher for the review! This
weekend I will be at DevConf.cz and (drawing from the vibe) will try to move it
forward.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903



--- Comment #4 from Christopher Meng  ---
(In reply to Marcin Zajaczkowski from comment #3)
> You can always become a co-maintainer of NetworkManager-sstp and have the
> another package to (co-)maintain :).

I will give up ;)

-

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)". Detailed output of licensecheck:

GPL (v2 or later)
-
NetworkManager-sstp-0.9.10/auth-dialog/main.c
NetworkManager-sstp-0.9.10/ltmain.sh
NetworkManager-sstp-0.9.10/properties/advanced-dialog.c
NetworkManager-sstp-0.9.10/properties/advanced-dialog.h
NetworkManager-sstp-0.9.10/properties/import-export.c
NetworkManager-sstp-0.9.10/properties/import-export.h
NetworkManager-sstp-0.9.10/properties/nm-sstp.c
NetworkManager-sstp-0.9.10/properties/nm-sstp.h
NetworkManager-sstp-0.9.10/src/nm-ppp-status.h
NetworkManager-sstp-0.9.10/src/nm-sstp-pppd-plugin.c
NetworkManager-sstp-0.9.10/src/nm-sstp-service-defines.h
NetworkManager-sstp-0.9.10/src/nm-sstp-service.c
NetworkManager-sstp-0.9.10/src/nm-sstp-service.h

[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /etc/dbus-1/system.d
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/dbus-1/system.d,
 /usr/lib/NetworkManager
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 8 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under 

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903



--- Comment #5 from Christopher Meng  ---
Not clear in the comment. Finished the review from phone, results generated
from remote server. ;)

> could you copy the spec form others wholesale?

Should be:

Would you stop copying the spec form others wholesale?

--
Nevermind, fix above issues, I will review again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903



--- Comment #3 from Marcin Zajaczkowski msz...@wp.pl ---
You can always become a co-maintainer of NetworkManager-sstp and have the
another package to (co-)maintain :).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

 CC||i...@cicku.me



--- Comment #2 from Christopher Meng i...@cicku.me ---
I intended to submit this by myself since I'm the maintainer of sstp-client in
Fedora.

I'm not sure what I will do now, because there are always some people trying to
submit packages after a dep of it is packaged by myself.  :(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|i...@cicku.me
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903

Marcin Zajaczkowski msz...@wp.pl changed:

   What|Removed |Added

 CC||jkli...@redhat.com



--- Comment #1 from Marcin Zajaczkowski msz...@wp.pl ---
I did a self-review with fedora-review and fixed one issue (not detected by
rpmlint) to use %license macro for license files instead of %doc.

As spotted by Jirka Klimes URL in a spec file pointed to NetworkManager itself
which makes it harder to find the plugin project itself. I changed URL
respectively.

Btw, trying to use fedora-review I discovered that for tools it could be better
to use raw version of the file instead of HTML page.

Spec URL:
https://raw.githubusercontent.com/szpak/network-manager-sstp/39e4923e3677822d29b9caf9281a74ca03466730/NetworkManager-sstp.spec
SRPM URL:
http://timeoff.wsisiz.edu.pl/rpms/NetworkManager-sstp/NetworkManager-sstp-0.9.10-5.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review