[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457

gil cattaneo  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2015-10-03 19:58:00



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #27 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457

Jonny Heggheim heg...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #26 from Jonny Heggheim heg...@gmail.com ---
New Package SCM Request
===
Package Name: rescu
Short Description: Lightweight Rest client utility for Java
Upstream URL: https://github.com/mmazi/rescu
Owners: jonny
Branches: f23

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #25 from Jonny Heggheim heg...@gmail.com ---
Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457

gil cattaneo punto...@libero.it changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #23 from gil cattaneo punto...@libero.it ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: MIT/X11 (BSD like), Unknown or generated. 2 files have
 unknown license. Detailed output of licensecheck in
 /home/gil/1231457-rescu/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: 

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457

gil cattaneo punto...@libero.it changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #24 from gil cattaneo punto...@libero.it ---
Seem all fine. Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457

gil cattaneo punto...@libero.it changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457

gil cattaneo punto...@libero.it changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457

Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

 CC||akurt...@redhat.com
 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #22 from Alexander Kurtakov akurt...@redhat.com ---
Removing FE-NEEDSPONSOR as I sponsored Jonny.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #21 from Jonny Heggheim heg...@gmail.com ---
Bumped to latest version and fixed issues that was found in #1230949

Spec URL: https://raw.githubusercontent.com/hegjon/rescu-rpm/master/rescu.spec
SRPM URL:
https://raw.githubusercontent.com/hegjon/rescu-rpm/master/rescu-1.8.2-0.1.gitbeb9897.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #20 from Jonny Heggheim heg...@gmail.com ---
Thanks for the pointers, I have updated the SPEC file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #15 from Jonny Heggheim heg...@gmail.com ---
Thanks a lot! :)

I will update the SPEC file to point to a non released version and bump it when
the next version have been released.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #16 from Jonny Heggheim heg...@gmail.com ---
I updated the SPEC file to the latest SNAPSHOT, I had to disable the unit test
because we do not have all the test dependencies yet.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10074380

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #18 from gil cattaneo punto...@libero.it ---
 (In reply to Jonny Heggheim from comment #16)
  I had to disable the unit test because we do not have all the test 
  dependencies yet.

than you should use: %mvn_build -f

see https://fedorahosted.org/released/javapackages/doc/
https://fedorahosted.org/released/javapackages/doc/#packaging_maven_project

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #19 from gil cattaneo punto...@libero.it ---
(In reply to Matija Mazi from comment #14)
 Hi, I'm the author of rescu and a contributing developer at XChange.
 
 I've fixed the following issues in rescu:

 - added a dependency on net.iharder:base64 and removed Base64.java from
 rescu.
 
other way is use jvm apis
http://pkgs.fedoraproject.org/cgit/py4j.git/tree/py4j-Base64-java7.patch
http://pkgs.fedoraproject.org/cgit/py4j.git/tree/py4j-Base64-java8.patch
 
 Thanks for the Fedora packaging effort!
glad to help

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #17 from gil cattaneo punto...@libero.it ---
(In reply to Jonny Heggheim from comment #16)
 I updated the SPEC file to the latest SNAPSHOT, I had to disable the unit
 test because we do not have all the test dependencies yet.
 
 Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10074380

Each step should be commented in the spec file.

Please, remove: Source1...

See
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages

Spec file change in:
...
Release: 0.1%{?dist}
...
%changelog
* Tue Jun 16 2015 Jonny Heggheim heg...@gmail.com - 1.8.2-0.1
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457

Matija Mazi matija.m...@gmail.com changed:

   What|Removed |Added

 CC||matija.m...@gmail.com



--- Comment #14 from Matija Mazi matija.m...@gmail.com ---
Hi, I'm the author of rescu and a contributing developer at XChange.

I've fixed the following issues in rescu:
- Added LINCESE.txt,
- removed AssertUtil.java,
- added a dependency on net.iharder:base64 and removed Base64.java from rescu.

I've created a pull request in XChange that removes the duplicated jackson
serializers:
https://github.com/timmolter/XChange/pull/994

I think this covers the above mentioned issues (when the Pull Request is
pulled). Please let me know if there is anything else that needs to be done.

Thanks for the Fedora packaging effort!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #13 from Jonny Heggheim heg...@gmail.com ---
Upstream have added a file containing the license

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #12 from Jonny Heggheim heg...@gmail.com ---
xchange is on my TODO list. Maybe I should try to communicate with upstream
with both projects and see if we are able to find a better solution.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #9 from gil cattaneo punto...@libero.it ---
(In reply to Jonny Heggheim from comment #8)
 Thanks for all your feedback and suggestions. I have pushed some updates.
 The only issue is AssertUtil.java

Seem a customization of
https://github.com/timmolter/XChange/blob/develop/xchange-core/src/main/java/com/xeiam/xchange/utils/Assert.java

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457

gil cattaneo punto...@libero.it changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #11 from gil cattaneo punto...@libero.it ---
Seem rescu and xchange have circular dependency cycle
https://github.com/timmolter/XChange/blob/xchange-3.0.0/xchange-core/pom.xml
maybe is possible requested a temporary FPC exception
see https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Exceptions
e.g. https://fedorahosted.org/fpc/ticket/510

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #10 from gil cattaneo punto...@libero.it ---
Bundle also other parts of the xchange code
src/main/java/si/mazi/rescu/serialization/jackson/serializers
xchange-core/src/main/java/com/xeiam/xchange/utils/jackson

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457

Jonny Heggheim heg...@gmail.com changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #2 from gil cattaneo punto...@libero.it ---
there is an issues related the missing license file.
see
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

i quote from the guide: If the source package does not include the text of the
license(s), the packager should contact upstream and encourage them to correct
this mistake. 

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457

gil cattaneo punto...@libero.it changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #1 from gil cattaneo punto...@libero.it ---
Spec file seem ok, with an exception:
Requires: java-headless = 1:1.6.0 should be removed, this is handled by Java
tools
Group: System Environment/Libraries should be removed, no more required

%dir %{_javadir}/%{name} should be removed, this is handled by Java tools

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #5 from gil cattaneo punto...@libero.it ---
(In reply to Jonny Heggheim from comment #4)
 I have contacted upstream and asked them to include a file containing the
 license
Great! add a comment in the spec file related this problem with the reference
of that bug.
should explain in the spec file why dont package tje latest release (1.8.1) as
comment

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #6 from gil cattaneo punto...@libero.it ---
build fine with:

BuildRequires: mvn(net.iharder:base64)

rm -rf src/main/java/si/mazi/rescu/utils/Base64.java
find ./ -name *.java -exec sed -i
s/si.mazi.rescu.utils.Base64/net.iharder.Base64/g {} +
%pom_add_dep net.iharder:base64:2.3.8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #4 from Jonny Heggheim heg...@gmail.com ---
I have contacted upstream and asked them to include a file containing the
license

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #8 from Jonny Heggheim heg...@gmail.com ---
Thanks for all your feedback and suggestions. I have pushed some updates. The
only issue is AssertUtil.java

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #7 from gil cattaneo punto...@libero.it ---
Created attachment 1038368
  -- https://bugzilla.redhat.com/attachment.cgi?id=1038368action=edit
MIT License

Until upstream don't include the license file should be used the attached file

e.g.
Source1: rescu-LICENSE
...
%setup -q -n rescu-rescu-%{version}
cp -p %{SOURCE1} LICENSE
...
%doc README.md
%license LICENSE

%files javadoc -f .mfiles-javadoc
%doc README.md
%license LICENSE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231457] Review Request: rescu - Lightweight Rest client utility for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231457



--- Comment #3 from gil cattaneo punto...@libero.it ---
Found a problem in the source: package bundle 
src/main/java/si/mazi/rescu/utils/Base64.java available as java-base64. Please
remove and use that library
rescu/src/main/java/si/mazi/rescu/utils/AssertUtil.java this, instead i don't
know where/what is the original package @ http://xeiam.com

see
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Why_no_Bundled_Libraries

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review