needinfo canceled: [Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
Product: Fedora Version: rawhide Component: Package Review Package Review has canceled Package Review 's request for Zuzana Svetlikova 's needinfo: Bug 1232816: Review Request: nodejs-spdx - SPDX License Expression Syntax parser https://bugzilla.redhat.com/show_bug.cgi?id=1232816 --- Comment #13 from Package Review --- This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
https://bugzilla.redhat.com/show_bug.cgi?id=1232816 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|NEW CC||ppi...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
https://bugzilla.redhat.com/show_bug.cgi?id=1232816 Piotr Popieluch changed: What|Removed |Added CC|piotr1...@gmail.com | Assignee|piotr1...@gmail.com |nob...@fedoraproject.org Flags|fedora-review- | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/KZTVGCEUYPLAYHOKUAFOCZYKBMKSKQU7/
[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
https://bugzilla.redhat.com/show_bug.cgi?id=1232816 --- Comment #11 from Piotr Popieluch --- The parser.generated.js file needs to be built this should be done in the %build section with: node generate-parser.js > parser.generated.js After it is built, it must be copied in the install section. It does not have to be built in the %check section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
https://bugzilla.redhat.com/show_bug.cgi?id=1232816 Zuzana Svetlikova changed: What|Removed |Added Flags|needinfo?(zsvetlik@redhat.c | |om) | --- Comment #10 from Zuzana Svetlikova --- Sources: Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx.spec SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx-0.5.1-1.f26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
https://bugzilla.redhat.com/show_bug.cgi?id=1232816 Piotr Popieluch changed: What|Removed |Added CC||zsvet...@redhat.com Flags||needinfo?(zsvetlik@redhat.c ||om) --- Comment #9 from Piotr Popieluch --- Are you still interested in packaging this module? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
https://bugzilla.redhat.com/show_bug.cgi?id=1232816 --- Comment #8 from Piotr Popieluch --- Any updates? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
https://bugzilla.redhat.com/show_bug.cgi?id=1232816 --- Comment #7 from Piotr Popieluch --- Some issues: There is a missing dependency: spdx-exceptions Version is missing in changelog Check section incorrect, should be: defence README.md | replace-require-self | node New versions license is MIT, not Apache You can leave out the "Requires: npm(spdx-license-ids)" this is handled automatically -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
https://bugzilla.redhat.com/show_bug.cgi?id=1232816 Piotr Popieluch changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #6 from Piotr Popieluch --- I think you will have to generate the code from source, which will involve packaging jison. https://lists.fedoraproject.org/archives/list/nodejs%40lists.fedoraproject.org/thread/YSBHPQXW2FTAVIEF4YUOY27HD5GEUIZB/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
https://bugzilla.redhat.com/show_bug.cgi?id=1232816 --- Comment #4 from Zuzana Svetlikova --- New sources: Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx.spec SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx-0.4.1-3.fc22.src.rpm Sources from npmjs don't contain build scripts, so it probably works without it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
https://bugzilla.redhat.com/show_bug.cgi?id=1232816 --- Comment #5 from Zuzana Svetlikova --- Sources: Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx.spec SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx-0.4.1-3.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
https://bugzilla.redhat.com/show_bug.cgi?id=1232816 --- Comment #3 from Piotr Popieluch --- Hi Zuzana, It seems that this module needs to be built, see package.json: "scripts": { "build": "node build/parser.js > source/parser.generated.js", The generated file is needed for proper functioning, see spdx.js: source/spdx.js:var parser = require('./parser.generated.js').parser; Building depends on npm(jison) which is not in Fedora yet. Small other comment: If you are targetting el6 than you have to change the ExclusiveArch: %if 0%{?fedora} >= 19 ExclusiveArch: %{nodejs_arches} noarch %else ExclusiveArch: %{ix86} x86_64 %{arm} noarch %endif If you are not buildinf for el6 then you can remove the %{?nodejs_find_provides_and_requires} macro. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
https://bugzilla.redhat.com/show_bug.cgi?id=1232816 Zuzana Svetlikova changed: What|Removed |Added Blocks||1248428 --- Comment #2 from Zuzana Svetlikova --- New sources: Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx.spec SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx-0.4.1-2.fc22.src.rpm Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1248428 [Bug 1248428] Rebase to npm 2.x -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
https://bugzilla.redhat.com/show_bug.cgi?id=1232816 Bug 1232816 depends on bug 1232777, which changed state. Bug 1232777 Summary: Review Request: nodejs-spdx-license-ids - A list of SPDX license identifiers https://bugzilla.redhat.com/show_bug.cgi?id=1232777 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
https://bugzilla.redhat.com/show_bug.cgi?id=1232816 Piotr Popieluch changed: What|Removed |Added CC||piotr1...@gmail.com Assignee|nob...@fedoraproject.org|piotr1...@gmail.com QA Contact|extras...@fedoraproject.org | Flags||fedora-review- --- Comment #1 from Piotr Popieluch --- License should be: "ASL 2.0" see https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Software_License_List for correct license Short Names Source0 incorrect https://github.com/kemitchell/%{github_name}/archive/%{github_name}-%{commit}.tar.gz should be https://github.com/kemitchell/%{github_name}/archive/%{commit}/%{github_name}-%{commit}.tar.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
https://bugzilla.redhat.com/show_bug.cgi?id=1232816 Zuzana Svetlikova changed: What|Removed |Added Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser
https://bugzilla.redhat.com/show_bug.cgi?id=1232816 Zuzana Svetlikova changed: What|Removed |Added Depends On||1232777 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1232777 [Bug 1232777] Review Request: nodejs-spdx-license-ids - A list of SPDX license identifiers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review