[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #30 from Fedora Update System --- jpype-0.6.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #29 from Fedora Update System --- jpype-0.6.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2015-08-14 14:12:26 |2015-10-04 15:16:28 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #28 from Fedora Update System --- jpype-0.6.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #27 from Fedora Update System --- jpype-0.6.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update jpype'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8052 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #26 from Fedora Update System --- jpype-0.6.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update jpype'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15701 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #25 from Fedora Update System --- jpype-0.6.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update jpype'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15702 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #24 from Fedora Update System --- jpype-0.6.1-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8052 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #23 from Fedora Update System --- jpype-0.6.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15702 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #22 from Fedora Update System --- jpype-0.6.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15701 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #21 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 Raphael Groner changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 Raphael Groner changed: What|Removed |Added Status|ASSIGNED|POST --- Comment #20 from Raphael Groner --- New Package SCM Request === Package Name: jpype Short Description: Full access for Python programs to Java class libraries Upstream URL: https://github.com/originell/jpype Owners: raphgro Branches: f23 f22 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 gil cattaneo changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #19 from gil cattaneo --- Seem all fine. Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905
--- Comment #18 from gil cattaneo ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Packages have proper BuildRequires/Requires on jpackage-utils
IGNORE
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Note: No javadoc subpackage present
See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
IGNORE
- Javadoc documentation files are generated and included in -javadoc
subpackage
Note: No javadoc subpackage present. Note: Javadocs are optional for
Fedora versions >= 21
See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
IGNORE
= MUST items =
C/C++:
[-]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "Unknown or generated". 40 files have unknown
license. Detailed output of licensecheck in
/home/gil/1234905-jpype/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[?]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/python3.4/site-
packages/jpype/awt/event/__pycache__(jpype-py3), /usr/lib/python3.4
/site-packages/jpypex/__pycache__(jpype-py3), /usr/lib/python3.4/site-
packages/jpypex/swing(jpype-py3), /usr/lib/python3.4/site-
packages/jpypex/swing/__pycache__(jpype-py3), /usr/lib/python3.4/site-
packages/jpype/awt(jpype-py3), /usr/lib/python3.4/site-
packages/jpype/awt/event(jpype-py3), /usr/lib/python3.4/site-
packages/jpypex(jpype-py3), /usr/lib/python3.4/site-
packages/jpype/__pycache__(jpype-py3), /usr/lib/python3.4/site-
packages/jpype(jpype-py3), /usr/lib/python3.4/site-
packages/jpype/awt/__pycache__(jpype-py3)
[x]: %build honors applicable compiler flags or justifies otherwise.
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[-]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #17 from Raphael Groner --- Fixed. Not worth to bump the Release number. Spec URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype.spec SRPM URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype-0.6.1-1.src.rpm Task info (rawhide): http://koji.fedoraproject.org/koji/taskinfo?taskID=11033944 Task info (epel7): http://koji.fedoraproject.org/koji/taskinfo?taskID=11033982 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #16 from gil cattaneo --- Build fails: BUILD SUCCESSFUL Total time: 1 second + popd + sphinx-build -d doctrees doc html ~/build/BUILD/jpype-0.6.1 Compilation errors RPM: /var/tmp/rpm-tmp.fuNA0A: line 42: sphinx-build: command not found -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #15 from gil cattaneo --- Start now the review... if have time (no problems if you cant) can review this for me https://bugzilla.redhat.com/show_bug.cgi?id=1260975 ? thanks in advance -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #14 from Raphael Groner --- Spec URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype.spec SRPM URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype-0.6.1-1.src.rpm Task info (rawhide): http://koji.fedoraproject.org/koji/taskinfo?taskID=11032558 Task info (epel7): http://koji.fedoraproject.org/koji/taskinfo?taskID=11032469 * Thu Sep 10 2015 Raphael Groner <> - 0.6.1-1 - new upstream release v0.6.1 - make tests work with python3 - deprecation of jpype-py3 - split subpackages for python2 and 3 - use python build and install macros - ease html generation - ship _static documentation files - unbundle jquery - ship tests folder as an import option w/o execution bits - restrict documentation to only some .rst files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 gil cattaneo changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 gil cattaneo changed: What|Removed |Added Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 Raphael Groner changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|DEFERRED|--- Keywords||Reopened --- Comment #13 from Raphael Groner --- I decided to relaunch this review request and think to (hopefully) understand now how to apply properly the new python guidelines. jpype.spec - subpackages python2-jpype and python3-jpype - individual %python_provides python-jpype - virtual Provides: jpype - Obsoletes: jpype-py3 - epel7 has only python2-jpype - python3 support for f22+ gil, it's a multi licensed project, some headers are taken from JDK and Python, it's already mentioned in a comment, we found that situation early in the review of jpype-py3. Test files could be removed from doc package when license and any other issue for those are still unclear. > Blocking issues: > jpype-debuginfo.i686: E: debuginfo-without-sources This is cause of wrong BuildArch, I'll change to noarch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 Raphael Groner changed: What|Removed |Added Resolution|NOTABUG |DEFERRED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #12 from Zbigniew Jędrzejewski-Szmek --- I don't have any particular interest in this package. Having python2 and python3 subpackages is not (one can at least assume that without further information) harder than in any other python package... If you have a reason to think that for this package it *is* so, for example because of the interaction between java and versions, than you can provide just the python3 version. I was pretty careful to use "should" everywhere. It's your choice, even if the project encourages support for both versions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 Raphael Groner changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG Last Closed||2015-08-14 14:12:26 --- Comment #11 from Raphael Groner --- Do you have the ability to maintain this package in the requested complexity? If yes, you can take this review request. Sorry but I do not have the time to handle this complexity. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #10 from Zbigniew Jędrzejewski-Szmek --- (In reply to Raphael Groner from comment #9) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #6) > > Support for both python versions *should* be provided if possible. Many > > people are still using py2... > > Support for python2 (cause of legacy and theoretical reasons) will > complicate things a lot and increases complexity in packaging. Please have a look at the new python guidelines [https://fedoraproject.org/wiki/Packaging:Python]. They have been recently updated to make parallel python2 and python3 packaging much easier. > There is > currently no package that requires a jpype with python2. Packaging both versions is encouraged, even if there are no immediate users, because it much easier to move dependent projects between both versions. Another reason is that people develop their own things on Fedora, so we provide things even if they are not used by the rest of distribution. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #9 from Raphael Groner --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #6) > Support for both python versions *should* be provided if possible. Many > people are still using py2... Support for python2 (cause of legacy and theoretical reasons) will complicate things a lot and increases complexity in packaging. There is currently no package that requires a jpype with python2. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #8 from gil cattaneo --- NON blocking issues: [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 15 files have unknown license. Detailed output of licensecheck in /home/gil/1234905-jpype/licensecheck.txt see above jpype-doc.noarch: W: doc-file-dependency /usr/share/doc/jpype-doc/test/test_jarray_fixes.py /usr/bin/env Please, fix this file Blocking issues: jpype-debuginfo.i686: E: debuginfo-without-sources -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905
--- Comment #7 from gil cattaneo ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "Unknown or generated". 15 files have unknown
license. Detailed output of licensecheck in
/home/gil/1234905-jpype/licensecheck.txt
Please, ask to upstream to add license header for these files
jpype-0.6.0/doc/conf.py
jpype-0.6.0/native/python/include/capsulethunk.h
jpype-0.6.0/native/python/include/jp_cocoatools.h
jpype-0.6.0/native/python/include/jp_runloopstopper.h
jpype-0.6.0/test/harness/jpype/array/Test2.java
jpype-0.6.0/test/harness/jpype/attr/ClassWithBuffer.java
jpype-0.6.0/test/harness/jpype/attr/TestOverloadA.java
jpype-0.6.0/test/harness/jpype/attr/TestOverloadB.java
jpype-0.6.0/test/harness/jpype/attr/TestOverloadC.java
jpype-0.6.0/test/harness/jpype/exc/ChildTestException.java
jpype-0.6.0/test/harness/jpype/exc/ParentTestException.java
jpype-0.6.0/test/harness/jpype/properties/TestBean.java
jpype-0.6.0/test/harness/jpype/proxy/TestInterface1.java
jpype-0.6.0/test/harness/jpype/proxy/TestThreadCallback.java
jpype-0.6.0/test/transform_xunit_to_appveyor.xsl
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/python3.4/site-
packages/jpype/awt/event/__pycache__(jpype-py3), /usr/lib/python3.4
/site-packages/jpypex/__pycache__(jpype-py3), /usr/lib/python3.4/site-
packages/jpypex/swing(jpype-py3), /usr/lib/python3.4/site-
packages/jpypex/swing/__pycache__(jpype-py3), /usr/lib/python3.4/site-
packages/jpype/awt(jpype-py3), /usr/lib/python3.4/site-
packages/jpype/awt/event(jpype-py3), /usr/lib/python3.4/site-
packages/jpypex(jpype-py3), /usr/lib/python3.4/site-
packages/jpype/__pycache__(jpype-py3), /usr/lib/python3.4/site-
packages/jpype(jpype-py3), /usr/lib/python3.4/site-
packages/jpype/awt/__pycache__(jpype-py3)
[?]: %build honors applicable compiler flags or justifies otherwise.
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[?]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #6 from Zbigniew Jędrzejewski-Szmek --- Support for both python versions *should* be provided if possible. Many people are still using py2... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 Raphael Groner changed: What|Removed |Added Flags|needinfo?(bjoern.esser@gmai | |l.com) | --- Comment #5 from Raphael Groner --- - I fully agree about _static inclusion and unbundling of jquery. - Maybe it's best to remove the python2 stack completely. Before latest release, upstream's support was python2 only, now they promise full python3 support without the former github fork named jpype-py3 that's packaged already and my intention is to get it obsoleted when this review is done. Probably, I forgot to remove the python2 lines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added CC||zbys...@in.waw.pl --- Comment #4 from Zbigniew Jędrzejewski-Szmek --- You cannot remove _static, it is necessary to display the html pages properly. You should unbundle jquery probably (by replacing jquery.js with a symlink to /usr/share/javascript/jquery/2.1.3/jquery.min.js). Why install the tests is doc... It would imho be much better to stick them in the python dir, so that they are importable as jpypy.tests or so. "sanify" Why put both python2 and python3 in the same package? This will (among other things) pull in the full python2 stack for python3 users of this package and vice-versa. Why are tests only run with python3? Missing python2-* provides. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 gil cattaneo changed: What|Removed |Added Assignee|bjoern.es...@gmail.com |punto...@libero.it --- Comment #3 from gil cattaneo --- Björn, i will take this review, if you no have time -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 Raphael Groner changed: What|Removed |Added CC||bjoern.es...@gmail.com Flags||needinfo?(bjoern.esser@gmai ||l.com) --- Comment #2 from Raphael Groner --- Björn, how far are you with the review? Is there anything I need to fix? Please let me know about your questions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 --- Comment #1 from Raphael Groner --- Spec URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype.spec SRPM URL: https://raphgro.fedorapeople.org/review/py/jpype/jpype-0.6.0-2.src.rpm Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10428806 * Tue Jul 21 2015 Raphael Groner <> - 0.6.0-2 - include patch of proxy argument issue Enabled python tests give me: ImportError: dynamic module does not define init function (PyInit__jpype) This error may be related to https://bugs.python.org/issue19615 > python3 --version Python 3.4.2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 Björn "besser82" Esser changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 Raphael Groner changed: What|Removed |Added Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234905] Review Request: jpype - Full access for Python programs to Java class libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1234905 Raphael Groner changed: What|Removed |Added CC||punto...@libero.it See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=1208701 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
