[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #29 from Fedora Update System  ---
python-music21-2.2.1-1.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-09 16:58:05



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #28 from Fedora Update System  ---
python-music21-2.2.1-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-music21'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-249b77dcae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #26 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-music21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #27 from Fedora Update System  ---
python-music21-2.2.1-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-249b77dcae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116

William Moreno  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #24 from William Moreno  ---
Package Aproved
===

Just note than there are some missing BR in f22 but the package build fine in
f23 and rawhide

http://copr.fedoraproject.org/coprs/williamjmorenor/fedora-review-test/build/146453/

Also note than the cvs request have been deprecated and you must request the
new package from the pkgdb:

https://admin.fedoraproject.org/pkgdb/request/package/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #25 from Zbigniew Jędrzejewski-Szmek  ---
Thank you for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #23 from Zbigniew Jędrzejewski-Szmek  ---
Spec URL: http://in.waw.pl/~zbyszek/fedora/python-music21.spec
SRPM URL: http://in.waw.pl/~zbyszek/fedora/python-music21-2.2.1-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #22 from Upstream Release Monitoring 
 ---
zbyszek's scratch build of python-music21-2.1.2-2.fc24.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12064308

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #21 from Zbigniew Jędrzejewski-Szmek  ---
Thanks for taking on the review!

(In reply to William Moreno from comment #20)
> Package Review
> ==
> 
> 1. The doc and common subpackage both ship the license text, I will recomend
> to include the license text in the common packages and include a weak
> dependencie in doc:
> 
> Suggest: python-music21-common
I don't think this is allowed. The license file MUST be installed with any
subcombination of packages.

> Also use weak dependencies in python2 and 3 subpackage to suggest the doc
> subpackage.
Good idea, done.

> 2. The common subpackage include the python2.7 files than are linked to the
> python3 subpackage. As part of the move of Fedora to python3 by default I
> will recomend to split the common subpackage to ship the python3.5 files.
> Currently the common subpackage will requires python2 as the owner of the
> /usr/lib/python2.7/site-packages/ directory so python3-music21 will require
> python2 to install python-music21-common.
I moved them.

> There are many warning about symlinks in both packages, also please check
> this issue. 
I think that the symlinks are fine. rpmlint does not understand symlinks.

> The best aproach to this common content is to place it in /usr/share but
> this will require some mayor patching to the code and this will require to
> work with upstream.
I could move the files in common to /usr/share and provide symlinks from
both subpackages. I don't know if this would be better.

> 3. Include in python2 and 3 %files
> 
> %exclude %{python2_sitelib}/music21/LICENSE
> The license file is in the common subpackage.

Done.

> 3. Consider to include the test directory in both packages into a devel
> subpackage (python2-name-devel and python3-name-devel), most user will not
> run the test locally and this will let then get a smaller package to
> download.
>
> 4. Also both packages have a demos directory than do not look to be necesary
> in run time and can be packaged as subpackages, you can use weak depencies
> to suggest the user to install the demos subpackages.
I don't think splitting it up like this makes sense. It is essentially
a user program (using python as its interface), not a library that is
installed as a dependency for other things. Demos can be used as documentation
and are useful when using the package. They are not too big too.

> 5. Package is not known to require an ExcludeArch tag. Builds fails in
> secondary arches, but looks like there is a issue with the packaging root.
Hm, I'll try to rebuild.

> RPMLint:
> 1: python2-music21.noarch: E: explicit-lib-dependency python-matplotlib Not
> need work, it is a rpmlint issue
I actually submitted a PR for that, but it doesn't seem like it will  be
merged:
https://github.com/rpm-software-management/rpmlint/pull/58

> 2: python3-music21.noarch: W: dangling-symlink
> /usr/lib/python3.4/site-packages/music21/corpus/cpebach
> /usr/lib/python2.7/site-packages/music21/corpus/cpebach If you change the
> common to python3 files this warning will be fixed but you will need to
> check if the link in python2 works fine.

> 3: python3-music21.noarch: E: non-executable-script
> /usr/lib/python3.4/site-packages/music21/alpha/trecento/exceldiff.py 644
> Sedout the shebang of this files 
Done.

> 4: python-music21-common.noarch: E: incorrect-fsf-address
> /usr/lib/python2.7/site-packages/music21/corpus/josquin/laPlusDesPlus.abc
> Request upstream to fix it or propose a patch to update it.
https://github.com/cuthbertLab/music21/pull/122

> 5: python-music21-doc.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/python-music21/html/_sources/tutorials/advancedGraphing.txt
> See: https://fedoraproject.org/wiki/Packaging_tricks#Remove_DOS_line_endings
Done.

I need to update to 2.2.1.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #20 from William Moreno  ---
Package Review
==

1. The doc and common subpackage both ship the license text, I will recomend to
include the license text in the common packages and include a weak dependencie
in doc:

Suggest: python-music21-common

Also use weak dependencies in python2 and 3 subpackage to suggest the doc
subpackage.

2. The common subpackage include the python2.7 files than are linked to the
python3 subpackage. As part of the move of Fedora to python3 by default I will
recomend to split the common subpackage to ship the python3.5 files. Currently
the common subpackage will requires python2 as the owner of the
/usr/lib/python2.7/site-packages/ directory so python3-music21 will require
python2 to install python-music21-common.

There are many warning about symlinks in both packages, also please check this
issue. 

The best aproach to this common content is to place it in /usr/share but this
will require some mayor patching to the code and this will require to work with
upstream.

3. Include in python2 and 3 %files

%exclude %{python2_sitelib}/music21/LICENSE

The license file is in the common subpackage.

3. Consider to include the test directory in both packages into a devel
subpackage (python2-name-devel and python3-name-devel), most user will not run
the test locally and this will let then get a smaller package to download.

4. Also both packages have a demos directory than do not look to be necesary in
run time and can be packaged as subpackages, you can use weak depencies to
suggest the user to install the demos subpackages.

5. Package is not known to require an ExcludeArch tag. Builds fails in
secondary arches, but looks like there is a issue with the packaging root.

RPMLint:
1: python2-music21.noarch: E: explicit-lib-dependency python-matplotlib Not
need work, it is a rpmlint issue
2: python3-music21.noarch: W: dangling-symlink
/usr/lib/python3.4/site-packages/music21/corpus/cpebach
/usr/lib/python2.7/site-packages/music21/corpus/cpebach If you change the
common to python3 files this warning will be fixed but you will need to check
if the link in python2 works fine.
3: python3-music21.noarch: E: non-executable-script
/usr/lib/python3.4/site-packages/music21/alpha/trecento/exceldiff.py 644 Sedout
the shebang of this files 
4: python-music21-common.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/music21/corpus/josquin/laPlusDesPlus.abc
Request upstream to fix it or propose a patch to update it.
5: python-music21-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/python-music21/html/_sources/tutorials/advancedGraphing.txt See:
https://fedoraproject.org/wiki/Packaging_tricks#Remove_DOS_line_endings

= MUST items =
Generic:
Pass: Package is licensed with an open-source compatible license and meets
  other legal requirements as defined in the legal section of Packaging
  Guidelines.
Pass: License field in the package spec file matches the actual license.
Pass: License file installed when any subpackage combination is installed.
Pass: If the package is under multiple licenses, the licensing breakdown
  must be documented in the spec.
Pass: Package contains no bundled libraries without FPC exception.
Pass: Changelog in prescribed format.
Pass: Sources contain only permissible code or content.
NA:   Package contains desktop file if it is a GUI application.
NA:   Development files must be in a -devel package
Pass: Package uses nothing in %doc for runtime.
Pass: Package consistently uses macros (instead of hard-coded directory
  names).
Pass: Package is named according to the Package Naming Guidelines.
Pass: Package does not generate any conflict.
Pass: Package obeys FHS, except libexecdir and /usr/target.
Pass: If the package is a rename of another package, proper Obsoletes and
  Provides are present.
Paas: Requires correct, justified where necessary.
Paas: Spec file is legible and written in American English.
Paas: Package contains systemd file(s) if in need.
Paas: Large documentation must go in a -doc subpackage. Large could be size
Paas: Package successfully compiles and builds into binary rpms on at least
  one supported primary architecture.
Paas: Package installs properly.
Pass: Rpmlint is run on all rpms the build produces.
  Note: There are rpmlint messages (see attachment).
Paas: Package requires other packages for directories it uses.
Paas: Package must own all directories that it creates.
Paas: Package does not own files or directories owned by other packages.
Paas: All build dependencies are listed in BuildRequires, except for any
  that are listed in the exceptions section of Packaging Guidelines.
Paas: Package uses either %{buildroot} or $RPM_BUILD_ROOT
Paas: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
  beginning of %install.
Paas: Macros in Summary, %description expandable at 

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #18 from William Moreno  ---
Looks like builds fails due to packages dependencies issues with the change to
python3.4 to python3.5

ppc:
Error: nothing provides libpython3.4m.so.1.0()(64bit) needed by
python3-matplotlib-1.4.3-6.fc23.ppc64le.

s390:
Error: Package: python3-mock-1.0.1-8.fc24.noarch (build)
   Requires: python(abi) = 3.5
   Installed: python3-3.4.3-5.fc24.s390x (@build/$releasever)
   python(abi) = 3.4
   python(abi) = 3.4

The completed rawhide build was in a x86_64 host. Mi locall mock build is
failing in a x86_64 f23 up to date.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #19 from Zbigniew Jędrzejewski-Szmek  ---
Sure, we are in the middle of python3.5 mass rebuild, and some secondary
architectures seem behind. But I don't think that this matters, the chances of
anyone using this package on s390 or ppc are rather slim.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #17 from William Moreno  ---
s390: http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1993942
ppc:  http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=2935801
arm:  http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=3298023
copr:
https://copr.fedoraproject.org/coprs/williamjmorenor/fedora-review-test/build/142816/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #12 from William Moreno  ---
I can not build this app in rawhide, I did not cath the error, maybe it is a
missing build requires, please check the build requieres and try a scrath build
in koji for rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #13 from Upstream Release Monitoring 
 ---
zbyszek's scratch build of python-music21-2.1.2-1.fc24.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11526058

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #14 from Zbigniew Jędrzejewski-Szmek  ---
> http://koji.fedoraproject.org/koji/taskinfo?taskID=11353240

DEBUG util.py:377:  error: unpacking of archive failed on file
/builddir/build/SOURCES/music21-2.1.2.tar.gz;56143b90: cpio: read
DEBUG util.py:377:  error:
/builddir/build/originals/python-music21-2.1.2-1.fc24.src.rpm cannot be
installed

Looks like a problem with the build root or something.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116

William Moreno  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #11 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of python-music21-2.1.2-1.fc24.src.rpm for
rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11353240

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #10 from Zbigniew Jędrzejewski-Szmek  ---
Pff, a lot of time passed.

Latest upstream version, with new style python2- and python3- subpackages:

Spec URL: http://in.waw.pl/~zbyszek/fedora/python-music21.spec
SRPM URL: http://in.waw.pl/~zbyszek/fedora/python-music21-2.1.2-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116

William Moreno williamjmore...@gmail.com changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com



--- Comment #9 from William Moreno williamjmore...@gmail.com ---
Please update the spec to last Python Packaging Guidelines:
https://fedoraproject.org/wiki/Packaging:Python

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #8 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
There's nothing usual about that practice. It was introduced only because
2to3 was used to modify sources during build, so the same directory could not
be used for both 2.x and 3.x. But this package uses the same code for both
versions, so there's no need to do that. Actually, almost no packages use 2to3
anymore and imho the part of the Packaging Guidelines that seems to encourage
separate dirs should be mostly removed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116

Javier Peña jp...@redhat.com changed:

   What|Removed |Added

 CC||jp...@redhat.com



--- Comment #4 from Javier Peña jp...@redhat.com ---
Please be aware that this is an informal review.

I have some comments about the spec file:

- I think it might be better to fetch the source code directly from GitHub or
PyPi. I have been doing some tests using
https://pypi.python.org/packages/source/m/%{pypi_name}/%{pypi_name}-%{version}.tar.gz
and it works fine for me (with some details, see below).

- At least on the PyPi source, license is included in a license.txt file
together with the sources, so you can use %license
%{python2_sitelib}/music21/license.txt with it.

- I see the sources include some external libraries in music.ext, and your spec
file patches them manually using sed to avoid library bundling. Is there any
open request upstream to avoid this?

- rpmlint complains twice about macro-in-comment, and mixed spaces and tabs in
line 29.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #5 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
(In reply to Javier Peña from comment #4)
 - I think it might be better to fetch the source code directly from GitHub
 or PyPi. I have been doing some tests using
 https://pypi.python.org/packages/source/m/%{pypi_name}/%{pypi_name}-
 %{version}.tar.gz and it works fine for me (with some details, see below).
Pff, the situation is more complicated than that.
I forgot to update the comment to describe how the tarball was generated.
I made a pull request (https://github.com/cuthbertLab/music21/pull/100) and
update the comments in the spec file.

 - At least on the PyPi source, license is included in a license.txt file
 together with the sources, so you can use %license
 %{python2_sitelib}/music21/license.txt with it.

 - I see the sources include some external libraries in music.ext, and your
 spec file patches them manually using sed to avoid library bundling. Is
 there any open request upstream to avoid this?
I haven't submitted my patches upstream yet. It would be nice if upstream
refactored the code to try to import external modules first, before falling
back to the bundled ones, so that unbundling could be done transparently...
I wanted to wait until the review before I submit stuff upstream, in case
other issues are found.

 - rpmlint complains twice about macro-in-comment, and mixed spaces and tabs
 in line 29.
Fixed!

 Please be aware that this is an informal review.
Thanks for the comments.

Spec URL: http://in.waw.pl/~zbyszek/fedora/python-music21.spec
SRPM URL: http://in.waw.pl/~zbyszek/fedora/python-music21-2.0.5-2.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #7 from Jonathan Underwood jonathan.underw...@gmail.com ---
(In reply to Jonathan Underwood from comment #6)
 I notice this package isn't following the usual python packaging practice of
 building the py2 and py2 packages in separate directories (by duplicating

   
   py2 and py3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116

Jonathan Underwood jonathan.underw...@gmail.com changed:

   What|Removed |Added

 CC||jonathan.underw...@gmail.co
   ||m



--- Comment #6 from Jonathan Underwood jonathan.underw...@gmail.com ---
I notice this package isn't following the usual python packaging practice of
building the py2 and py2 packages in separate directories (by duplicating the
unpacked tarball directory in %prep) - is there a reason for this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116

Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:

   What|Removed |Added

 Whiteboard|NotReady|



--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
OK, tests now pass. Ready for review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=10310837

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116

Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:

   What|Removed |Added

 Whiteboard||NotReady



--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Tests are currently failing and I'm ironing out various wrinkles.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review