[Bug 1241614] Review Request: perl-Text-Reflow - Perl module for reflowing text files using Knuth's paragraphing algorithm

2015-08-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241614

Petr Šabata psab...@redhat.com changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
   Fixed In Version||perl-Text-Reflow-1.10-1.fc2
   ||1
 Resolution|--- |CURRENTRELEASE
Last Closed||2015-08-11 13:04:08



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241614] Review Request: perl-Text-Reflow - Perl module for reflowing text files using Knuth's paragraphing algorithm

2015-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241614



--- Comment #11 from Fedora Update System upda...@fedoraproject.org ---
perl-Text-Reflow-1.10-1.fc21 has been pushed to the Fedora 21 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241614] Review Request: perl-Text-Reflow - Perl module for reflowing text files using Knuth's paragraphing algorithm

2015-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241614



--- Comment #10 from Fedora Update System upda...@fedoraproject.org ---
perl-Text-Reflow-1.10-1.fc22 has been pushed to the Fedora 22 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241614] Review Request: perl-Text-Reflow - Perl module for reflowing text files using Knuth's paragraphing algorithm

2015-07-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241614

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241614] Review Request: perl-Text-Reflow - Perl module for reflowing text files using Knuth's paragraphing algorithm

2015-07-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241614



--- Comment #9 from Fedora Update System upda...@fedoraproject.org ---
perl-Text-Reflow-1.10-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Text-Reflow-1.10-1.fc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241614] Review Request: perl-Text-Reflow - Perl module for reflowing text files using Knuth's paragraphing algorithm

2015-07-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241614



--- Comment #8 from Fedora Update System upda...@fedoraproject.org ---
perl-Text-Reflow-1.10-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/perl-Text-Reflow-1.10-1.fc22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241614] Review Request: perl-Text-Reflow - Perl module for reflowing text files using Knuth's paragraphing algorithm

2015-07-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241614

Kevin Fenzi ke...@scrye.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241614] Review Request: perl-Text-Reflow - Perl module for reflowing text files using Knuth's paragraphing algorithm

2015-07-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241614



--- Comment #7 from Kevin Fenzi ke...@scrye.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241614] Review Request: perl-Text-Reflow - Perl module for reflowing text files using Knuth's paragraphing algorithm

2015-07-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241614



--- Comment #5 from Petr Šabata psab...@redhat.com ---
Thanks.

This is still fairly simple.  You should see some other perl packages ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241614] Review Request: perl-Text-Reflow - Perl module for reflowing text files using Knuth's paragraphing algorithm

2015-07-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241614

Petr Šabata psab...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #6 from Petr Šabata psab...@redhat.com ---
New Package SCM Request
===
Package Name: perl-Text-Reflow
Short Description: Perl module for reflowing text files using Knuth's
paragraphing algorithm
Upstream URL: http://search.cpan.org/dist/Text-Reflow/
Owners: psabata jplesnik ppisar
Branches: f21 f22 f23
InitialCC: perl-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241614] Review Request: perl-Text-Reflow - Perl module for reflowing text files using Knuth's paragraphing algorithm

2015-07-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241614

Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
(In reply to Petr Šabata from comment #3)
 (In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
 That CPAN metadata you're referring to was added for version 1.10, released
 yesterday.  Version 1.09 (this review) only mentions license information in
 the source (GPLv3+ for the module and GPLv2+ for the reflow script).
 
 However, I've updated the package and changed the main package License tag
 to GPLv3+ and (GPL+ or Artistic).  The perl part of the module is still
 GPLv3+ only.
 
 And the reflow script still uses GPLv2+.
Pff, what a mess. Please add a comment explaining the licensing breakdown
to the spec file
[https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios].

 * Version bumped to 1.10
 * License tag updated
 * Build time dep list updated
 * Patch dropped as it was incorporated upstream
 * Module files are listed only once

OK, fedora-review doesn't see any issues.
Requires and Depends look correct.
Package is APPROVED.

Rpmlint
---
Checking: perl-Text-Reflow-1.10-1.fc23.x86_64.rpm
  reflow-1.10-1.fc23.noarch.rpm
  perl-Text-Reflow-1.10-1.fc23.src.rpm
perl-Text-Reflow.x86_64: W: spelling-error Summary(en_US) reflowing - re
flowing, re-flowing, ref lowing
perl-Text-Reflow.x86_64: W: spelling-error %description -l en_US filehandle -
file handle, file-handle, mishandle
reflow.noarch: W: no-documentation
reflow.noarch: E: incorrect-fsf-address /usr/bin/reflow
reflow.noarch: W: no-manual-page-for-binary reflow
perl-Text-Reflow.src: W: spelling-error Summary(en_US) reflowing - re flowing,
re-flowing, ref lowing
perl-Text-Reflow.src: W: spelling-error %description -l en_US filehandle -
file handle, file-handle, mishandle
3 packages and 0 specfiles checked; 1 errors, 6 warnings.

Rpmlint (installed packages)

sh: /usr/bin/python: No such file or directory
reflow.noarch: W: no-documentation
reflow.noarch: E: incorrect-fsf-address /usr/bin/reflow
reflow.noarch: W: no-manual-page-for-binary reflow
3 packages and 0 specfiles checked; 1 errors, 2 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241614] Review Request: perl-Text-Reflow - Perl module for reflowing text files using Knuth's paragraphing algorithm

2015-07-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241614



--- Comment #3 from Petr Šabata psab...@redhat.com ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
 Are you sure about the license? http://search.cpan.org/dist/Text-Reflow/
 says Perl 5 license (artistic 1 and gpl 1). Source files seem to say
 Artistic or GPLv3+. So License should probably be:
 License: GPLv3+ or Artistic.

That CPAN metadata you're referring to was added for version 1.10, released
yesterday.  Version 1.09 (this review) only mentions license information in the
source (GPLv3+ for the module and GPLv2+ for the reflow script).

However, I've updated the package and changed the main package License tag to
GPLv3+ and (GPL+ or Artistic).  The perl part of the module is still GPLv3+
only.

And the reflow script still uses GPLv2+.

 - Package does not contain duplicates in %files.
   Note: warning: File listed twice: /usr/lib64/perl5/vendor_perl/auto/Text
   See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

Fixed.

--

Spec URL:
https://psabata.fedorapeople.org/pkgs/perl-Text-Reflow/perl-Text-Reflow.spec
SRPM URL:
https://psabata.fedorapeople.org/pkgs/perl-Text-Reflow/perl-Text-Reflow-1.10-1.fc22.src.rpm

* Version bumped to 1.10
* License tag updated
* Build time dep list updated
* Patch dropped as it was incorporated upstream
* Module files are listed only once

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241614] Review Request: perl-Text-Reflow - Perl module for reflowing text files using Knuth's paragraphing algorithm

2015-07-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241614

Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Are you sure about the license? http://search.cpan.org/dist/Text-Reflow/ says
Perl 5 license (artistic 1 and gpl 1). Source files seem to say Artistic or
GPLv3+. So License should probably be:
License: GPLv3+ or Artistic.

- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/lib64/perl5/vendor_perl/auto/Text
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241614] Review Request: perl-Text-Reflow - Perl module for reflowing text files using Knuth's paragraphing algorithm

2015-07-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241614



--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
... or the other way around, following
https://fedoraproject.org/wiki/Packaging:Perl#License_tag:
License:  GPL+ or Artistic

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review