[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-importmagic-0.1.3-3. |python-importmagic-0.1.3-3. |fc22|fc21 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- python-importmagic-0.1.3-3.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-importmagic-0.1.3-3. ||fc22 Resolution|--- |ERRATA Last Closed||2015-07-29 20:50:58 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- python-importmagic-0.1.3-3.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- python-importmagic-0.1.3-3.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- python-importmagic-0.1.3-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-importmagic-0.1.3-3.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- python-importmagic-0.1.3-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-importmagic-0.1.3-3.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 --- Comment #15 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 --- Comment #14 from Jonathan Underwood jonathan.underw...@gmail.com --- New Package SCM Request === Package Name: python-importmagic Short Description: Python library to auto-magically add, remove and manage imports Upstream URL: http://github.com/alecthomas/importmagic Owners: jgu Branches: f21 f22 f23 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 --- Comment #12 from Jonathan Underwood jonathan.underw...@gmail.com --- Great, thanks toy you both for the reviews and works you put into this, much appreciated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 Jonathan Underwood jonathan.underw...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 --- Comment #13 from Jonathan Underwood jonathan.underw...@gmail.com --- New Package SCM Request === Package Name: python-importmagic Short Description: Python library to auto-magically add, remove and manage imports Upstream URL: http://github.com/alecthomas/importmagic Owners: jgu Branches: f21 f22 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 --- Comment #10 from Jonathan Underwood jonathan.underw...@gmail.com --- (In reply to Marcin Haba from comment #9) Thanks for kind words and Spec update. I checked your latest package 0.1.3-3. RPMs packages install well and work for me, at least in interactive python and python.3.4 mode the module imports successfully. It is basic check only, not QA phase. Yup, thanks for that. Note also that during package building upstream's test harness is ran for both py2 and py3 in %check, and that passes all tests. Of course the test suite may not have 100% coverage, but it's a good sign. I also have seen you request to upstream about using python-six from outside importmagic project. Yup. I wonder how many other existing fedora packages have a bundled six.py ... it'd be interesting to spin up a virtual machine and install python* and then use find to locate any instances of six.py. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 William Moreno williamjmore...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from William Moreno williamjmore...@gmail.com --- Thanks @Marcin great job in the review, I have not aditional comments to the spec, very nice tool this to be included in Fedora and EPEL @Jonathan. = PACKAGE APPROVED = -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 --- Comment #7 from Jonathan Underwood jonathan.underw...@gmail.com --- Spec URL: https://jgu.fedorapeople.org/python-importmagic.spec SRPM URL: https://jgu.fedorapeople.org/python-importmagic-0.1.3-3.fc22.src.rpm * Sun Jul 12 2015 Jonathan Underwood jonathan.underw...@gmail.com - 0.1.3-3 - Fix typo in %%check - Remove macro from URL - Unbundle python-six files - Require and BuildRequire (for %%check) python[3]-six - Remove tabs from spec file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 --- Comment #8 from Jonathan Underwood jonathan.underw...@gmail.com --- @Marcin - good catch on the six.py bundling, and thanks for the informal review, very helpful. @William Thanks for the %%check catch, good eyes! I've changed the URL to not use the macro. However, please do note that's not required by any packaging guidelines, and using macros in the URL is a very common thing in packages. I don't have strong feelings either way so was happy with changing it, but you might meet push-back from other package maintainers if you raise that in other reviews. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 --- Comment #9 from Marcin Haba marcin.h...@bacula.pl --- Thanks for kind words and Spec update. I checked your latest package 0.1.3-3. RPMs packages install well and work for me, at least in interactive python and python.3.4 mode the module imports successfully. It is basic check only, not QA phase. I also have seen you request to upstream about using python-six from outside importmagic project. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 Marcin Haba marcin.h...@bacula.pl changed: What|Removed |Added CC||marcin.h...@bacula.pl --- Comment #1 from Marcin Haba marcin.h...@bacula.pl --- Hello, During build your package I received following traceback: /usr/bin/python2 setup.py build Traceback (most recent call last): File setup.py, line 2, in module from setuptools import Command, find_packages, setup ImportError: No module named setuptools It looks that you need to define in Spec file as build requires python-setuptools package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 --- Comment #3 from William Moreno williamjmore...@gmail.com --- Please check this rpmlint message: python-importmagic.src:33: W: mixed-use-of-spaces-and-tabs (spaces: line 33, tab: line 17) Also will be good if you use the full link to upstream website, this way it is easyier to visit upstream website with only copying the provided link. This package build fine in all soported releases: https://copr.fedoraproject.org/coprs/williamjmorenor/ERPNext/monitor/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944
--- Comment #4 from William Moreno williamjmore...@gmail.com ---
Here is a typo:
%if %{with python3}
pushd python3
%{__python2} setup.py test
popd
%endif
You are testing with Python2 the Python3 build
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944
--- Comment #5 from Marcin Haba marcin.h...@bacula.pl ---
Hello,
It is unofficial review because I am not packages maintainer.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[-]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: MIT/X11 (BSD like), Unknown or generated. 22 files have
unknown license. Detailed output of licensecheck in /home/gani/1241944
-python-importmagic/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-importmagic
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 --- Comment #6 from Marcin Haba marcin.h...@bacula.pl --- About automatically marked point: [x]: Package does not own files or directories owned by other packages. I found in fedora-review's generic plugin class description: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. So, it is not a bug, but it is my misunderstanding this point meaning. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 --- Comment #2 from Jonathan Underwood jonathan.underw...@gmail.com --- Spec URL: https://jgu.fedorapeople.org/python-importmagic.spec SRPM URL: https://jgu.fedorapeople.org/python-importmagic-0.1.3-2.fc22.src.rpm * Sat Jul 11 2015 Jonathan Underwood jonathan.underw...@gmail.com - 0.1.3-2 - Add BuildRequires for python-setuptools and python3-setuptools -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 William Moreno williamjmore...@gmail.com changed: What|Removed |Added CC||williamjmore...@gmail.com Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
