[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Michael Schwendt (Fedora Packager Sponsors Group) changed: What|Removed |Added Summary|Review Request: |Review Request: |python-UcsSdk - New package |python-UcsSdk - Python SDK ||for Cisco UCS Manager --- Comment #1 from Michael Schwendt (Fedora Packager Sponsors Group) --- Try pointing the fedora-review tool at this ticket: fedora-review -b 1242011 It evaluates the "Spec URL:" and "SRPM URL:" lines, downloads the latest files and packages, performs local test-builds and many checks related to the packaging guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Steve Linabery changed: What|Removed |Added CC||slina...@redhat.com --- Comment #2 from Steve Linabery --- I think maybe the submitter meant to use this for the Spec URL: https://raw.githubusercontent.com/CiscoSystems/UcsSdk-spec/master/python-UcsSdk.spec Note that if you add a new comment with new values for those fields, the fedora-review tool should pick up your change from the most recent comment. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #3 from Brian Demers --- Spec URL: https://raw.githubusercontent.com/CiscoSystems/UcsSdk-spec/master/python-UcsSdk.spec SRPM URL: https://github.com/CiscoSystems/UcsSdk-spec/releases/download/new-spec/python-UcsSdk-0.8.2.2-0.el7.centos.src.rpm Thanks Steve, I didn't think about needing the raw file URL -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #4 from Steve Linabery --- Try running the fedora-review tool as mentioned in Comment 1. When I do, I see, in review.txt, at least these problems: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). Also at least the Errors from rpmlint need to be cleared up (and probably the Warn, too). Just trying to help you get this in shape for when someone actually picks up this review. I don't think that someone is me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Alan Pevec changed: What|Removed |Added CC||ape...@redhat.com --- Comment #5 from Alan Pevec --- Anyone in packagers group can do the formal review, sponsorship is separate. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011
Haïkel Guémar changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||karlthe...@gmail.com
Assignee|nob...@fedoraproject.org|karlthe...@gmail.com
Flags||fedora-review?
--- Comment #6 from Haïkel Guémar ---
@Brian: could you do two informal reviews from the list below (avoid the ones
in green) and link them back here ?
http://fedoraproject.org/PackageReviewStatus/NEW.html
I'll take care of sponsorship process as soon as you do. I recommend using
fedora-review for reviews.
For your package, I recommend few fixes:
* use versionned python macros
%{__python} => %{__python2}
%{python_sitelib} => %{python2_sitelib}
* add changelog entries
* add missing license tag
* update to upstream 0.8.3 (which has now license file)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #7 from Brian Demers --- Informal reviews for other projects: 1243550, 1234664 Spec URL: https://raw.githubusercontent.com/CiscoSystems/UcsSdk-spec/d20dd9157aa9d26ecd48dc550c6388ad005125d9/python-UcsSdk.spec SRPM URL: https://github.com/CiscoSystems/UcsSdk-spec/releases/download/new-spec-2/python-UcsSdk-0.8.2.2-0.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Ihar Hrachyshka changed: What|Removed |Added CC||ihrac...@redhat.com --- Comment #8 from Ihar Hrachyshka --- Shouldn't release generally start from 1, not 0? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 hgue...@redhat.com changed: What|Removed |Added CC||brdem...@cisco.com, ||hgue...@redhat.com Flags||needinfo?(brdem...@cisco.co ||m) --- Comment #9 from hgue...@redhat.com --- +1 I'd move the dos2unix one-liner in %setup too Is there a reason not to ship 0.8.3 ? it's the latest one and it provides license file? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Brian Demers changed: What|Removed |Added Flags|needinfo?(brdem...@cisco.co | |m) | --- Comment #10 from Brian Demers --- Spec URL: https://raw.githubusercontent.com/CiscoSystems/UcsSdk-spec/new-spec-3/python-UcsSdk.spec SRPM URL: https://github.com/CiscoSystems/UcsSdk-spec/releases/download/new-spec-3/python-UcsSdk-0.8.2.4-1.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011
Haïkel Guémar changed:
What|Removed |Added
Blocks|177841 (FE-NEEDSPONSOR) |
Flags|fedora-review? |fedora-review+
--- Comment #11 from Haïkel Guémar ---
Thanks Brian, you did a great job hence I sponsored you into the packager
group.
Use your power for good, and never hesitate contacting me if you have any
question
or need help.
As this package complies with Fedora packaging guidelines, I hereby approve
it into Fedora packages collection.
Please submit a SCM request as explained on the following wiki page.
https://fedoraproject.org/wiki/Package_SCM_admin_requests#New_Packages
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)". Detailed output of licensecheck in
/home/haikel/1242011-python-UcsSdk/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-En
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Haïkel Guémar changed: What|Removed |Added Blocks||1243533 ||(RDO-LIBERTY-REVIEWS) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1243533 [Bug 1243533] (RDO) Tracker: Review requests for new RDO Liberty packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #12 from Brian Demers --- New Package SCM Request === Package Name: python-UcsSdk Short Description: Python development kit for Cisco UCS Upstream URL: https://github.com/CiscoUcs/UcsPythonSDK Owners: bdemers Branches: f23 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 bdemers changed: What|Removed |Added CC||brian.dem...@gmail.com Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #13 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Ihar Hrachyshka changed: What|Removed |Added Flags||needinfo?(brdem...@cisco.co ||m) --- Comment #14 from Ihar Hrachyshka --- Was the initial package built for Fedora? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Brian Demers changed: What|Removed |Added Flags|needinfo?(brdem...@cisco.co | |m) | --- Comment #15 from Brian Demers --- Ihar, there are branches for f23 and epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Alan Pevec changed: What|Removed |Added Flags||needinfo?(brdem...@cisco.co ||m) --- Comment #16 from Alan Pevec --- Brian, you need to run fedpkg update in each f23 and epel7 branches to push the update. Set type=newpackage and bugs=1242011 and Bodhi will update status in this BZ. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Alan Pevec changed: What|Removed |Added Status|ASSIGNED|MODIFIED Fixed In Version||python-UcsSdk-0.8.2.4-1.fc2 ||4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #17 from Fedora Update System --- python-UcsSdk-0.8.2.4-1.fc23 has been submitted as an update for Fedora 23. https://admin.fedoraproject.org/updates/python-UcsSdk-0.8.2.4-1.fc23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #18 from Fedora Update System --- python-UcsSdk-0.8.2.4-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-UcsSdk-0.8.2.4-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #19 from Fedora Update System --- python-UcsSdk-0.8.2.4-1.el7 has been pushed to the Fedora EPEL 7 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Brian Demers changed: What|Removed |Added CC||mbu...@redhat.com Flags|needinfo?(brdem...@cisco.co | |m) | --- Comment #20 from Brian Demers --- I pushed a new version python-UcsSdk-0.8.2.5-1.el7 and sent Mike Burns patch for the rhos repo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #21 from Fedora Update System --- python-UcsSdk-0.8.2.5-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update python-UcsSdk'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-7810 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #22 from Fedora Update System --- python-UcsSdk-0.8.2.5-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update python-UcsSdk'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14377 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Brian Demers changed: What|Removed |Added Fixed In Version|python-UcsSdk-0.8.2.4-1.fc2 |python-UcsSdk-0.8.2.5-1.fc2 |4 |4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #23 from Fedora Update System --- python-UcsSdk-0.8.2.5-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version|python-UcsSdk-0.8.2.5-1.fc2 |0.8.2.5-1.fc23 |4 | Resolution|--- |NEXTRELEASE Last Closed||2015-09-05 21:10:43 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #24 from Fedora Update System --- python-UcsSdk-0.8.2.5-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
