[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896

Alan Pevec  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||python-ironic-inspector-cli
   ||ent-1.2.0-2.fc24
 Resolution|--- |RAWHIDE
Last Closed||2015-10-07 06:50:36



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896



--- Comment #14 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896



--- Comment #11 from Dmitry Tantsur dtant...@redhat.com ---
done, build http://koji.fedoraproject.org/koji/taskinfo?taskID=10658944

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896

Julien Enselme juj...@jujens.eu changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #12 from Julien Enselme juj...@jujens.eu ---
Looks good, approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896

Dmitry Tantsur divius.ins...@gmail.com changed:

   What|Removed |Added

 CC||divius.ins...@gmail.com
  Flags||fedora-cvs?



--- Comment #13 from Dmitry Tantsur divius.ins...@gmail.com ---
New Package SCM Request
===
Package Name: python-ironic-inspector-client
Short Description: Python client and CLI tool for Ironic Inspector
Upstream URL: https://launchpad.net/python-ironic-inspector-client
Owners: divius
Branches: f23
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896

Julien Enselme juj...@jujens.eu changed:

   What|Removed |Added

  Flags|needinfo?(juj...@jujens.eu) |



--- Comment #10 from Julien Enselme juj...@jujens.eu ---
Just spotted: please use %license for LICENSE as described here:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

PS: No need to always as for needinfo, as the reviewer I am in the CC list of
this bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896

Dmitry Tantsur dtant...@redhat.com changed:

   What|Removed |Added

  Flags||needinfo?(juj...@jujens.eu)



--- Comment #9 from Dmitry Tantsur dtant...@redhat.com ---
Thanks for review, updated. Build
http://koji.fedoraproject.org/koji/taskinfo?taskID=10634457

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896

Dmitry Tantsur dtant...@redhat.com changed:

   What|Removed |Added

  Flags||needinfo?(juj...@jujens.eu)



--- Comment #7 from Dmitry Tantsur dtant...@redhat.com ---
Thanks, I've updated package, build
http://koji.fedoraproject.org/koji/taskinfo?taskID=10613211

However, seems like %python_provide macro does not exist in rawhide. Should I
insert Provides: python-ironic-inspector-client manually?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896

Julien Enselme juj...@jujens.eu changed:

   What|Removed |Added

  Flags|needinfo?(juj...@jujens.eu) |



--- Comment #8 from Julien Enselme juj...@jujens.eu ---
 However, seems like %python_provide macro does not exist in rawhide. Should I 
 insert Provides: python-ironic-inspector-client manually?

It does, your package wouldn't have built on koji otherwise. Are you speaking
of f21? Last time I checked they were in testing. But you can use a good old
Provides in the mean time.

When you created the python2 subpackage, you put Requires and Conflicts after
the %description. rpmlint complains about this:

Rpmlint
---
Checking: python2-ironic-inspector-client-1.0.1-1.fc24.noarch.rpm
  python-ironic-inspector-client-1.0.1-1.fc24.src.rpm
python2-ironic-inspector-client.noarch: W: spelling-error %description -l en_US 
oslo - solo, Oslo
python2-ironic-inspector-client.noarch: W: spelling-error %description -l en_US 
utils - tills
python2-ironic-inspector-client.noarch: W: spelling-error %description -l en_US 
openstackclient - happenstance
python2-ironic-inspector-client.noarch: W: spelling-error %description -l en_US 
discoverd - discovers, discover, discovered
python2-ironic-inspector-client.noarch: W: tag-in-description C Requires:
python2-ironic-inspector-client.noarch: W: tag-in-description C Requires:
python2-ironic-inspector-client.noarch: W: tag-in-description C Requires:
python2-ironic-inspector-client.noarch: W: tag-in-description C Requires:
python2-ironic-inspector-client.noarch: W: tag-in-description C Requires:
python2-ironic-inspector-client.noarch: W: tag-in-description C Requires:
python2-ironic-inspector-client.noarch: W: tag-in-description C Conflicts:
2 packages and 0 specfiles checked; 0 errors, 11 warnings.


Please fix this by moving Requires and Conflics in %package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896

Dmitry Tantsur dtant...@redhat.com changed:

   What|Removed |Added

  Flags||needinfo?(juj...@jujens.eu)



--- Comment #4 from Dmitry Tantsur dtant...@redhat.com ---
Hi! I can add BuildRequires but I can't run tests in %check section, as it
requires all the dependencies to be installed. Or did you mean I just add
BuildRequires without touching %check?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896

Julien Enselme juj...@jujens.eu changed:

   What|Removed |Added

  Flags|needinfo?(juj...@jujens.eu) |



--- Comment #5 from Julien Enselme juj...@jujens.eu ---
 I can add BuildRequires but I can't run tests in %check section, as it 
 requires all the dependencies to be installed.

You can add these dependencies as BR so tests can execute. Given the number of
dependencies, this is not a big deal.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896



--- Comment #6 from Julien Enselme juj...@jujens.eu ---
Before I forget, python guidelines changed recently. Python2 packages are row
subpackages of the main package (as are python3 packages). They also need a
Requires. See: https://fedoraproject.org/wiki/Packaging:Python for the macros
that will help you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896

Julien Enselme juj...@jujens.eu changed:

   What|Removed |Added

  Flags|needinfo?(juj...@jujens.eu) |



--- Comment #3 from Julien Enselme juj...@jujens.eu ---
(In reply to Dmitry Tantsur from comment #2)

 - You've tried to install the package on F21. I'm pretty sure it does not
 have all the dependencies. The following succeeds:
 sudo mock -r fedora-rawhide-x86_64 -i
 https://kojipkgs.fedoraproject.org//work/tasks/1987/10351987/python-ironic-
 inspector-client-1.0.1-1.fc23.noarch.rpm

Just tested with:
fedora-review -b 1242896 -m fedora-rawhide-x86_64

it works fine.
 
 - By python 3 support upstream means unit tests pass on Python 3 mostly. As
 python-openstackclient is only involved in a shell script, it's not a big
 deal for tests. But we probably can't declare Python 3 compatibility until
 it's fixed.

OK, this was just to know.
 
 - `python -m unittest discover ironic_inspector_client.test` works, though
 requires python-mock (not sure how to handle it, as it's not a runtime
 dependency for the project itself).

You should add the dependency as BuildRequires. Once this is done, I will
approve the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896

Dmitry Tantsur dtant...@redhat.com changed:

   What|Removed |Added

  Flags||needinfo?(juj...@jujens.eu)



--- Comment #2 from Dmitry Tantsur dtant...@redhat.com ---
Hi, sorry for late reply.

- You've tried to install the package on F21. I'm pretty sure it does not have
all the dependencies. The following succeeds:
sudo mock -r fedora-rawhide-x86_64 -i
https://kojipkgs.fedoraproject.org//work/tasks/1987/10351987/python-ironic-inspector-client-1.0.1-1.fc23.noarch.rpm

- By python 3 support upstream means unit tests pass on Python 3 mostly. As
python-openstackclient is only involved in a shell script, it's not a big deal
for tests. But we probably can't declare Python 3 compatibility until it's
fixed.

- `python -m unittest discover ironic_inspector_client.test` works, though
requires python-mock (not sure how to handle it, as it's not a runtime
dependency for the project itself).

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896

Julien Enselme juj...@jujens.eu changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||juj...@jujens.eu
   Assignee|nob...@fedoraproject.org|juj...@jujens.eu
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896



--- Comment #1 from Julien Enselme juj...@jujens.eu ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[X]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: Apache (v2.0), Unknown or generated, *No copyright* Apache
 (v2.0). 1 files have unknown license. Detailed output of licensecheck
 in /tmp/1242896-python-ironic-inspector-client/licensecheck.txt
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
 names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[X]: Python eggs must not download any dependencies during the build
 process.
[X]: A package which is used by another package via an egg interface should
 provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[X]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[X]: Package should compile and build into binary rpms on all supported
 architectures.
[!]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed
 files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI 

[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242896

Dmitry Tantsur dtant...@redhat.com changed:

   What|Removed |Added

 Blocks||1243533
   ||(RDO-LIBERTY-REVIEWS)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1243533
[Bug 1243533] (RDO) Tracker: Review requests for new RDO Liberty packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review