[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|perl-Algorithm-LUHN-1.01-3. |perl-Algorithm-LUHN-1.01-3. |el6 |fc22 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- perl-Algorithm-LUHN-1.01-3.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||perl-Algorithm-LUHN-1.01-3. ||el7 Resolution|NEXTRELEASE |ERRATA --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- perl-Algorithm-LUHN-1.01-3.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|perl-Algorithm-LUHN-1.01-3. |perl-Algorithm-LUHN-1.01-3. |el7 |el6 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- perl-Algorithm-LUHN-1.01-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- perl-Algorithm-LUHN-1.01-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/perl-Algorithm-LUHN-1.01-3.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 Bill Pemberton wf...@worldbroken.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ --- Comment #9 from Bill Pemberton wf...@worldbroken.com --- I didn't see these branches initially, I see them now. I was impatient. Apologizes for the noise. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- perl-Algorithm-LUHN-1.01-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-Algorithm-LUHN-1.01-3.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- perl-Algorithm-LUHN-1.01-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Algorithm-LUHN-1.01-3.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 Bill Pemberton wf...@worldbroken.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2015-07-21 08:49:01 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 Bill Pemberton wf...@worldbroken.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #8 from Bill Pemberton wf...@worldbroken.com --- Package Change Request == Package Name: perl-Algorithm-LUHN New Branches: el6 epel7 Owners: wfp -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 Bill Pemberton wf...@worldbroken.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Bill Pemberton wf...@worldbroken.com --- New Package SCM Request === Package Name: perl-Algorithm-LUHN Short Description: Calculate the Modulus 10 Double Add Double checksum Upstream URL: http://search.cpan.org/dist/Algorithm-LUHN/ Owners: wfp Branches: f22 f23 el6 epel7 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Petr Šabata psab...@redhat.com --- (In reply to Bill Pemberton from comment #4) I just realized that I removed perl from the BuildRequires instead of just removing the version requirement. Do I need to add that back or is it ok to assume the other perl BuildRequires will take care of it? Add it back. Although it's almost certain something will pull perl into the buildroot, you can never know. And since you're using it yourself, you need to buildrequire it. Anyhow, I trust you'll add it before pushing the package. I ack you've fixed everything I've pointed out so I'm going to approve this now :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 --- Comment #3 from Bill Pemberton wf...@worldbroken.com --- Updated to hopefully address these concerns. Spec URL: https://wfp.fedorapeople.org/perl-Algorithm-LUHN.spec SRPM URL: https://wfp.fedorapeople.org/perl-Algorithm-LUHN-1.01-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 --- Comment #4 from Bill Pemberton wf...@worldbroken.com --- I just realized that I removed perl from the BuildRequires instead of just removing the version requirement. Do I need to add that back or is it ok to assume the other perl BuildRequires will take care of it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507
Petr Šabata psab...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||psab...@redhat.com
Assignee|nob...@fedoraproject.org|psab...@redhat.com
Flags||fedora-review?
--- Comment #2 from Petr Šabata psab...@redhat.com ---
Bill, Athos,
there are actually some issues with this package.
* The perl version constraint (buildtime dependency) has no practical efect.
* The package calls `find', `make', `rm' and `rmdir', yet doesn't depend on
packages providing these commands. Note Fedora Packaging Guidelines no longer
list any packages guaranteed to be present in every buildroot. Add
`coreutils', `findutils' and `make' as build dependencies.
* The minimum required version of ExtUtils::MakeMaker is 6.30. (Makefile.PL:8)
* Some perl build dependencies are missing:
- strict, used in Makefile.PL, tests and the tested code
- Test, used in tests
- warnings, used in Makefile.PL and the tested code
* The Exporter runtime dependency is autodetected and doesn't need to be
explicitly Require'd.
* Modern EU::MM supports DESTDIR. This can be used in place of
PERL_INSTALL_ROOT.
* Line 34 is unnecessary. (find %{buildroot} -depth -type d -exec rmdir {}
2/dev/null \;)
* The `dist.ini' file has zero value for the end user and I would advise
against packaging it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507
Athos Ribeiro athoscribe...@gmail.com changed:
What|Removed |Added
CC||athoscribe...@gmail.com
--- Comment #1 from Athos Ribeiro athoscribe...@gmail.com ---
This is an informal review since, I have no rights of performing official
reviews and it is also my first package review attempt, I hope it helps:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: Unknown or generated. 1 files have unknown license. Detailed
output of licensecheck in /home/packager/package_reviews/1243507-perl-
Algorithm-LUHN/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/perl5/vendor_perl/Algorithm(perl-Algorithm-Diff)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]:
