[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 gil cattaneo changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-02-19 05:43:08 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 gil cattaneo changed: What|Removed |Added Fixed In Version||asynchbase-1.7.2-1.fc26 --- Comment #12 from gil cattaneo --- Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=17950725 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 --- Comment #11 from Kevin Fenzi --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/asynchbase -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 --- Comment #10 from gil cattaneo --- Thanks for the review! create new SCM requests: https://admin.fedoraproject.org/pkgdb/package/requests/9374 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 gil cattaneo changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 marcindulak changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 --- Comment #9 from gil cattaneo --- (In reply to marcindulak from comment #7) > [?]: Package is not known to require an ExcludeArch tag. > [?]: Package should compile and build into binary rpms on all supported > architectures. Maybe, you should read this point of the java guideline: "Java programs that wish to make calls into native libraries do so via the Java Native Interface (JNI). A Java package uses JNI if it contains a .so file. Note that this file can be embedded within JAR files themselves." https://fedoraproject.org/wiki/Packaging:Java#Packaging_JAR_files_that_use_JNI This library do not use JNI and so is a noarch package. The make generate only an XML file (pom.xml) and this one is noarch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 --- Comment #8 from gil cattaneo --- (In reply to marcindulak from comment #7) > Please check these points: > > [?]: Package contains no bundled libraries without FPC exception. > > Do we need to apply for FPC for bundled(hbase)? No guideline is says only to add bundled(foo) https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries#Treatment_of_Bundled_Libraries > [?]: Package is not known to require an ExcludeArch tag. I don't understand, "BuildArch: noarch" ... > [?]: Package should compile and build into binary rpms on all supported > architectures. ... as above ... ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 --- Comment #7 from marcindulak --- Please check these points: [?]: Package contains no bundled libraries without FPC exception. Do we need to apply for FPC for bundled(hbase)? [?]: Package is not known to require an ExcludeArch tag. [?]: Package should compile and build into binary rpms on all supported architectures. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657
--- Comment #6 from marcindulak ---
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "Apache (v2.0)", "Unknown or generated", "*No
copyright* Apache (v2.0)". 18 files have unknown license. Detailed
output of licensecheck in
/home/vagrant/1244657-asynchbase/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It
is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including metadata) even
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 --- Comment #5 from gil cattaneo --- Spec URL: https://gil.fedorapeople.org/asynchbase.spec SRPM URL: https://gil.fedorapeople.org/asynchbase-1.7.2-1.fc24.src.rpm - move to protobuf 3.1 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16648849 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 gil cattaneo changed: What|Removed |Added Flags|needinfo?(Marcin.Dulak@gmai | |l.com) | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 gil cattaneo changed: What|Removed |Added Flags||needinfo?(Marcin.Dulak@gmai ||l.com) --- Comment #4 from gil cattaneo --- @Marcin the package do not build with protobuf 3.x, the actual release in rawhide. Please, skip this review. Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 marcindulak changed: What|Removed |Added CC||marcin.du...@gmail.com Assignee|nob...@fedoraproject.org|marcin.du...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 --- Comment #3 from gil cattaneo --- NOT Ready -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 --- Comment #2 from gil cattaneo --- Spec URL: https://gil.fedorapeople.org/asynchbase.spec SRPM URL: https://gil.fedorapeople.org/asynchbase-1.7.2-1.fc24.src.rpm - update to 1.7.2 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15973942 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 Bug 1244657 depends on bug 1244655, which changed state. Bug 1244655 Summary: Review Request: async - StumbleUpon's Async Library https://bugzilla.redhat.com/show_bug.cgi?id=1244655 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 --- Comment #1 from gil cattaneo --- Spec URL: https://gil.fedorapeople.org/asynchbase.spec SRPM URL: https://gil.fedorapeople.org/asynchbase-1.7.0-1.fc23.src.rpm - update to 1.7.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 gil cattaneo changed: What|Removed |Added Blocks||1279201 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1279201 [Bug 1279201] Review Request: flume - A distributed log collection application for collecting data -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 gil cattaneo changed: What|Removed |Added Depends On||1244655 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1244655 [Bug 1244655] Review Request: async - StumbleUpon's Async Library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
