[Bug 1244658] Review Request: dgit - Integration between git and Debian-style archives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244658

Igor Gnatenko  changed:

   What|Removed |Added

 Resolution|EOL |CURRENTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1244658] Review Request: dgit - Integration between git and Debian-style archives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244658

Fedora End Of Life  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |EOL
Last Closed||2016-07-19 13:05:23



--- Comment #7 from Fedora End Of Life  ---
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1244658] Review Request: dgit - Integration between git and Debian-style archives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244658

Mike McCune  changed:

   What|Removed |Added

 Status|MODIFIED|POST



--- Comment #6 from Mike McCune  ---
This bug was accidentally moved from POST to MODIFIED via an error in
automation, please see mmcc...@redhat.com with any questions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244658] Review Request: dgit - Integration between git and Debian-style archives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244658

Sat6QE Jenkins  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244658] Review Request: dgit - Integration between git and Debian-style archives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244658



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244658] Review Request: dgit - Integration between git and Debian-style archives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244658

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244658] Review Request: dgit - Integration between git and Debian-style archives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244658

Lubomir Rintel lkund...@v3.sk changed:

   What|Removed |Added

 CC||lkund...@v3.sk
  Flags||fedora-cvs?



--- Comment #3 from Lubomir Rintel lkund...@v3.sk ---
Thanks for the review.

New Package SCM Request
===
Package Name: dgit
Short Description: Integration between git and Debian-style archives
Upstream URL: https://browse.dgit.debian.org/dgit.git/
Owners: foo lkundrak
Branches: f21 f22 f23 el6 epel7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244658] Review Request: dgit - Integration between git and Debian-style archives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244658



--- Comment #4 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244658] Review Request: dgit - Integration between git and Debian-style archives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244658

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244658] Review Request: dgit - Integration between git and Debian-style archives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244658

Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244658] Review Request: dgit - Integration between git and Debian-style archives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244658

Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
GPLv3.

[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. No licenses
 found. Please check the source files for licenses manually.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/perl5/vendor_perl/Debian(debconf, debhelper)
OK.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[!]: Package contains the mandatory BuildRequires and Requires:.
 Note: Requires: perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`;
 echo $version)) missing?

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
 Note: Package contains tarball without URL, check comments
Pfff. They should really enable tarballs on git.dgit.debian.org.

[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot 

[Bug 1244658] Review Request: dgit - Integration between git and Debian-style archives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244658

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

 CC||i...@cicku.me



--- Comment #1 from Christopher Meng i...@cicku.me ---
Just a side note, I tried to package dput and then found it's no longer
developed anymore. See Bug 987738.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review