[Bug 1244760] Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760 Vít Ondruch changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||rubygem-six-0.2.0-4.fc24 Resolution|--- |RAWHIDE Last Closed||2015-09-29 01:40:14 --- Comment #11 from Vít Ondruch --- This is Rawhide already => closing this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244760] Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760 Vít Ondruch changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Flags|fedora-review? |fedora-review+ --- Comment #10 from Vít Ondruch --- Thanks. I sponsored you and APPROVE this package, please continue with the SCM procedure. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244760] Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760 --- Comment #9 from Ilya Gradina --- unofficial review: https://bugzilla.redhat.com/show_bug.cgi?id=1262965#c1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244760] Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760 --- Comment #8 from Vít Ondruch --- (In reply to Ilya Gradina from comment #7) > I have added link to pull request which adds license in files distribution. Thx > What is my next steps? I'm still waiting for some informal reviews. So far, I saw only bug 1246974, where you posted just output from fedora-review without any other comment. For example, there appears to be some issues identified by rpmlint, so you should probably pinpoint them and check if they are false positives and probably propose fix for the others. I hope you understand this is not to discourage you, but to encourage proper packaging ... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244760] Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760 --- Comment #7 from Ilya Gradina --- Hi Vit! Spec URL: http://repo.clanwars.org/gitlab/rubygem-six.spec SRPM URL: http://repo.clanwars.org/gitlab/rubygem-six-0.2.0-4.fc23.src.rpm I have added link to pull request which adds license in files distribution. What is my next steps? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244760] Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760
--- Comment #6 from Vít Ondruch ---
(In reply to Ilya Gradina from comment #5)
> add license file as SOURCE2,
Thanks, although upstream issue or PR would be enough.
BTW if you include some patch or LICENSE file in this case, it is good habit to
provide some comment with reference, where you taken it. That way, next time
you or anybody else touch this .spec file, will have a chance to check what is
the progress of that issue. The patch could be already merged and the license
shipped in latest release or it might be time to ping upstream again.
> but I don't understand what did you mean by
> that "to expand the test suite in %check section".
You did "tar xf %{SOURCE1}" to expand the test suite in %prep section, but you
don't need this code for anything else except %check section. Hence you could
move it into %check section. That way you would be sure it will not propagate
into the output RPM by accident.
Nevertheless, that is my preference and somebody else could disagree. So this
is just to explain. Your current approach is just fine.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244760] Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760 --- Comment #5 from Ilya Gradina --- Hi Vit! Spec URL: http://repo.clanwars.org/gitlab/rubygem-six.spec SRPM URL: http://repo.clanwars.org/gitlab/rubygem-six-0.2.0-3.fc23.src.rpm add license file as SOURCE2, but I don't understand what did you mean by that "to expand the test suite in %check section". Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10593755 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244760] Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760 Vít Ondruch changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|vondr...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244760] Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760 --- Comment #4 from Vít Ondruch --- (In reply to Igor Gnatenko from comment #3) > you should change this bug title. This would be nice but not super-important. And the upstream summary/description is pretty brief I must say. * Test suite expansion - I would suggest to expand the test suite in %check section. This will avoid accidental inclusion of the test suite in resulting RPM. - If you prefer to keep it in %prep section, then you should probably use %setup macro with -a 1 or -b 1 parameters [1]. - You don't really need to delete the test suite after its execution, if you are using mock (not sure about local build thoug). * License text - The package does not contain any license information. You should contact upstream and encourage them to correct this mistake [2, 3]. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10587608 Otherwise, the package looks good. Could you please do some informal review so I can sponsor you? [1] http://www.rpm.org/max-rpm/s1-rpm-inside-macros.html [2] http://fedoraproject.org/wiki/Packaging:ReviewGuidelines [3] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244760] Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760 --- Comment #3 from Igor Gnatenko --- (In reply to Ilya Gradina from comment #2) > Spec URL: http://repo.clanwars.org/gitlab/rubygem-six.spec > SRPM URL: http://repo.clanwars.org/gitlab/rubygem-six-0.2.0-2.fc23.src.rpm > > changed description, changed summary, add rubygem(rspec) to BRs. What you have changed in description? What in summary? if you changed summary -- you should change this bug title. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244760] Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760 --- Comment #2 from Ilya Gradina --- Spec URL: http://repo.clanwars.org/gitlab/rubygem-six.spec SRPM URL: http://repo.clanwars.org/gitlab/rubygem-six-0.2.0-2.fc23.src.rpm changed description, changed summary, add rubygem(rspec) to BRs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244760] Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760 Vít Ondruch changed: What|Removed |Added CC||vondr...@redhat.com --- Comment #1 from Vít Ondruch --- Lets do bug 1244764 first ... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244760] Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760 Ilya Gradina changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
