[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Bug 1246120 depends on bug 1249651, which changed state. Bug 1249651 Summary: docker-py gets broken by old python-requests version https://bugzilla.redhat.com/show_bug.cgi?id=1249651 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version|atomic-reactor-1.4.0-2.fc24 |atomic-reactor-1.4.0-2.fc22 |atomic-reactor-1.4.0-2.fc23 | |atomic-reactor-1.4.0-2.fc22 | Resolution|--- |ERRATA Last Closed||2015-08-07 09:17:42 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- atomic-reactor-1.4.0-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Bohuslav Slavek Kabrda bkab...@redhat.com changed: What|Removed |Added Depends On||1249651 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1249651 [Bug 1249651] docker-py gets broken by old python-requests version -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- Package atomic-reactor-1.4.0-2.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing atomic-reactor-1.4.0-2.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-12144/atomic-reactor-1.4.0-2.fc22 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120
--- Comment #3 from Bohuslav Slavek Kabrda bkab...@redhat.com ---
Thanks for the review. Please see my comments inline:
(In reply to Michal Cyprian from comment #2)
* There is non executable script
/usr/share/atomic-reactor/images/privileged-builder/docker.sh with
permissions 644.
As a comment on line 239 notes, this file is not executable since it's not
meant for direct use on user's system, but should only be used in a container
(therefore the 644 privileges defend user from making unwanted harm). So
hopefully, this is ok.
* The lastest revision of Packaging Guidelines:Python don't recommend to use
macro %{py3dir}.
Fixed (I just don't use separate dirs for py3 build any more, which should be
correct and still work).
* License of the package and license field in spec are alright.
* Package was compiled and build successfully.
* import of atomic_reactor module is working properly in both python2 and
python3 subpackages.
* It is still not possible to run it as you have already noticed.
Since fixing bug 1245523 makes python-docker-py work again (until it's fixed
properly as requested in bug 1245521), it should work now.
Spec URL:
https://bkabrda.fedorapeople.org/pkgs/atomic-reactor/atomic-reactor.spec
SRPM URL:
https://bkabrda.fedorapeople.org/pkgs/atomic-reactor/atomic-reactor-1.4.0-2.fc22.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Bug 1246120 depends on bug 1245521, which changed state. Bug 1245521 Summary: docker-py gets broken by old python-websocket-client version https://bugzilla.redhat.com/show_bug.cgi?id=1245521 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Bohuslav Slavek Kabrda bkab...@redhat.com changed: What|Removed |Added Status|ASSIGNED|MODIFIED Fixed In Version||atomic-reactor-1.4.0-2.fc24 ||atomic-reactor-1.4.0-2.fc23 ||atomic-reactor-1.4.0-2.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- atomic-reactor-1.4.0-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/atomic-reactor-1.4.0-2.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 --- Comment #7 from Bohuslav Slavek Kabrda bkab...@redhat.com --- Note: this can't be built for epel7 now because of bug 1192534 comment 13. I'll leave this bug open and close it when f22, f23, rawhide and epel7 are built and gone through testing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Bohuslav Slavek Kabrda bkab...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Bohuslav Slavek Kabrda bkab...@redhat.com --- Great, thanks for your review! New Package SCM Request === Package Name: atomic-reactor Short Description: Improved builder for Docker images Upstream URL: https://github.com/projectatomic/atomic-reactor Owners: bkabrda ttomecek Branches: f22 f23 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Michal Cyprian mcypr...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Michal Cyprian mcypr...@redhat.com --- Everything seems to be alright now, It is possible to run it when python-websocket-client-0.32.0 is installed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Michal Cyprian mcypr...@redhat.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|mcypr...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Michal Cyprian mcypr...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mcypr...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120
--- Comment #2 from Michal Cyprian mcypr...@redhat.com ---
* There is non executable script
/usr/share/atomic-reactor/images/privileged-builder/docker.sh with permissions
644.
* The lastest revision of Packaging Guidelines:Python don't recommend to use
macro %{py3dir}.
* License of the package and license field in spec are alright.
* Package was compiled and build successfully.
* import of atomic_reactor module is working properly in both python2 and
python3 subpackages.
* It is still not possible to run it as you have already noticed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Bohuslav Slavek Kabrda bkab...@redhat.com changed: What|Removed |Added Depends On||1245521 --- Comment #1 from Bohuslav Slavek Kabrda bkab...@redhat.com --- Note: atomic-reactor can now be built, but won't actually run until bug 1245521 is fixed. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1245521 [Bug 1245521] docker-py gets broken by old python-websocket-client version -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
