[Bug 1249148] Review Request: nodejs-create-error-class - Create Error classes
https://bugzilla.redhat.com/show_bug.cgi?id=1249148 Parag Nemade pnem...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2015-08-17 06:09:27 --- Comment #7 from Parag Nemade pnem...@redhat.com --- Built in rawhide already. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249148] Review Request: nodejs-create-error-class - Create Error classes
https://bugzilla.redhat.com/show_bug.cgi?id=1249148 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249148] Review Request: nodejs-create-error-class - Create Error classes
https://bugzilla.redhat.com/show_bug.cgi?id=1249148 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249148] Review Request: nodejs-create-error-class - Create Error classes
https://bugzilla.redhat.com/show_bug.cgi?id=1249148 Parag Nemade pnem...@redhat.com changed: What|Removed |Added Blocks||1246749 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1246749 [Bug 1246749] nodejs-got-4.1.1 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249148] Review Request: nodejs-create-error-class - Create Error classes
https://bugzilla.redhat.com/show_bug.cgi?id=1249148 Bug 1249148 depends on bug 1249146, which changed state. Bug 1249146 Summary: Review Request: nodejs-capture-stack-trace - Error.captureStackTrace ponyfill https://bugzilla.redhat.com/show_bug.cgi?id=1249146 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249148] Review Request: nodejs-create-error-class - Create Error classes
https://bugzilla.redhat.com/show_bug.cgi?id=1249148 Parag Nemade pnem...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Parag Nemade pnem...@redhat.com --- Thank you. New Package SCM Request === Package Name: nodejs-create-error-class Short Description: Create Error classes Upstream URL: https://github.com/floatdrop/create-error-class Owners: pnemade Branches: f22 f23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249148] Review Request: nodejs-create-error-class - Create Error classes
https://bugzilla.redhat.com/show_bug.cgi?id=1249148 Piotr Popieluch piotr1...@gmail.com changed: What|Removed |Added Flags|fedora-review- |fedora-review+ --- Comment #4 from Piotr Popieluch piotr1...@gmail.com --- APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249148] Review Request: nodejs-create-error-class - Create Error classes
https://bugzilla.redhat.com/show_bug.cgi?id=1249148 Piotr Popieluch piotr1...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||piotr1...@gmail.com Assignee|nob...@fedoraproject.org|piotr1...@gmail.com Flags||fedora-review? --- Comment #1 from Piotr Popieluch piotr1...@gmail.com --- to get the tests working: Add test BR BuildRequires: npm(inherits) BuildRequires: npm(capture-stack-trace) There is a missing devDependency in package.json, fixdep it so that this module gets symlinked with the nodejs_symlink_deps --check macro in prep add: %nodejs_fixdep inherits '2.x' change node test.js to mocha in %check section Tests should work now, will finish full review later today. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249148] Review Request: nodejs-create-error-class - Create Error classes
https://bugzilla.redhat.com/show_bug.cgi?id=1249148
Piotr Popieluch piotr1...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review-
--- Comment #2 from Piotr Popieluch piotr1...@gmail.com ---
One issue:
%{Summary} in %description should be %{summary} (not be capitalized).
I've missed this one in nodejs-capture-stack-trace bug 1249146 .
I will approve as soon as this and the previous comments are fixed. Would you
also please fix nodejs-capture-stack-trace?
[!]: Macros in Summary, %description expandable at SRPM build time.
Note: Macros in: nodejs-create-error-class (description)
nodejs-create-error-class.noarch: W: unexpanded-macro %description -l C
%{Summary}
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: Unknown or generated. 2 files have unknown license. Detailed
output of licensecheck in /home/piotr/rpmbuild/1249148-nodejs-create-
error-class/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Macros in Summary, %description expandable at SRPM build time.
Note: Macros in: nodejs-create-error-class (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]:
[Bug 1249148] Review Request: nodejs-create-error-class - Create Error classes
https://bugzilla.redhat.com/show_bug.cgi?id=1249148 --- Comment #3 from Parag Nemade pnem...@redhat.com --- Ah! That is why fedora-create-review failed to display summary in initial comment... I have fixed nodejs-capture-stack-trace on all built fedora branches. Sorry I was busy yesterday with fesco meeting preparation so could not update this package. But here is a fixed package now :) Spec URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-create-error-class.spec SRPM URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-create-error-class-2.0.1-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249148] Review Request: nodejs-create-error-class - Create Error classes
https://bugzilla.redhat.com/show_bug.cgi?id=1249148 Parag Nemade pnem...@redhat.com changed: What|Removed |Added Depends On||1249146 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1249146 [Bug 1249146] Review Request: nodejs-capture-stack-trace - Error.captureStackTrace ponyfill -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249148] Review Request: nodejs-create-error-class - Create Error classes
https://bugzilla.redhat.com/show_bug.cgi?id=1249148 Parag Nemade pnem...@redhat.com changed: What|Removed |Added Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
