[Bug 1249350] Review Request: python3-pytest-asyncio - Pytest support for asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1249350 Fedora Update System changed: What|Removed |Added Fixed In Version|python3-pytest-asyncio-0.1. |python3-pytest-asyncio-0.1. |3-2.git2a4c7e6.fc23 |3-2.git2a4c7e6.fc22 --- Comment #10 from Fedora Update System --- python3-pytest-asyncio-0.1.3-2.git2a4c7e6.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249350] Review Request: python3-pytest-asyncio - Pytest support for asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1249350 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python3-pytest-asyncio-0.1. ||3-2.git2a4c7e6.fc23 Resolution|--- |ERRATA Last Closed||2015-08-10 06:08:48 --- Comment #9 from Fedora Update System --- python3-pytest-asyncio-0.1.3-2.git2a4c7e6.fc23 has been pushed to the Fedora 23 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249350] Review Request: python3-pytest-asyncio - Pytest support for asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1249350 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- python3-pytest-asyncio-0.1.3-2.git2a4c7e6.fc23 has been pushed to the Fedora 23 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249350] Review Request: python3-pytest-asyncio - Pytest support for asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1249350 --- Comment #7 from Fedora Update System --- python3-pytest-asyncio-0.1.3-2.git2a4c7e6.fc23 has been submitted as an update for Fedora 23. https://admin.fedoraproject.org/updates/python3-pytest-asyncio-0.1.3-2.git2a4c7e6.fc23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249350] Review Request: python3-pytest-asyncio - Pytest support for asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1249350 --- Comment #6 from Fedora Update System --- python3-pytest-asyncio-0.1.3-2.git2a4c7e6.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python3-pytest-asyncio-0.1.3-2.git2a4c7e6.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249350] Review Request: python3-pytest-asyncio - Pytest support for asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1249350 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249350] Review Request: python3-pytest-asyncio - Pytest support for asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1249350 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249350] Review Request: python3-pytest-asyncio - Pytest support for asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1249350 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249350] Review Request: python3-pytest-asyncio - Pytest support for asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1249350 Julien Enselme changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Julien Enselme --- Thanks for the review New Package SCM Request === Package Name: python3-pytest-asyncio Short Description: Pytest support for asyncio Upstream URL: https://pypi.python.org/pypi/pytest-asyncio Owners: jujens Branches: f22 f23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249350] Review Request: python3-pytest-asyncio - Pytest support for asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1249350 Eduardo Mayorga changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Eduardo Mayorga --- Now it looks fine. PACKAGE APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249350] Review Request: python3-pytest-asyncio - Pytest support for asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1249350 --- Comment #2 from Julien Enselme --- - Add %%python_provide SPEC: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/python3-pytest-asyncio.spec SRPM: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/python3-pytest-asyncio-0.1.3-2.git2a4c7e6.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249350] Review Request: python3-pytest-asyncio - Pytest support for asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1249350
--- Comment #1 from Eduardo Mayorga ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- %python_provide is needed because when the default version of the system
runtime chages to Python 3, python3- packages must provide Provides:
python-example (note the unversioned name). Now it would not change anything,
but in the future it would do the correct thing. Adding
%{?python_provide:%python_provide python3-%{pypi_name}}
on the top will make it.
See: https://fedoraproject.org/wiki/Packaging:Python#Provides
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[!]: Package meets the Packaging Guidelines::Python
Note: %python_provide is missing.
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
Note: tests require Internet connection.
[-]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should t
[Bug 1249350] Review Request: python3-pytest-asyncio - Pytest support for asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1249350 Eduardo Mayorga changed: What|Removed |Added Status|NEW |ASSIGNED CC||e...@mayorgalinux.com Assignee|nob...@fedoraproject.org|e...@mayorgalinux.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
