[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1249543 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-08-27 06:16:03 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1249543 --- Comment #10 from Fedora Update System --- eclipse-paho-mqtt-java-1.0.2-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1249543 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- eclipse-paho-mqtt-java-1.0.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c05477e19f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1249543 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1249543 --- Comment #8 from Fedora Update System --- eclipse-paho-mqtt-java-1.0.2-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c05477e19f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1249543 --- Comment #7 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/eclipse-paho-mqtt-java -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1249543 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1249543 --- Comment #6 from gil cattaneo --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #5) > All good. Should add depenedency on eclipse-filesystem. Done > Package is APPROVED. Thanks for the review! create new SCM requests: https://admin.fedoraproject.org/pkgdb/package/requests/7351 https://admin.fedoraproject.org/pkgdb/package/requests/7352 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1249543
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #5 from Zbigniew Jędrzejewski-Szmek ---
(In reply to gil cattaneo from comment #4)
> Thanks for your help!
:)
> if for you is the same, i would have more interest, for now,
> to try to review the dependencies listed here:
> https://bugzilla.redhat.com/show_bug.cgi?id=1363923
Oh, man. I've had enough for today I think, but I'll try to find some time.
Don't know when though, I'll be travelling for the next few weeks.
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
EPL.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "EPL-1.0", "Unknown or generated". 12 files
have unknown license. Detailed output of licensecheck in
/var/tmp/1249543-eclipse-paho-mqtt-java/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/eclipse/droplets,
/usr/share/eclipse
→ add Requires: eclipse-filesystem
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
The name is a bit crazy, but it matches upstream ;)
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/clas
[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1249543 --- Comment #4 from gil cattaneo --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > Build in rawhide fails with > [ERROR] Plugin org.apache.maven.plugins:maven-antrun-plugin:1.7 or one of > its dependencies could not be resolved: Cannot access central > (https://repo.maven.apache.org/maven2) in offline mode and the artifact > org.apache.maven.plugins:maven-antrun-plugin:jar:1.7 has not been downloaded > from it before. -> [Help 1] > > maven-antrun-plugin is now at version 1.8, pom.xml needs to be patched. > It builds fine in F24 mock, it seems only F25+ is a problem. > > Looks good, but please fix the build ;) Spec URL: https://gil.fedorapeople.org/eclipse-paho-mqtt-java.spec SRPM URL: https://gil.fedorapeople.org/eclipse-paho-mqtt-java-1.0.2-1.fc24.src.rpm Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15329436 Thanks for your help! if for you is the same, i would have more interest, for now, to try to review the dependencies listed here: https://bugzilla.redhat.com/show_bug.cgi?id=1363923 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1249543 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|NEW |ASSIGNED CC||zbys...@in.waw.pl Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl Flags||fedora-review? --- Comment #3 from Zbigniew Jędrzejewski-Szmek --- Build in rawhide fails with [ERROR] Plugin org.apache.maven.plugins:maven-antrun-plugin:1.7 or one of its dependencies could not be resolved: Cannot access central (https://repo.maven.apache.org/maven2) in offline mode and the artifact org.apache.maven.plugins:maven-antrun-plugin:jar:1.7 has not been downloaded from it before. -> [Help 1] maven-antrun-plugin is now at version 1.8, pom.xml needs to be patched. It builds fine in F24 mock, it seems only F25+ is a problem. Looks good, but please fix the build ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1249543 gil cattaneo changed: What|Removed |Added Blocks||968136 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=968136 [Bug 968136] Review Request: camel - Apache Camel integration framework -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1249543 --- Comment #2 from Upstream Release Monitoring --- gil's scratch build of eclipse-paho-mqtt-java-1.0.2-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11975159 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1249543 --- Comment #1 from gil cattaneo --- Spec URL: https://gil.fedorapeople.org/eclipse-paho-mqtt-java.spec SRPM URL: https://gil.fedorapeople.org/eclipse-paho-mqtt-java-1.0.2-1.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1249543 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
