[Bug 1250833] Review Request: helm - Polyphonic software synth with lots of modulation and easy to use UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1250833

Raphael Groner  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2019-02-21 20:58:15



--- Comment #14 from Raphael Groner  ---


*** This bug has been marked as a duplicate of bug 1661657 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1250833] Review Request: helm - Polyphonic software synth with lots of modulation and easy to use UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1250833

L.L.Robinson  changed:

   What|Removed |Added

  Flags|needinfo?(junk@therobinsonf |
   |amily.net)  |



--- Comment #13 from L.L.Robinson  ---
The developer has stopped tagging builds and is now bundling more libraries
like libpng. 

https://github.com/mtytel/helm/commit/468f26b7dc7b26b0fcc122391502c105c6f1d61b

I think at the moment this project and my skills are to immature for me to
package at this present time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1250833] Review Request: helm - Polyphonic software synth with lots of modulation and easy to use UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1250833

Igor Gnatenko  changed:

   What|Removed |Added

 CC|ignate...@redhat.com|j...@therobinsonfamily.net
  Flags||needinfo?(junk@therobinsonf
   ||amily.net)



--- Comment #12 from Igor Gnatenko  ---
ping?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1250833] Review Request: helm - Polyphonic software synth with lots of modulation and easy to use UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1250833



--- Comment #11 from Michael Schwendt  ---
Good.

Some more advanced topics:


> License:  GPLv3

The source files say "or later", which would be "GPLv3+":

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.22or_later_version.22_licenses


> ExcludeArch:  armv7hl

https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Build_Failures


> Requires: lv2

# dnf list lv2|grep ^lv
lv2.i686   1.10.0-2.fc22 
fedora
lv2.x86_64 1.10.0-2.fc22 
fedora

As you're shipping files in %{_libdir}/lv2/helm.lv2/ you want to make this
explicit dependency arch-specific via %{?_isa}:
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires


> %{_datadir}/applications/helm.desktop

/builddir/build/SOURCES/helm.desktop: warning: key "Categories" is a list and
does not have a semicolon as trailing character, fixing

/builddir/build/BUILDROOT/helm-0.5.0-2.fc24.x86_64/usr/share/applications/helm.desktop:
warning: value "Software Synthesizer" for key "Comment" in group "Desktop
Entry" looks redundant with value "Software Synthesizer" of key "GenericName"


> %{_datadir}/applications/helm.desktop

https://fedoraproject.org/wiki/Packaging:Guidelines#AppData_files


> helm-0.5.0/JUCE/

That is a bundled library from juce.com and makes the package non-trivial. The
No_Bundled_Libraries policy has been changed recently, and the controversial
change is still being discussed:

https://fedoraproject.org/w/index.php?title=Packaging:No_Bundled_Libraries=406058


> helm-0.5.0/mopo/

Dunno whether the author has released this independently yet
(apart from https://github.com/mtytel/mopo ) or only together with Helm. Not an
issue yet.


> helm-0.5.0/fonts/

$ grep ttf build.log 
$

Also don't appear in the packages.


> /usr/share/helm/patches/LICENSE

That's not GPLv3, and this file in the helm-common package is not marked
%license either. This is some Creative Commons Attribution 4.0 license.

Note that each (sub-)package can have its own Group tag:
https://fedoraproject.org/wiki/Packaging:Guidelines#Licensing


> rpmlint

It finds some things when running it on all the built packages.


> Unknown

It GNOME Shell (Fedora 22), the application /usr/bin/helm creates a shell menu
entry with the name "Unknown".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1250833] Review Request: helm - Polyphonic software synth with lots of modulation and easy to use UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1250833



--- Comment #10 from L.L.Robinson  ---
An informational note that the next upstream version will not require patching
to make the build verbose.

https://github.com/mtytel/helm/issues/30#issuecomment-141542740

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1250833] Review Request: helm - Polyphonic software synth with lots of modulation and easy to use UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1250833



--- Comment #9 from L.L.Robinson  ---
SRPM URL: http://therobinsonfamily.net/SRPMS/helm-0.5.0-2.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1250833] Review Request: helm - Polyphonic software synth with lots of modulation and easy to use UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1250833



--- Comment #8 from L.L.Robinson  ---
Spec URL: http://therobinsonfamily.net/SPECS/helm.spec
SRPM URL: https://therobinsonfamily.net/SRPMS/helm-0.5.0-2.fc22.src.rpm

Build info: http://koji.fedoraproject.org/koji/taskinfo?taskID=11128243

Patched Makefiles to make buildoutput verbose.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1250833] Review Request: helm - Polyphonic software synth with lots of modulation and easy to use UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1250833



--- Comment #7 from L.L.Robinson  ---
new versions

Spec URL: http://therobinsonfamily.net/SPECS/helm.spec
SRPM URL: http://therobinsonfamily.net/SRPMS/helm-0.4.1-7.fc22.src.rpm

Build info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10898667

Everything done apart from the verbose build output. The linked output
regarding compiler flags and the optflags meant little to me as I'm not a
programmer. I tried adding it to %make_build but the build failed. I'm guessing
I may need to patch the Makefile to add the flags, or raise a bug upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1250833] Review Request: helm - Polyphonic software synth with lots of modulation and easy to use UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1250833



--- Comment #6 from Michael Schwendt (Fedora Packager Sponsors Group) 
bugs.mich...@gmx.net ---
Please fill in your full real name in your bugzilla account preferences.


Consider pointing the fedora-review tool at this ticket:

  fedora-review -b 1250833

It downloads the latest spec file and src.rpm from the Spec URL: and SRPM
URL: lines (or additional URLs it finds) and performs many checks that are
relevant during review and should be most interesting to the package
maintainer.


 - Requires: helm-common
you should specify version at least. Example:
Requires: helm-common = %{version}

Omitting -%{release} serves no purpose. Actually, -common subpackages are
disguised base packages, and this one applies except the %{?_isa}:

  https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


 %doc

%doc is not a section but an attribute. Empty %doc lines are no-op. It's more
cleaner to delete them.


 %package lv2
 Summary:  Helm lv2 plugin
 Group:Applications/Multimedia
 Requires: %{name}-common = %{version}
 %description lv2
 Helm is a polyphonic software synth with lots of modulation and and easy to 
 use UT

The %description ought to explain what this particular package does. What's the
relevance of LV2, for example? Why is the %description longer than the
%description of the base package?

 %description
 Helm is a software synth designed to be easy to use

The subpackage is missing an explicit dependency on lv2. Note that since LV2
is a library-less API, there is no automatic dependency on it, but package
lv2 is the one that provides the ownership of %_libdir/lv2.


 %files lv2
 %{_libdir}/lv2/helm.lv2/

 %package lv2

That creates a subpackage helm-lv2. Instead, I think the general add-on package
naming guidelines apply:

 
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28General.29

It is a plugin to LV2. It extends LV2.

%package -n lv2-helm


 https://kojipkgs.fedoraproject.org//work/tasks/4821/10784821/build.log

Build output is non-verbose. One cannot see which compiler and linker flags
have been used actually.

https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1250833] Review Request: helm - Polyphonic software synth with lots of modulation and easy to use UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1250833



--- Comment #5 from j...@therobinsonfamily.net ---
New version
http://therobinsonfamily.net/SRPMS/helm-0.4.1-6.fc22.src.rpm
http://therobinsonfamily.net/SPECS/helm.spec

Updated due to failed armv7hl builds

Koji build
http://koji.fedoraproject.org/koji/taskinfo?taskID=10784820

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1250833] Review Request: helm - Polyphonic software synth with lots of modulation and easy to use UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1250833



--- Comment #4 from j...@therobinsonfamily.net ---
Excellent review, really helpful. I'm pretty sure I did everything. Regarding
the icon, it was in pixmaps but now it's in icons/hicolor/

New version
http://therobinsonfamily.net/SRPMS/helm-0.4.1-4.fc22.src.rpm

http://therobinsonfamily.net/SPECS/helm.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1250833] Review Request: helm - Polyphonic software synth with lots of modulation and easy to use UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1250833

Igor Gnatenko i.gnatenko.br...@gmail.com changed:

   What|Removed |Added

Summary|Review Request:Helm -   |Review Request: helm -
   |Software synth and lv2  |Polyphonic software synth
   |plugins |with lots of modulation and
   ||easy to use UI



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review