[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|2.2.1-1.fc22|2.2.1-1.fc23



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238



--- Comment #17 from Fedora Update System  ---
yubioath-desktop-2.2.1-1.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||2.2.1-1.fc22
 Resolution|--- |NEXTRELEASE
Last Closed||2015-09-11 13:22:40



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238



--- Comment #16 from Fedora Update System  ---
yubioath-desktop-2.2.1-1.fc22 has been pushed to the Fedora 22 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238



--- Comment #15 from Fedora Update System  ---
yubioath-desktop-2.2.1-1.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.\nIf you want to test the update, you can install it with \n su -c 'yum
--enablerepo=updates-testing update yubioath-desktop'. You can provide feedback
for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14791

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238



--- Comment #14 from Fedora Update System  ---
yubioath-desktop-2.2.1-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.\nIf you want to test the update, you can install it with \n su -c 'yum
--enablerepo=updates-testing update yubioath-desktop'. You can provide feedback
for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14790

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238



--- Comment #13 from Fedora Update System upda...@fedoraproject.org ---
yubioath-desktop-2.1.1-3.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.\nIf you want to test the update, you can install it with \n su -c 'yum
--enablerepo=updates-testing update yubioath-desktop'. You can provide feedback
for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-13847

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #12 from Fedora Update System upda...@fedoraproject.org ---
yubioath-desktop-2.1.1-3.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.\nIf you want to test the update, you can install it with \n su -c 'yum
--enablerepo=updates-testing update yubioath-desktop'. You can provide feedback
for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-13846

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238



--- Comment #9 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238



--- Comment #11 from Fedora Update System upda...@fedoraproject.org ---
yubioath-desktop-2.1.1-3.fc23 has been submitted as an update to Fedora 23.
https://bugzilla.redhat.com/show_bug.cgi?id=1251238

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238



--- Comment #10 from Fedora Update System upda...@fedoraproject.org ---
yubioath-desktop-2.1.1-3.fc22 has been submitted as an update to Fedora 22.
https://bugzilla.redhat.com/show_bug.cgi?id=1251238

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238

Seth Jennings spartacu...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #8 from Seth Jennings spartacu...@gmail.com ---
New Package SCM Request
===
Package Name: yubioath-desktop
Short Description:  Yubikey tool for generating OATH event-based HOTP and
time-based TOTP codes
Upstream URL: https://developers.yubico.com/yubioath-desktop/
Owners: spartacus06
Branches: f22 f23
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238



--- Comment #7 from Adam Miller admil...@redhat.com ---
You are correct, my mistake. I just became a sponsor last week :)

Sorry about that, you are now a packager and are sponsored. Feel free to file a
SCM request for DistGit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238

Adam Miller admil...@redhat.com changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #5 from Adam Miller admil...@redhat.com ---
Apply for packager in FAS, I will sponsor you.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238

Seth Jennings sjenn...@redhat.com changed:

   What|Removed |Added

 CC||sjenn...@redhat.com



--- Comment #6 from Seth Jennings sjenn...@redhat.com ---
Adam,

I think you might have to add me.

packager Rules for Application are: Please do not apply to this group. Your
sponsor will add you after you've completed
http://fedoraproject.org/wiki/Join_the_package_collection_maintainers.

There is no apply option for that group.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238

Adam Miller admil...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #2 from Adam Miller admil...@redhat.com ---
The %{__python} should be %{__python2} as per python packaging guidelines:
https://fedoraproject.org/wiki/Packaging:Python

Otherwise things look good.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: BSD (2 clause), GPL (v3 or later). Detailed output of
 licensecheck in /home/admiller/reviews/1251238-yubioath-
 desktop/licensecheck.txt
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/icons/hicolor,
 /usr/share/icons/hicolor/128x128/apps,
 /usr/share/icons/hicolor/128x128
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in yubioath-desktop
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license 

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238



--- Comment #3 from Seth Jennings spartacu...@gmail.com ---
Adam, thanks for the review! New spec and SRPM using the __python2 macro.

Spec URL: https://www.variantweb.net/pub/fedora/specs/yubioath-desktop.spec
SRPM URL:
https://www.variantweb.net/pub/fedora/22/source/SRPMS/yubioath-desktop-2.1.1-3.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238

Adam Miller admil...@redhat.com changed:

   What|Removed |Added

 CC||admil...@redhat.com
   Assignee|nob...@fedoraproject.org|admil...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238



--- Comment #4 from Adam Miller admil...@redhat.com ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: BSD (2 clause), GPL (v3 or later). Detailed output of
 licensecheck in /home/admiller/reviews/1251238-yubioath-
 desktop/licensecheck.txt
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/icons/hicolor,
 /usr/share/icons/hicolor/128x128/apps,
 /usr/share/icons/hicolor/128x128
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in yubioath-desktop
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238

Adam Miller admil...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238

Seth Jennings spartacu...@gmail.com changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251238



--- Comment #1 from Seth Jennings spartacu...@gmail.com ---
Created attachment 1060060
  -- https://bugzilla.redhat.com/attachment.cgi?id=1060060action=edit
self-reporting fedora-review

This is my first package submission so, afaict, I need a sponsor.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=10625020

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review