[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 --- Comment #20 from Fedora Update System--- python-gabbi-1.19.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 Fedora Update Systemchanged: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-05-16 12:25:45 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 Fedora Update Systemchanged: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #19 from Fedora Update System --- python-gabbi-1.19.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6323cc7eb1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 Fedora Update Systemchanged: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 --- Comment #18 from Fedora Update System--- python-gabbi-1.19.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6323cc7eb1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 Javier Peñachanged: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review+ --- Comment #17 from Javier Peña --- Everything looks ok now, thanks! fedora-review is complaining that the package source cannot be downloaded from the location specified in Source0, not sure if that is an issue in pyp2rpm or something else. The package is APPROVED, please go ahead and submit the SCM request. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 15 files have unknown license. Detailed output of licensecheck in /tmp/1252812-python-gabbi/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.5/site-packages, /usr/lib/python3.5 [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.5/site- packages, /usr/lib/python3.5 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep = SHOULD items = Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://pypi.python.org/packages/source/g/gabbi/gabbi-1.19.0.tar.gz See:
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 Javier Peñachanged: What|Removed |Added Assignee|rybr...@redhat.com |jp...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 --- Comment #16 from Chandan Kumar--- Hello, Here is the updated SPEC: https://chandankumar.fedorapeople.org/python-gabbi.spec SRPM : https://chandankumar.fedorapeople.org/python-gabbi-1.19.0-1.fc23.src.rpm and koji build : http://koji.fedoraproject.org/koji/taskinfo?taskID=13982971 Thanks, Chandan Kumar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 --- Comment #15 from Alfredo Moralejo--- The spec looks good to me now. Best regards, Alfredo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 --- Comment #14 from Chandan Kumar--- Hello Alfredo, Thanks for the review. Here is the updated SPEC: https://chandankumar.fedorapeople.org/python-gabbi.spec SRPM: https://chandankumar.fedorapeople.org/python-gabbi-1.17.5-1.fc23.src.rpm and koji build scratch : http://koji.fedoraproject.org/koji/taskinfo?taskID=13949960 Thanks, Chandan Kumar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 --- Comment #13 from Alfredo Moralejo--- Hi Chandan, Some comments: - About manpage, great!! - About tests in %checks, i've seen some tests are failing because of (https://github.com/cdent/gabbi/issues/133), so i think it's ok to leave the || About dependencies, I think it should have a Requires on python3-urllib3. Best regards, Alfredo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 --- Comment #12 from Chandan Kumar--- Hello Alfredo, Thanks for reviewing it. * manpage added * %checks are included Here is the updated SPEC: https://chandankumar.fedorapeople.org/python-gabbi.spec SRPM: https://chandankumar.fedorapeople.org/python-gabbi-1.17.5-3.fc23.src.rpm and Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13944220 Thanks, Chandan Kumar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 Alfredo Moralejochanged: What|Removed |Added CC||amora...@redhat.com --- Comment #11 from Alfredo Moralejo --- Hi Chandan, Another couple of comments: - This package provides an executable file so it should provide a man page for it. Upstream package provides a man page for "gabbi" which includes help for running gabbi-run so i think it'd be nice to include it. - Would it be possible to add tests execution in %check? Best regards, Alfredo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 --- Comment #10 from Chandan Kumar--- Hello Jpena, Thanks for reviewing it. Here is the updated SPEC: https://chandankumar.fedorapeople.org/python-gabbi.spec SRPM : https://chandankumar.fedorapeople.org/python-gabbi-1.17.5-2.fc23.src.rpm and koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13934602 Thanks, Chandan Kumar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 Javier Peñachanged: What|Removed |Added CC||jp...@redhat.com --- Comment #9 from Javier Peña --- Hi Chandan, The spec has an issue with the "%{_bindir}/gabbi-run" executable, which is included in both the python2 and python3 subpackages, creating issues (besides the conflict, the python2 subpkg requires python3 when built). You may want to apply a similar fix to the one in http://pkgs.fedoraproject.org/cgit/rpms/python-reno.git/tree/python-reno.spec . Also, any reason to exclude gabbits_intercept? I don't see anything in the spec file. Other than that, the spec looks good to me. Javier -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 Chandan Kumarchanged: What|Removed |Added Flags|needinfo?(rybr...@redhat.co | |m) | --- Comment #8 from Chandan Kumar --- Hello, Here is the updated SPEC: https://chandankumar.fedorapeople.org/python-gabbi.spec SRPM: https://chandankumar.fedorapeople.org/python-gabbi-1.17.5-1.fc23.src.rpm and koji Build : http://koji.fedoraproject.org/koji/taskinfo?taskID=13932412 Thanks, Chandan Kumar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 Chandan Kumarchanged: What|Removed |Added Flags||needinfo?(rybr...@redhat.co ||m) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 Chandan Kumarchanged: What|Removed |Added CC||chkumar...@gmail.com Flags||needinfo?(rybr...@redhat.co ||m) --- Comment #5 from Chandan Kumar --- Hello Ryan, Sorry for the late reply. Here is the updated SPEC: https://chandankumar.fedorapeople.org/python-gabbi.spec SRPM: https://chandankumar.fedorapeople.org/python-gabbi-1.7.0-1.fc22.src.rpm Thanks, Chandan Kumar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 Ryan Brownchanged: What|Removed |Added Flags|needinfo?(rybr...@redhat.co | |m) | --- Comment #6 from Ryan Brown --- Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 4 files have unknown license. Detailed output of licensecheck in /tmp/review/python-gabbi/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [-]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. There are no "Requires:" for any of the packages, which is likely a mistake as I know gabbi needs jsonpath. wsgi_intercept, etc to run. Please add runtime deps. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). See above [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-gabbi , python3-gabbi , python-gabbi-doc [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 Ryan Brownchanged: What|Removed |Added Assignee|nob...@fedoraproject.org|rybr...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 --- Comment #4 from Ryan Brown--- Hi, here's an updated spec/srpm: http://rsb.io/pkg/python-gabbi.spec http://rsb.io/pkg/python-gabbi-1.6.1-1.fc22.src.rpm I don't think the PBR mechanism needs disabling, but I'm not certain. I know you can add a patch that disables PBR entirely as a runtime dep, but I don't think it's required. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 --- Comment #3 from bigswitch--- 1. URL should point to package pypi page 2. Do you need to disable pbr version determination mechanism on build? For example, https://github.com/openstack-packages/neutron/blob/4bc2d731766a50fb0d6733bbd8e0a2bde1f4a187/openstack-neutron.spec#L443 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 bigswitch rhosp-bugs-inter...@bigswitch.com changed: What|Removed |Added CC||rhosp-bugs-internal@bigswit ||ch.com --- Comment #2 from bigswitch rhosp-bugs-inter...@bigswitch.com --- Hi Chandan, Latest version on pypi is 1.5.1. The spec file should be pointing to that version, right? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 Matthias Runge mru...@redhat.com changed: What|Removed |Added CC||mru...@redhat.com --- Comment #1 from Matthias Runge mru...@redhat.com --- Thank you for your review request. Please add a python3 package. Upstream also includes tests, please execute them as well during build. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library
https://bugzilla.redhat.com/show_bug.cgi?id=1252812 Chandan Kumar chku...@redhat.com changed: What|Removed |Added Blocks||1243533 ||(RDO-LIBERTY-REVIEWS) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1243533 [Bug 1243533] (RDO) Tracker: Review requests for new RDO Liberty packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review