[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973

Antonio Trande  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2018-12-20 19:50:25



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #36 from Fedora Update System  ---
libndn-cxx-0.3.4-4.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #35 from Fedora Update System  ---
libndn-cxx-0.3.4-4.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update libndn-cxx'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-b46ee094bb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #34 from Fedora Update System  ---
libndn-cxx-0.3.4-4.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-b46ee094bb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #33 from Jon Ciesla  ---
This SCM request method has been deprecated. Please see
https://fedoraproject.org/wiki/PackageDB_admin_requests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #30 from Susmit  ---
Upstream is working on it. Is this a blocker?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973

Susmit  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #32 from Susmit  ---
Thanks.


New Package SCM Request
===
Package Name: libndn-cxx
Short Description: C++ library, implementing Named Data Networking (NDN)
primitives
Upstream URL: https://github.com/named-data/ndn-cxx
Owners: susmit
Branches: f22 f23 el6 epel7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973

Antonio Trande  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #31 from Antonio Trande  ---
Package approved.

Please, leave a comment to http://redmine.named-data.net/issues/3270.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later) LGPL (v3 or later)", "LGPL (v3 or later)",
 "BSD (3 clause) LGPL (v3 or later)", "GPL (v3 or later)", "Unknown or
 generated". 45 files have unknown license. Detailed output of
 licensecheck in /home/sagitter/rpmbuild/SRPMS/libndn-
 cxx/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: 

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #29 from Susmit  ---
I have seen it once, but as you said, I couldn't reproduce it.
I'll let upstream know.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #25 from Upstream Release Monitoring 
 ---
susmit's scratch build of libndn-cxx-0.3.4-4.fc22.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11476016

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #26 from Susmit  ---
Thanks for the help.

http://www.cs.colostate.edu/~susmit/ndn/libndn-cxx-0.3.4-4.fc22.src.rpm
http://www.cs.colostate.edu/~susmit/ndn/libndn-cxx.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #27 from Susmit  ---
Reposting this for package-review tool.

SRPM: http://www.cs.colostate.edu/~susmit/ndn/libndn-cxx-0.3.4-4.fc22.src.rpm
SPEC: http://www.cs.colostate.edu/~susmit/ndn/libndn-cxx.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #28 from Antonio Trande  ---
Have you never seen an error like this

+ build/unit-tests
Running 607 test cases...
../tests/unit-tests/util/dns.t.cpp(79): fatal error: in
"UtilDns/AsynchronousV6": Resolution should not have failed
*** 1 failure is detected in the test module "ndn-cxx Unit Tests"

?

It's not always reproducible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #24 from Antonio Trande  ---
(In reply to Susmit from comment #23)
> I have fixed the directory error but not sure how to fix the 
> 'unused-direct-shlib-dependency' warnings with waf. Any suggestions?

%build
CXXFLAGS="%{optflags} -std=c++11" \
LINKFLAGS="-Wl,--as-needed" \
%{__python2} ./waf --enable-shared --disable-static --with-tests \
 --prefix=%{_prefix} --bindir=%{_bindir} --libdir=%{_libdir} \
 --datadir=%{_datadir} --sysconfdir=%{_sysconfdir} configure

%{__python2} ./waf -v %{?_smp_mflags}


Please, use python2-devel as BuildRequires.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #23 from Susmit  ---
I have fixed the directory error but not sure how to fix the 
'unused-direct-shlib-dependency' warnings with waf. Any suggestions?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #22 from Antonio Trande  ---
- Again, the directory '%{_sysconfdir}/ndn' is not owned; add

%dir %{_sysconfdir}/ndn

- 'unused-direct-shlib-dependency' warnings:
see
https://fedoraproject.org/wiki/Common_Rpmlint_issues?rd=PackageMaintainers/Common_Rpmlint_Issues#unused-direct-shlib-dependency


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later) LGPL (v3 or later)", "LGPL (v3 or later)",
 "BSD (3 clause) LGPL (v3 or later)", "GPL (v3 or later)", "Unknown or
 generated". 45 files have unknown license. Detailed output of
 licensecheck in /home/sagitter/1255973-libndn-cxx/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /etc/ndn
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/ndn
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #20 from Upstream Release Monitoring 
 ---
susmit's scratch build of libndn-cxx-0.3.4-3.fc22.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11296174

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #21 from Susmit  ---

New spec and SRPM:

http://www.cs.colostate.edu/~susmit/ndn/libndn-cxx.spec

http://www.cs.colostate.edu/~susmit/ndn/libndn-cxx-0.3.4-3.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #18 from Antonio Trande  ---
(In reply to Upstream Release Monitoring from comment #17)
> susmit's scratch build of libndn-cxx-0.3.4-2.fc22.src.rpm for rawhide
> completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11231215

Please, post the new spec and SRPM if everything is fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #19 from Susmit  ---
Thank, but I am still figuring this out with upstream,

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #16 from Upstream Release Monitoring 
 ---
susmit's scratch build of libndn-cxx-0.3.4-1.fc22.src.rpm for rawhide failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11228668

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #15 from Antonio Trande  ---
1 test fails on rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #17 from Upstream Release Monitoring 
 ---
susmit's scratch build of libndn-cxx-0.3.4-2.fc22.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11231215

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #14 from Upstream Release Monitoring 
 ---
susmit's scratch build of libndn-cxx-0.3.4-1.fc22.src.rpm for f22 completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11214318

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #13 from Susmit  ---
Thanks.

Updated spec and SRPM: 
http://www.cs.colostate.edu/~susmit/ndn/libndn-cxx.spec
http://www.cs.colostate.edu/~susmit/ndn/libndn-cxx-0.3.4-1.fc22.src.rpm

Scratch build
http://koji.fedoraproject.org/koji/taskinfo?taskID=11214536

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #10 from Susmit  ---
New versions:

www.cs.colostate.edu/~susmit/ndn/libndn-cxx.spec
http://www.cs.colostate.edu/~susmit/ndn/libndn-cxx-0.3.4-1.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #12 from Antonio Trande  ---
- There is a multiple licensing scenario:

BSD (3 clause) LGPL (v3 or later)
-
ndn-cxx-ndn-cxx-0.3.4/src/util/network-monitor.cpp

GPL (v3 or later)
-
ndn-cxx-ndn-cxx-0.3.4/src/mgmt/control-parameters.hpp
ndn-cxx-ndn-cxx-0.3.4/src/mgmt/control-response.cpp
ndn-cxx-ndn-cxx-0.3.4/src/mgmt/control-response.hpp
ndn-cxx-ndn-cxx-0.3.4/src/mgmt/dispatcher.cpp
ndn-cxx-ndn-cxx-0.3.4/src/mgmt/dispatcher.hpp
ndn-cxx-ndn-cxx-0.3.4/src/mgmt/status-dataset-context.cpp
ndn-cxx-ndn-cxx-0.3.4/tests/unit-tests/mgmt/dispatcher.t.cpp
ndn-cxx-ndn-cxx-0.3.4/tests/unit-tests/mgmt/status-dataset-context.t.cpp

GPL (v3 or later) LGPL (v3 or later)

ndn-cxx-ndn-cxx-0.3.4/src/management/nfd-face-monitor.hpp
ndn-cxx-ndn-cxx-0.3.4/src/util/notification-stream.hpp
ndn-cxx-ndn-cxx-0.3.4/src/util/notification-subscriber.hpp
ndn-cxx-ndn-cxx-0.3.4/tests/unit-tests/util/notification-stream.t.cpp

These files are involved in the building, some are provided by the -devel
sub-package; License must be modified and commented:

License: LGPLv3+ and (BSD or LGPLv3+) and (GPLv3+ or LGPLv3+)

See
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios

- The directory %{_sysconfdir}/ndn-cxx is not owned.

- Patch0 is not commented.

- Fix the warnings 'unused-direct-shlib-dependency'
See
https://fedoraproject.org/wiki/Common_Rpmlint_issues?rd=PackageMaintainers/Common_Rpmlint_Issues#unused-direct-shlib-dependency

- All current versions of Fedora (and their respective RPM versions) treat the
Group tag as optional. 
Packages may include a Group: field for compatibility with EPEL, but are not
required to do so.

However all valid groups are http://fedoraproject.org/wiki/RPMGroups

- Pleas, fix the warning 
  'mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 1)'




Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later) LGPL (v3 or later)", "LGPL (v3 or later)",
 "BSD (3 clause) LGPL (v3 or later)", "GPL (v3 or later)", "Unknown or
 generated". 45 files have unknown license. Detailed output of
 licensecheck in /home/sagitter/1255973-libndn-cxx/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /etc/ndn-cxx, /etc/ndn-cxx/ndn
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/ndn-cxx, /etc/ndn-cxx/ndn
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the 

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #11 from Susmit  ---
Stratch builds for rawhide and f22.

https://koji.fedoraproject.org/koji/taskinfo?taskID=0808
https://koji.fedoraproject.org/koji/taskinfo?taskID=0828

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #8 from Susmit  ---
Addressing the comments.

http://www.cs.colostate.edu/~susmit/ndn/ndn-cxx-0.3.3-1.fc22.src.rpm
http://www.cs.colostate.edu/~susmit/ndn/libndn-cxx.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #9 from Antonio Trande  ---
There is a double "waf configure" command.

* Tue Sep 08 2015 Susmit Shannigrahi  - 0.3.3-1
- Use waf to install files
- Fix review comments

* Fri Aug 21 2015 Susmit Shannigrahi  - 0.3.3-0
- Update package for 0.3.3

* Thu Feb 5 2015 Susmit Shannigrahi  - 0.3.0-0
- Initial Packaging

The Release number starts with 1, not with 0.

Make a scratch build with koji to test your package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #7 from Antonio Trande anto.tra...@gmail.com ---
Created attachment 1065962
  -- https://bugzilla.redhat.com/attachment.cgi?id=1065962action=edit
ndn-cxx.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #6 from Antonio Trande anto.tra...@gmail.com ---
First of all, there is incongruity between package name of the review title and
the name of your package (libndn-cxx VS ndn-cxx); i think, you should name this
package as libndn-cxx.

The configuration of build is incomplete and 'waf's potentialities are not
totally used; if you run

waf --help 

inside unpacked source archive, you can read all the options provided to build
this library correctly.
Of course, some packaging fixes are also needed as Gil reported in the
comment#4 without forget to package all development files too and run all
available tests.

See my SPEC file attached.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #1 from Susmit thinklinux@gmail.com ---
Sorry, 
SRPM is here: 
http://www.cs.colostate.edu/~susmit/ndn/ndn-cxx-0.3.3-1.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973

gil cattaneo punto...@libero.it changed:

   What|Removed |Added

 CC||punto...@libero.it
   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



--- Comment #2 from gil cattaneo punto...@libero.it ---
hi
can you take for me this?
springframework-data-redis -
https://bugzilla.redhat.com/show_bug.cgi?id=1228203
thanks in advance

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #3 from Susmit thinklinux@gmail.com ---
Sorry Gil, I have already taken another up. I will commit another package soon,
may be we can swap that?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #4 from gil cattaneo punto...@libero.it ---
Before using fedora-review must be removed:
%clean 
rm -rf %{buildroot}

Please, remove
cp %_builddir/%{name}-%{name}-%{version}/*.md %{buildroot}%{_docdir}/
cp %_builddir/%{name}-%{name}-%{version}/RELEASE_NOTES.rst
%{buildroot}%{_docdir}/
handled with directly with %doc macro

Use %license macro:
e.g.

%doc AUTHORS.md README-dev.md README.md
%license COPYING.md

and add:

%postun -p /sbin/ldconfig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #5 from gil cattaneo punto...@libero.it ---
(In reply to Susmit from comment #3)
 Sorry Gil, I have already taken another up. I will commit another package
 soon, may be we can swap that?

sure, then remove from this bug, my offer to review. let me know when it's
ready
regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973

gil cattaneo punto...@libero.it changed:

   What|Removed |Added

 CC|punto...@libero.it  |
   Assignee|punto...@libero.it  |nob...@fedoraproject.org
  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973

Antonio Trande anto.tra...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||anto.tra...@gmail.com
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review