[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 --- Comment #23 from Fedora Update System --- python-alembic-0.8.3-3.el7, python-editor-0.4-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 --- Comment #22 from Fedora Update System --- python-alembic-0.8.3-3.fc22, python-editor-0.4-4.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2015-08-26 13:06:12 |2015-12-04 14:20:26 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 --- Comment #21 from Fedora Update System --- python-alembic-0.8.3-3.fc23, python-editor-0.4-4.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 --- Comment #20 from Fedora Update System --- python-alembic-0.8.3-3.fc23, python-editor-0.4-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-alembic python-editor' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16ffa3adda -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 --- Comment #19 from Fedora Update System --- python-alembic-0.8.3-3.fc22, python-editor-0.4-4.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-alembic python-editor' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-e662b9cd9a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|NEXTRELEASE |--- Keywords||Reopened --- Comment #18 from Fedora Update System --- python-alembic-0.8.3-3.el7, python-editor-0.4-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update python-alembic python-editor' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-9b2a9f807c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 --- Comment #17 from Fedora Update System --- python-editor-0.4-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-9b2a9f807c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 --- Comment #16 from Fedora Update System --- python-editor-0.4-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16ffa3adda -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 --- Comment #15 from Fedora Update System --- python-editor-0.4-4.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-e662b9cd9a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 Tim Flink changed: What|Removed |Added CC||tfl...@redhat.com --- Comment #14 from Tim Flink --- Are there going to be koji builds and bodhi updates for this new package? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 Ralph Bean changed: What|Removed |Added CC||rb...@redhat.com --- Comment #13 from Ralph Bean --- Are there going to be bodhi updates for this new package? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 Lukas Bezdicka changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2015-08-26 13:06:12 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 --- Comment #12 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 Ralph Bean changed: What|Removed |Added Blocks||1245848 Depends On|1245848 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1245848 [Bug 1245848] python-alembic-0.8.2 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 Ralph Bean changed: What|Removed |Added Blocks|1245848 | Depends On||1245848 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1245848 [Bug 1245848] python-alembic-0.8.2 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 --- Comment #11 from Lukas Bezdicka --- New Package SCM Request === Package Name: python-editor Short Description: Programmatically open an editor, capture the result. Upstream URL: https://github.com/fmoo/python-editor Owners: social apevec Branches: f22 f23 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 Lukas Bezdicka changed: What|Removed |Added CC||soc...@v3.sk Flags||fedora-cvs? --- Comment #10 from Lukas Bezdicka --- New Package SCM Request === Package Name: python-editor Short Description: Programmatically open an editor, capture the result. Upstream URL: https://github.com/fmoo/python-editor Owners: social apevec social Branches: f22 f23 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 Chandan Kumar changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353
--- Comment #9 from Chandan Kumar ---
Looks good now.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 2 files have unknown license. Detailed
output of licensecheck in /home/chandankumar/review-python-
editor/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[ ]: Python eggs must not download any dependencies during the build
process.
[ ]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-editor
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 Chandan Kumar changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 --- Comment #8 from Lukas Bezdicka --- SRCRPM URL: https://social.fedorapeople.org/python-editor-0.4-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 --- Comment #7 from Lukas Bezdicka --- New scratch build with fixed rpmlint issues: ScratchBuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=10837750 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 --- Comment #6 from Lukas Bezdicka --- Updated to 0.4 and created koji build. ScratchBuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=10836458 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 --- Comment #5 from Chandan Kumar --- [1.] In the spec file, use Source: https://pypi.python.org/packages/source/p/python-editor/python-editor-0.3.tar.gz [2.] Since License file is missing in pypi tarball, please add the following issue link https://github.com/fmoo/python-editor/issues/3 in spec file and then modify the spec. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353
--- Comment #4 from Chandan Kumar ---
Hello Social,
Thanks for submitting the package for review.
Below is my inline comments:
[1.] under %prep section, Remove bundled egg-info by adding
rm -rf %{pypi_name}.egg-info
[2.] since there is no test folder, you can remove %check macro
[3.] under %files,
Please replace %{python2_sitelib}/* with
%{python2_sitelib}/editor.py*
%{python2_sitelib}/python_editor-%{version}-py?.?.egg-info
Note: editor.py may contains some byte compiled files which needs to be
required under exceution.
[4.] under %files -n python3-editor section
include
%doc README
replace %{python3_sitelib}/editor.py with %{python3_sitelib}/editor.py*
[5.] Please add the changelog for the spec file.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 --- Comment #3 from Lukas Bezdicka --- (In reply to Javier Peña from comment #2) > Would it be possible to add the README.md file to the python3 package? I > guess it should be there, too. > > I'm still not sure I understand the new guidelines about %python_provide > usage, so I'll leave that for someone more experienced. I added README.md to python3 package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 Javier Peña changed: What|Removed |Added CC||jp...@redhat.com --- Comment #2 from Javier Peña --- Would it be possible to add the README.md file to the python3 package? I guess it should be there, too. I'm still not sure I understand the new guidelines about %python_provide usage, so I'll leave that for someone more experienced. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 Haïkel Guémar changed: What|Removed |Added Blocks||1245848 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1245848 [Bug 1245848] python-alembic-0.8.1 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 Haïkel Guémar changed: What|Removed |Added CC||karlthe...@gmail.com Blocks||1243533 ||(RDO-LIBERTY-REVIEWS) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1243533 [Bug 1243533] (RDO) Tracker: Review requests for new RDO Liberty packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 Chandan Kumar changed: What|Removed |Added CC||chkumar...@gmail.com Assignee|nob...@fedoraproject.org|chkumar...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.
https://bugzilla.redhat.com/show_bug.cgi?id=1256353 --- Comment #1 from Lukas Bezdicka --- Spec URL: https://raw.githubusercontent.com/xbezdick/python-editor/master/python-editor.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
