[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042



--- Comment #14 from Fedora Update System  ---
python-django-babel-0.4.0-2.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|0.4.0-2.el7 |0.4.0-2.fc23



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||0.4.0-2.fc22
 Resolution|--- |NEXTRELEASE
Last Closed||2015-09-16 17:20:07



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042



--- Comment #12 from Fedora Update System  ---
python-django-babel-0.4.0-2.fc22 has been pushed to the Fedora 22 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|0.4.0-2.fc22|0.4.0-2.el7



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042



--- Comment #13 from Fedora Update System  ---
python-django-babel-0.4.0-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042



--- Comment #11 from Fedora Update System  ---
python-django-babel-0.4.0-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.\nIf you want to test the update, you can install it with \n su -c 'yum
--enablerepo=updates-testing update python-django-babel'. You can provide
feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8075

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042



--- Comment #8 from Fedora Update System  ---
python-django-babel-0.4.0-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-15838

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042



--- Comment #6 from Fedora Update System  ---
python-django-babel-0.4.0-2.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8075

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042



--- Comment #7 from Fedora Update System  ---
python-django-babel-0.4.0-2.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-15837

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042



--- Comment #10 from Fedora Update System  ---
python-django-babel-0.4.0-2.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.\nIf you want to test the update, you can install it with \n su -c 'yum
--enablerepo=updates-testing update python-django-babel'. You can provide
feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-15837

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
python-django-babel-0.4.0-2.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.\nIf you want to test the update, you can install it with \n su -c 'yum
--enablerepo=updates-testing update python-django-babel'. You can provide
feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-15838

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042



--- Comment #5 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042

Chandan Kumar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Chandan Kumar  ---
Hello Mrunge,

Thanks for submitting for package review.

It now looks good to me, Approved :)

Please file new package SCM request.

Thanks,

Chandan Kumar




Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 9 files have unknown license. Detailed
 output of licensecheck in /home/chandankumar/review-python-django-
 babel/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
 names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 256000 bytes in 28 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[ ]: Python eggs must not download any dependencies during the build
 process.
[ ]: A package which is used by another package via an egg interface should
 provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[ ]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
 -django-babel , python3-django-babel
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
 

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042

Matthias Runge  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #4 from Matthias Runge  ---
Thank you for the review!

New Package SCM Request
===
Package Name: python-django-babel
Short Description: Utilities for using Babel in Django 
Upstream URL: http://github.com/graingert/django-babel/
Owners: mrunge
Branches: f22 f23 epel7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042



--- Comment #2 from Matthias Runge  ---
thank you for your comments

updated
SPEC: http://www.matthias-runge.de/fedora/python-django-babel.spec
SRPM:
http://www.matthias-runge.de/fedora/python-django-babel-0.4.0-2.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042

hgue...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||hgue...@redhat.com



--- Comment #1 from hgue...@redhat.com ---
Few remarks:
* I'd consider using newer guidelines as it's a totally new package. (I wont
consider this as a blocker)
* doc generation should be moved to %build

Packages install and work fine, should be a quick review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1243533
   ||(RDO-LIBERTY-REVIEWS)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1243533
[Bug 1243533] (RDO) Tracker: Review requests for new RDO Liberty packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042

Chandan Kumar  changed:

   What|Removed |Added

 CC||chkumar...@gmail.com
   Assignee|nob...@fedoraproject.org|chkumar...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review