[Bug 1262643] Review Request: python-minibelt - One-file utility module filled with helper functions for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1262643 --- Comment #13 from Fedora Update System --- python-minibelt-0.1.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1262643] Review Request: python-minibelt - One-file utility module filled with helper functions for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1262643 --- Comment #12 from Fedora Update System --- python-minibelt-0.1.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1262643] Review Request: python-minibelt - One-file utility module filled with helper functions for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1262643 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2015-10-14 02:56:25 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1262643] Review Request: python-minibelt - One-file utility module filled with helper functions for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1262643 --- Comment #11 from Fedora Update System --- python-minibelt-0.1.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-minibelt' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-aefb9ebb39 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1262643] Review Request: python-minibelt - One-file utility module filled with helper functions for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1262643 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- python-minibelt-0.1.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-minibelt' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-36d2414106 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1262643] Review Request: python-minibelt - One-file utility module filled with helper functions for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1262643 --- Comment #9 from Fedora Update System --- python-minibelt-0.1.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-aefb9ebb39 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1262643] Review Request: python-minibelt - One-file utility module filled with helper functions for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1262643 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1262643] Review Request: python-minibelt - One-file utility module filled with helper functions for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1262643 --- Comment #8 from Fedora Update System --- python-minibelt-0.1.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-36d2414106 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1262643] Review Request: python-minibelt - One-file utility module filled with helper functions for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1262643 --- Comment #7 from Jon Ciesla --- This SCM request method has been deprecated. Please see https://fedoraproject.org/wiki/PackageDB_admin_requests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1262643] Review Request: python-minibelt - One-file utility module filled with helper functions for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1262643 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1262643] Review Request: python-minibelt - One-file utility module filled with helper functions for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1262643 René Ribaud changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from René Ribaud --- New Package SCM Request === Package Name: python-minibelt Short Description: One-file utility module filled with helper functions for Python Upstream URL: http://pypi.python.org/pypi/minibelt Owners: uggla Branches: f22 f23 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1262643] Review Request: python-minibelt - One-file utility module filled with helper functions for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1262643 --- Comment #5 from René Ribaud --- Thanks for the review Julien. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1262643] Review Request: python-minibelt - One-file utility module filled with helper functions for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1262643
Julien Enselme changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||juj...@jujens.eu
Assignee|nob...@fedoraproject.org|juj...@jujens.eu
Flags||fedora-review+
--- Comment #4 from Julien Enselme ---
- The URL can point to the project page on pypi. It presents the README, the
tarballs and has a link to the github page if the user wish to report an issue.
I personally find the pypi page more useful than the github page.
- I don't know if the patch is really useful nor if the import of open from io
is necessary.
- Please ask upstream to add a license file.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[X]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 2 files have unknown license. Detailed
output of licensecheck in /tmp/1262643-python-
minibelt/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
License file is not included.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[X]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[X]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 2 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[X]: Python eggs must not download any dependencies during the build
process.
[X]: A package which is used by another package via an egg interface should
provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[X]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpack
[Bug 1262643] Review Request: python-minibelt - One-file utility module filled with helper functions for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1262643 --- Comment #3 from Ilya Gradina --- Hi René! URL: The full URL for more information about the program (e.g. the project website). ... https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview .. I think that the site should be specified: - https://github.com/sametmax/minibelt but I could be wrong. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1262643] Review Request: python-minibelt - One-file utility module filled with helper functions for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1262643 --- Comment #2 from René Ribaud --- Hello, Thanks for the review. 1) I'm going to update the package in this way. 2) The upstream package is not provided with unitary tests. I kept the %check section in the spec file to remember me to implement that as soon as upstream will implement some of them. 3) I don't catch the issue with the URL ? Do you mean that the URL should point to the github site instead of pypi ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1262643] Review Request: python-minibelt - One-file utility module filled with helper functions for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1262643 Ilya Gradina changed: What|Removed |Added CC||ilya.grad...@gmail.com --- Comment #1 from Ilya Gradina --- This is an unofficial review of the package. some notes: 1) use macros %global sum One-file utility module filled with helper functions for Python .. - Summary: One-file utility module filled with helper functions for Python + Summary: sum .. 2) no tests 3) url - > https://github.com/sametmax/minibelt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
