[Bug 1263008] Review Request: openfortivpn - Client for PPP+SSL VPN tunnel services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1263008

Lubomir Rintel  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2015-09-18 11:21:01



--- Comment #6 from Lubomir Rintel  ---
Imported and built.

Thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1263008] Review Request: openfortivpn - Client for PPP+SSL VPN tunnel services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1263008

Lubomir Rintel  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #4 from Lubomir Rintel  ---
New Package SCM Request
===
Package Name: openfortivpn
Short Description: Client for PPP+SSL VPN tunnel services
Upstream URL: https://github.com/adrienverge/openfortivpn
Owners: lkundrak
Branches: f21 f22 f23 el6 epel7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1263008] Review Request: openfortivpn - Client for PPP+SSL VPN tunnel services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1263008



--- Comment #5 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1263008] Review Request: openfortivpn - Client for PPP+SSL VPN tunnel services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1263008

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1263008] Review Request: openfortivpn - Client for PPP+SSL VPN tunnel services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1263008

Lubomir Rintel  changed:

   What|Removed |Added

 Blocks||1263578




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1263578
[Bug 1263578] Review Request: NetworkManager-fortisslvpn - NetworkManager
VPN plugin for Fortinet compatible SSLVPN
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1263008] Review Request: openfortivpn - Client for PPP+SSL VPN tunnel services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1263008

Christopher Meng  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||i...@cicku.me
   Assignee|nob...@fedoraproject.org|i...@cicku.me
  Flags||fedora-review?



--- Comment #1 from Christopher Meng  ---
1. %{_sysconfdir}/openfortivpn/config

%config()?

2. ppp plugin directory is versioned, it's better to use

Requires:   ppp = $ppp_ver

or some others.

3. You miswrote Source0.

-
Ok for swap review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1263008] Review Request: openfortivpn - Client for PPP+SSL VPN tunnel services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1263008

Lubomir Rintel  changed:

   What|Removed |Added

 CC||lrin...@redhat.com



--- Comment #2 from Lubomir Rintel  ---
(In reply to Christopher Meng from comment #1)
> 1. %{_sysconfdir}/openfortivpn/config
> 
> %config()?

Fixed.

> 2. ppp plugin directory is versioned, it's better to use
> 
> Requires:   ppp = $ppp_ver
> 
> or some others.

We don't install a ppp plugin.

> 3. You miswrote Source0.

No, it's the one I intended to package. They're going to merge soon, I'll then
just switch it to the original one instead of the forked one. This just seemed
nicer that a pile-o-patches.

> Ok for swap review?

Sure, let me know which one you'd like me to review.

SPEC: http://v3.sk/~lkundrak/SPECS/openfortivpn.spec
SRPM:
http://v3.sk/~lkundrak/SRPMS/openfortivpn-1.0.1-2.20150914gitb22d9eb.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1263008] Review Request: openfortivpn - Client for PPP+SSL VPN tunnel services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1263008

Christopher Meng  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Christopher Meng  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)". Detailed output of licensecheck:

GPL (v3 or later)
-
openfortivpn-b22d9eb05aaa7666abc7ffbfc3daa3c842c03d31/src/config.c
openfortivpn-b22d9eb05aaa7666abc7ffbfc3daa3c842c03d31/src/config.h
openfortivpn-b22d9eb05aaa7666abc7ffbfc3daa3c842c03d31/src/hdlc.c
openfortivpn-b22d9eb05aaa7666abc7ffbfc3daa3c842c03d31/src/hdlc.h
openfortivpn-b22d9eb05aaa7666abc7ffbfc3daa3c842c03d31/src/http.c
openfortivpn-b22d9eb05aaa7666abc7ffbfc3daa3c842c03d31/src/http.h
openfortivpn-b22d9eb05aaa7666abc7ffbfc3daa3c842c03d31/src/io.c
openfortivpn-b22d9eb05aaa7666abc7ffbfc3daa3c842c03d31/src/io.h
openfortivpn-b22d9eb05aaa7666abc7ffbfc3daa3c842c03d31/src/ipv4.c
openfortivpn-b22d9eb05aaa7666abc7ffbfc3daa3c842c03d31/src/ipv4.h
openfortivpn-b22d9eb05aaa7666abc7ffbfc3daa3c842c03d31/src/log.c
openfortivpn-b22d9eb05aaa7666abc7ffbfc3daa3c842c03d31/src/log.h
openfortivpn-b22d9eb05aaa7666abc7ffbfc3daa3c842c03d31/src/main.c
openfortivpn-b22d9eb05aaa7666abc7ffbfc3daa3c842c03d31/src/ssl.h
openfortivpn-b22d9eb05aaa7666abc7ffbfc3daa3c842c03d31/src/tunnel.c
openfortivpn-b22d9eb05aaa7666abc7ffbfc3daa3c842c03d31/src/tunnel.h

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[-]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the