https://bugzilla.redhat.com/show_bug.cgi?id=1266999
Chris Leech changed:
What|Removed |Added
CC||agro...@redhat.com
Flags||needinfo?(agro...@redhat.co
||m)
--- Comment #1 from Chris Leech ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file LICENSE is marked as %doc instead of %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- D-Bus configuration files, systemd service files, and DSOs are installed as
executable when they shouldn't be.
/etc/dbus-1/system.d/tcmu-runner.conf
/usr/lib/systemd/system/tcmu-runner.service
/usr/lib64/tcmu-runner/handler_file.so
/usr/lib64/tcmu-runner/handler_glfs.so
/usr/share/dbus-1/system-services/org.kernel.TCMUService1.service
- %config file not marked noreplace (/etc/dbus-1/system.d/tcmu-runner.conf)
Note, it looks like a toss-up on my system as to which of these D-Bus policy
files are marked as %config(noreplace) or just as a regular file.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Apache (v2.0)", "Unknown or generated".
1 files have unknown license. Detailed output of licensecheck in
/home/cleech/review/1266999-tcmu-runner/licensecheck.txt
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/dbus-1/system-
services, /usr/share/dbus-1, /etc/dbus-1, /usr/lib/systemd/system,
/usr/lib/systemd, /etc/dbus-1/system.d
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: %config files are marked noreplace or the reason is justified.
Note: No (noreplace) in %config /etc/dbus-1/system.d/tcmu-runner.conf
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use