[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890



--- Comment #11 from Fedora Update System  ---
jsonld-java-tools-0.7.0-1.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-12-12 23:23:07



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
jsonld-java-tools-0.7.0-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update jsonld-java-tools'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-8aece2a1d8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890



--- Comment #9 from Fedora Update System  ---
jsonld-java-tools-0.7.0-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-8aece2a1d8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/jsonld-java-tools

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890



--- Comment #7 from Jerry James  ---
(In reply to gil cattaneo from comment #6)
> Maven build style do not use/need %check section. Test suite is tunning in
> the %build context

Ah, sorry, I usually insert a comment to that effect in reviews of maven-built
packages.  I apparently forgot to do so this time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890

Jerry James  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Jerry James  ---
You can fix the one small issue when you import the package.  This package is
APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890



--- Comment #6 from gil cattaneo  ---
(In reply to Jerry James from comment #4)
> I only see one very small issue.  In the xsltproc invocation in %build,
> "/usr/share" should be replaced with "%{_datadir}".

> [!]: Package consistently uses macros (instead of hard-coded directory
>  names).
>  In the xsltproc invocation, /usr/share should be replaced with
> %{_datadir}.

Done

> [!]: %check is present and all tests pass.
Maven build style do not use/need %check section. Test suite is tunning in the
%build context

Spec URL: https://gil.fedorapeople.org/jsonld-java-tools.spec
SRPM URL: https://gil.fedorapeople.org/jsonld-java-tools-0.7.0-1.fc23.src.rpm

Thanks!


Request for new package:
https://admin.fedoraproject.org/pkgdb/package/requests/1984
https://admin.fedoraproject.org/pkgdb/package/requests/1985

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890



--- Comment #4 from Jerry James  ---
I only see one very small issue.  In the xsltproc invocation in %build,
"/usr/share" should be replaced with "%{_datadir}".

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
 names).
 In the xsltproc invocation, /usr/share should be replaced with
%{_datadir}.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported 

[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890



--- Comment #2 from Upstream Release Monitoring 
 ---
gil's scratch build of jsonld-java-tools-0.7.0-1.fc23.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12023789

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890

Jerry James  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||loganje...@gmail.com
   Assignee|nob...@fedoraproject.org|loganje...@gmail.com
  Flags||fedora-review?



--- Comment #3 from Jerry James  ---
I will take this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890
Bug 1267890 depends on bug 1241447, which changed state.

Bug 1241447 Summary: Review Request: jsonld-java - A JSON-based format to 
serialize Linked Data for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1241447

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890

gil cattaneo  changed:

   What|Removed |Added

 Depends On||1235950




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1235950
[Bug 1235950] Review Request: openrdf-sesame - Java framework for
processing and handling RDF data
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890

gil cattaneo  changed:

   What|Removed |Added

 Blocks||1264337




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1264337
[Bug 1264337] Review Request: semweb4j - Java RDF Library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review