[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #57 from Fedora Update System  ---
python-sphinx-bootstrap-theme-0.4.13-3.el7 has been pushed to the Fedora EPEL 7
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #56 from Fedora Update System  ---
python-sphinx-bootstrap-theme-0.4.13-2.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #55 from Fedora Update System  ---
python-sphinx-bootstrap-theme-0.4.13-2.el6 has been pushed to the Fedora EPEL 6
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-02-19 17:47:28



--- Comment #54 from Fedora Update System  ---
python-sphinx-bootstrap-theme-0.4.13-2.fc24 has been pushed to the Fedora 24
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #53 from Fedora Update System  ---
python-sphinx-bootstrap-theme-0.4.13-3.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-cc6efe50e5

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #52 from Fedora Update System  ---
python-sphinx-bootstrap-theme-0.4.13-2.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a7e5a4ef7a

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #51 from Fedora Update System  ---
python-sphinx-bootstrap-theme-0.4.13-2.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a7e5a4ef7a

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #50 from Fedora Update System  ---
python-sphinx-bootstrap-theme-0.4.13-3.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-cc6efe50e5

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #49 from Fedora Update System  ---
python-sphinx-bootstrap-theme-0.4.13-2.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a7e5a4ef7a

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #48 from Fedora Update System  ---
python-sphinx-bootstrap-theme-0.4.13-2.el6 has been pushed to the Fedora EPEL 6
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-396d2c83fa

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #47 from Fedora Update System  ---
python-sphinx-bootstrap-theme-0.4.13-2.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-148319e5cf

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #46 from Fedora Update System  ---
python-sphinx-bootstrap-theme-0.4.13-2.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-23fac88286

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #45 from Fedora Update System  ---
python-sphinx-bootstrap-theme-0.4.13-2.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-23fac88286

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #44 from Fedora Update System  ---
python-sphinx-bootstrap-theme-0.4.13-2.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-148319e5cf

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #43 from Fedora Update System  ---
python-sphinx-bootstrap-theme-0.4.13-2.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a7e5a4ef7a

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #42 from Fedora Update System  ---
python-sphinx-bootstrap-theme-0.4.13-2.el6 has been submitted as an update to
Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-396d2c83fa

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #41 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-sphinx-bootstrap-theme

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
 CC|package-review@lists.fedora |
   |project.org |
  Flags|fedora-review?  |fedora-review+



--- Comment #40 from Björn "besser82" Esser  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Apache (v2.0)", "Unknown or generated".
 75 files have unknown license. Detailed output of licensecheck in
 /home/besser82/vm_shared/fedora/review/1268380-python-sphinx-
 bootstrap-theme/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python3.6/site-packages,
 /usr/lib/python3.6
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.6/site-
 packages, /usr/lib/python3.6

 --->  Ignored.  See my previous review report.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 81920 bytes in 8 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files

 --->  Unbundled as far as possible.

[x]: If the source package does not include license 

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #39 from Stuart Campbell  ---
Spec
URL:https://raw.githubusercontent.com/stuartcampbell/rpm-packages/master/sphinx-theme-bootstrap/python-sphinx-bootstrap-theme.spec
SRPM
URL:https://copr-be.cloud.fedoraproject.org/results/sic/packages/fedora-26-x86_64/00500847-python-sphinx-bootstrap-theme/python-sphinx-bootstrap-theme-0.4.13-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #38 from Björn "besser82" Esser  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Apache (v2.0)", "Unknown or generated".
 75 files have unknown license. Detailed output of licensecheck in
 /home/besser82/vm_shared/fedora/review/1268380-python-sphinx-
 bootstrap-theme/licensecheck.txt

 --->  License-tag just states MIT.  Please add other license.

[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python3.6/site-packages,
 /usr/lib/python3.6

 --->  False positive.  f-r resolves this query on the host-system
   instead inside the mock-chroot.

[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.6/site-
 packages, /usr/lib/python3.6

 --->  Same as above.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
 names).

 --->  See my remarks about rpmlint issues.

[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 122880 bytes in 12 files.

 --->  Since the *.txt-files are the same as the *.rst-files, it would
   be enough to package %doc PKG-INFO *.rst.

[!]: Package complies to the Packaging Guidelines

 --->  Issues are present.  ;(

[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files

 --->  Those fonts are available in the
   `glyphicons-halflings-fonts.noarch`-package.
   Try to unbundle them, please.

[-]: If the source package does not include license text(s) as a separate
 file from upstream, 

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks||1400748




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1400748
[Bug 1400748] shogun-5.0.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #37 from Stuart Campbell  ---
Spec
URL:https://raw.githubusercontent.com/stuartcampbell/rpm-packages/master/sphinx-theme-bootstrap/python-sphinx-bootstrap-theme.spec
SRPM
URL:https://copr-be.cloud.fedoraproject.org/results/sic/packages/fedora-26-x86_64/00500519-python-sphinx-bootstrap-theme/python-sphinx-bootstrap-theme-0.4.13-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #36 from Björn "besser82" Esser  ---
(In reply to Stuart Campbell from comment #34)
> Thank you for the comments and the PR - much appreciated.

You're welcome.  Just update the links to srpm and spec here.  I'll start a
formal review then.  =)


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #35 from Björn "besser82" Esser  ---
Scratch builds with my proposed changes to the spec-file are working fine:

el6:  https://koji.fedoraproject.org/koji/taskinfo?taskID=17306345
el7:  https://koji.fedoraproject.org/koji/taskinfo?taskID=17306347
f26:  https://koji.fedoraproject.org/koji/taskinfo?taskID=17306351

***

For el <= 6 you need to have explicit BR: epel-rpm-macros for local mock-builds
to work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #34 from Stuart Campbell  ---
Thank you for the comments and the PR - much appreciated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #33 from Björn "besser82" Esser  ---
Forgot to mention:  You need to BR: python-setuptools / python3-setuptools as
well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||besse...@fedoraproject.org
   Assignee|williamjmore...@gmail.com   |besse...@fedoraproject.org
Summary|Review Request: |Review Request:
   |python-sphinx-theme-bootstr |python-sphinx-bootstrap-the
   |ap - A sphinx theme that|me - A sphinx theme that
   |integrates the Bootstrap|integrates the Bootstrap
   |framework   |framework



--- Comment #32 from Björn "besser82" Esser  ---
Since there was no progress within the last three months, I'll take over the
review…

***

Your link to the spec-file isn't valid, it must point to the raw spec-file… 
Quick fix…

Spec URL:
https://raw.githubusercontent.com/stuartcampbell/rpm-packages/master/sphinx-theme-bootstrap/sphinx-theme-bootstrap.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sic/packages/fedora-rawhide-x86_64/00443690-python-sphinx-theme-bootstrap/python-sphinx-theme-bootstrap-0.4.5-2.fc26.src.rpm

***

Please update to the latest version: 0.4.13

***

Your spec-files is named wrong.  It should be named
'python-python-sphinx-bootstrap-theme' according to naming guidelines.  See: 
https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#Python_source_package_naming

***

Comments on the spec-file:

> %global summary A sphinx theme that integrates the Bootstrap framework

This isn't valid, since %{summary} is set by rpmbuild during parsing of the
spec-file and rotates it's contents for every sub-package.  Use sth. like:
%{common_sum} instead:

%global common_sum A sphinx theme that integrates the Bootstrap framework

…

Summary: %{common_sum}


> # RHEL doesn't have python 3 and does not know about __python2
> %if 0%{?rhel}  
>   %global __python2 %{__python}
>   %global python2_sitelib %{python_sitelib}
>   %global with_python3 0
> %else
>   %global with_python3 1
> %endif

Doing so is simply wrong…  You are shadowing the settings of the system-macros
if present…

A cleaner solution would be:

%{?!__python2:%global __python2 %{__python}}
%{?!python2_sitelib:%global python2_sitelib %{python_sitelib}}

%if 0%{?fedora} >= 13 || 0%{?rhel} >= 8
  %global with_py3 1
%endif # 0#{?fedora} >= 13 || 0#{?rhel} >= 8

This only evals if there is no system-preset for Python2 macros and works
without conditionals on a specific distro-release.  Just setting with_py, when
it is present, simplyfies a lot of conditonals, especially one-liners can
profit from conditional expansion.


The Url for Source0 is wrong.  See: 
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Python_Packages_.28pypi.29


> Requires:   js-jquery1

Is wrong at this place.  It must be placed into every sub-pkg, that needs it.


The BuildRequires should be moved into corresponding sub-pkg, too.


Repeating the same text in %description bloats the spec-file.  You can use:

%global common_desc \
This sphinx theme integrates the Booststrap CSS / Javascript framework \
with various layout options, hierarchical menu navigation, and mobile-\
friendly responsive design.  It is configurable, extensible and can use \
any number of different Bootswatch CSS themes.

And then use it in every %description like:

%description
%{common_desc}


The 'egg-info'-dir must be removed during %prep.


The package doesn't own the sub-dir it creates.


The installed egg-info-dirs should be packaged using the
%{pythonX_version}-macros.


There some other small adjustments.  I've created a PR on github for this. 
See:  https://github.com/stuartcampbell/rpm-packages/pull/4/commits

***

Not approved.  Please fix the spec-file and post updated links here;  I'll give
it another shot then.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org