[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 Paulo Andrade changed: What|Removed |Added CC||paulo.cesar.pereira.de.andr ||a...@gmail.com Docs Contact||paulo.cesar.pereira.de.andr ||a...@gmail.com Flags||fedora-review? --- Comment #1 from Paulo Andrade --- I will review it, as I recently packaged mozjs31, and I may need mozjs38 as dependency for my packages soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 Paulo Andrade changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Paulo Andrade --- Marek, The package looks quite good. I made some considerations below. Most important is the License issue, due tonew files under ASL 2.0. Looking at build log, most warnings appear ok, but this one might have issues: In file included from /builddir/build/BUILD/mozjs-38.0.0/js/src/js/src/Unified_cpp_js_src2.cpp:65:0: /builddir/build/BUILD/mozjs-38.0.0/js/src/irregexp/RegExpEngine.cpp: In member function 'virtual bool js::irregexp::TextNode::FillInBMInfo(int, int, js::irregexp::BoyerMooreLookahead*, bool)': /builddir/build/BUILD/mozjs-38.0.0/js/src/irregexp/RegExpEngine.cpp:4605:48: warning: array subscript is above array bounds [-Warray-bounds] bm->Set(offset, chars[j]); looking at the code it appears to be a false positive, likely because g++ did not understand that it should always return a value that is in bounds. But I may be mistaken, please comment. ---8<--- mozjs38.src:18: W: mixed-use-of-spaces-and-tabs (spaces: line 18, tab: line 1) Looks like you added a missing build requires from mozjs31 spec, but did not match spaces vs tabs :) ---8<--- In js.pc I see: Version: 38.3.0esrpre Looks like there is some confusion. But this is minor, just a comment. Should be expected from a .rc0. ---8<--- I believe is is not strictly an update do mozjs31, so you may modify the changelog to not say so. It should only have conflicts with mozjs31-devel and mozjs38-devel, otherwise, runtime will not conflict. ---8<--- Please remove the bundled mozjs-38.0.0/modules/zlib/ directory before starting build (mozjs31 does not have a modules subdir). It should not use it due to --with-system-zlib, but just to be sure. ---8<--- There are some new files under apache license, so, it should be required to add "ASL 2.0" to the License tag. In mozjs31 asmjs was simpler, in the js/src/jit directory, and under MPL 2.0 license. Now it is under js/src/asmjs/AsmJS and with apache license. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 --- Comment #3 from Marek Skalický --- Thank you for the review Paulo! > > Looking at build log, most warnings appear ok, but this > one might have issues: > > In file included from > /builddir/build/BUILD/mozjs-38.0.0/js/src/js/src/Unified_cpp_js_src2.cpp:65: > 0: > /builddir/build/BUILD/mozjs-38.0.0/js/src/irregexp/RegExpEngine.cpp: In > member function 'virtual bool js::irregexp::TextNode::FillInBMInfo(int, int, > js::irregexp::BoyerMooreLookahead*, bool)': > /builddir/build/BUILD/mozjs-38.0.0/js/src/irregexp/RegExpEngine.cpp:4605:48: > warning: array subscript is above array bounds [-Warray-bounds] > bm->Set(offset, chars[j]); > > looking at the code it appears to be a false positive, likely > because g++ did not understand that it should always return > a value that is in bounds. But I may be mistaken, please > comment. It looks good to me. j is always in the array bounds. > > ---8<--- > mozjs38.src:18: W: mixed-use-of-spaces-and-tabs (spaces: line 18, tab: line > 1) > > Looks like you added a missing build requires from mozjs31 > spec, but did not match spaces vs tabs :) Fixed:-) > > ---8<--- > In js.pc I see: > Version: 38.3.0esrpre > > Looks like there is some confusion. But this is minor, > just a comment. Should be expected from a .rc0. > I've changed it to 38.2.1.rc0 > ---8<--- > I believe is is not strictly an update do mozjs31, so you may > modify the changelog to not say so. It should only have conflicts > with mozjs31-devel and mozjs38-devel, otherwise, runtime will > not conflict. OK, you are right. Fixed. > > ---8<--- > Please remove the bundled mozjs-38.0.0/modules/zlib/ > directory before starting build (mozjs31 does not have > a modules subdir). It should not use it due to --with-system-zlib, > but just to be sure. OK. > > ---8<--- > There are some new files under apache license, so, it should > be required to add "ASL 2.0" to the License tag. > In mozjs31 asmjs was simpler, in the js/src/jit > directory, and under MPL 2.0 license. Now it is > under js/src/asmjs/AsmJS and with apache license. OK. Also added AFL - js/src/jit-test/tests/sunspider/check-string-unpack-code.js -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 --- Comment #4 from Marek Skalický --- Spec URL: https://mskalick.fedorapeople.org/mozjs38/mozjs38.spec SRPM URL: https://mskalick.fedorapeople.org/mozjs38/mozjs38-38.2.1-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539
--- Comment #5 from Paulo Andrade ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files directly in %_libdir.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL", "LGPL (v2.1 or later) (with incorrect FSF address)",
"*No copyright* MPL (v2.0)", "LGPL (v2.1)", "*No copyright* MIT/X11
(BSD like)", "*No copyright* LGPL (v2.1 or later)", "Public domain",
"GPL (v3 or later)", "Apache (v2.0) BSD (3 clause) MIT/X11 (BSD
like)", "zlib/libpng", "GPL (v2 or later) (with incorrect FSF
address)", "BSD (2 clause)", "GPL (v3)", "Apache (v2.0)", "GPL (v2 or
later)", "MIT/X11 (BSD like)", "*No copyright* Public domain", "BSD (3
clause)", "LGPL (v2.1 or later)", "MPL (v2.0) BSD (3 clause)", "BSD (3
clause) GPL (v2)", "Unknown or generated", "MPL (v2.0)", "GPL (v2)",
"MPL (v1.1) GPL (unversioned/unknown version)". 11612 files have
unknown license. Detailed output of licensecheck in
/home/pcpa/1269539-mozjs38/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must no
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 Paulo Andrade changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Paulo Andrade --- Package is approved! Please bump release between reviews. Even when there is significant rework in the package. For now, only before submitting it. Please make and test the small changes below before importing it. Please verify that parallel make still does not work. %check pass all tests on x86_64. Change it back to only exit with 0 status on failure if it fails on other arch, preferably only on secondary arches. I know it was copied from mozjs31, but I no longer remember the details, I think it failed 2 or 3 tests on other arches, or something like that. Please add me as co-maintainer, as I believe I may need to use it, and possibly add minor 0ad patches in the near future :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 Paulo Andrade changed: What|Removed |Added Docs Contact|paulo.cesar.pereira.de.andr | |a...@gmail.com | Assignee|nob...@fedoraproject.org|paulo.cesar.pereira.de.andr ||a...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 --- Comment #7 from Marek Skalický --- New Package SCM Request === Package Name: mozjs38 Short Description: JavaScript interpreter and libraries Upstream URL: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey Owners: mskalick pcpa Branches: f23 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 Marek Skalický changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 --- Comment #8 from Upstream Release Monitoring --- mskalick's scratch build of mozjs38-38.2.1-1.fc20.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11425256 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 --- Comment #9 from Marek Skalický --- Thank you for the review. All errors fixed. Spec URL: https://mskalick.fedorapeople.org/mozjs38/mozjs38.spec SRPM URL: https://mskalick.fedorapeople.org/mozjs38/mozjs38-38.2.1-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 --- Comment #10 from Upstream Release Monitoring --- mskalick's scratch build of mozjs38-38.2.1-2.fc20.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11425663 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 --- Comment #11 from Jon Ciesla --- This SCM request method has been deprecated. Please see https://fedoraproject.org/wiki/PackageDB_admin_requests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 --- Comment #12 from Kevin Fenzi --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/mozjs38 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 --- Comment #13 from Fedora Update System --- mozjs38-38.2.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-cee2efa3a1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 --- Comment #14 from Fedora Update System --- mozjs38-38.2.1-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-e400efbf68 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- mozjs38-38.2.1-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update mozjs38' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-e400efbf68 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 --- Comment #16 from Fedora Update System --- mozjs38-38.2.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-d4842a40f3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System --- mozjs38-38.2.1-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update mozjs38' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-d4842a40f3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 --- Comment #18 from Fedora Update System --- mozjs38-38.2.1-5.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-7c2272a08a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #19 from Fedora Update System --- mozjs38-38.2.1-5.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update mozjs38' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-7c2272a08a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2015-12-05 20:23:19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1269539 --- Comment #20 from Fedora Update System --- mozjs38-38.2.1-5.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
