[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #23 from Fedora Update System  ---
jcuber-4.3.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #24 from Fedora Update System  ---
jcuber-4.3.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #22 from Fedora Update System  ---
jcuber-4.3.3-2.fc22 has been pushed to the Fedora 22 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-28 19:23:05



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #17 from Fedora Update System  ---
jcuber-4.3.3-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-767f71fba2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #20 from Fedora Update System  ---
jcuber-4.3.3-2.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0eede362ef

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #18 from Fedora Update System  ---
jcuber-4.3.3-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ab59601aab

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #15 from Fedora Update System  ---
jcuber-4.3.3-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ab59601aab

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #14 from Fedora Update System  ---
jcuber-4.3.3-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0eede362ef

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #14 from Fedora Update System  ---
jcuber-4.3.3-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0eede362ef

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #16 from Fedora Update System  ---
jcuber-4.3.3-2.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-767f71fba2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #13 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/jcuber

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #11 from Dave Love  ---
(In reply to Orion Poplawski from comment #10)
> - doc subpackage must include the license

Fixed.  I thought it caused problems with the same file in different packages,
but it seems not.

> - Note license breakdown in spec

Comment added.

> [!]: Uses parallel make %{?_smp_mflags} macro.

I commented that it's useless.

> - Apparently doesn't cause a problem, but Provides should use "=" not "==".

Fixed, ta.  I wish there was proper documentation for rpm specs.

Spec URL: https://loveshack.fedorapeople.org/review/jcuber.spec
SRPM URL: https://loveshack.fedorapeople.org/review/jcuber-4.3.3-2.el6.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #9 from Dave Love  ---
New version

Spec URL: https://loveshack.fedorapeople.org/review/jcuber.spec
SRPM URL: https://loveshack.fedorapeople.org/review/jcuber-4.3.3-1.el6.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844

Orion Poplawski  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #10 from Orion Poplawski  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
  Note: No javadoc subpackage present
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
- Javadoc documentation files are generated and included in -javadoc
  subpackage
  Note: No javadoc subpackage present. Note: Javadocs are optional for
  Fedora versions >= 21
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation

The above are optional, so not a problem.

- doc subpackage must include the license
- Note license breakdown in spec

[!]: Uses parallel make %{?_smp_mflags} macro.

- Apparently doesn't cause a problem, but Provides should use "=" not "==".

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated". 91 files have unknown
 license. Detailed output of licensecheck in
 /export/home/orion/redhat/1269844-jcuber/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/licenses
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/licenses
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils

Maven:
[-]: If package contains pom.xml files install it (including metadata) even
 

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #8 from Dave Love  ---
Assuming the application stuff isn't relevant, I've updated it somewhat with
the test, installing the examples, and fixing the package name for
jcuber-config.

Spec URL: https://loveshack.fedorapeople.org/review/jcuber.spec
SRPM URL: https://loveshack.fedorapeople.org/review/jcuber-4.3.2-2.el6.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #2 from Dave Love  ---
(In reply to Orion Poplawski from comment #1)
> CubeReader is a GUI application so you need to require java, not java
> headless. 

Ah, OK.  I hadn't actually realized, as I was interested in it as a library.

> Also, you need to install a wrapper script to run the application, see
> https://fedorahosted.org/released/javapackages/doc/
> #_generating_application_shell_scripts

What was it in the original cube package for compatibility?  I can't see
anything relevant in the git history.

I also realize there should be a test run.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #3 from Orion Poplawski  ---
(In reply to Dave Love from comment #2)
> (In reply to Orion Poplawski from comment #1)
> > Also, you need to install a wrapper script to run the application, see
> > https://fedorahosted.org/released/javapackages/doc/
> > #_generating_application_shell_scripts
> 
> What was it in the original cube package for compatibility?  I can't see
> anything relevant in the git history.

No, I forgot to do that in the old package.  Always helpful to re-review :)

> I also realize there should be a test run.

Perhaps, if there is a supported way to do so.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #4 from Orion Poplawski  ---
(In reply to Dave Love from comment #2)
> (In reply to Orion Poplawski from comment #1)
> > CubeReader is a GUI application so you need to require java, not java
> > headless. 
> 
> Ah, OK.  I hadn't actually realized, as I was interested in it as a library.

You could conceivably split out the library or the application into a
sub-package if you wanted to allow people to install just the library with
java-headless - but I suspect that anything that make use of the java library
would be a gui java application itself.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #7 from Orion Poplawski  ---
Hmm, maybe I'm wrong about it being an application after all.  These are the
only main functions I find:

./jcuber-4.3.2/test/test10.0/cube_test10.java:  public static void
main(String[] args)
./jcuber-4.3.2/examples/jcuber/jcuber_example.java:public static void
main(String[] args)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #1 from Orion Poplawski  ---
CubeReader is a GUI application so you need to require java, not java headless. 

Also, you need to install a wrapper script to run the application, see
https://fedorahosted.org/released/javapackages/doc/#_generating_application_shell_scripts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844

Orion Poplawski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||or...@cora.nwra.com
   Assignee|nob...@fedoraproject.org|or...@cora.nwra.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review