[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1288804 (python-pysegbase)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1288804
[Bug 1288804] Review Request: python-pysegbase - 3D graph cut segmentation
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-11-22 19:25:00



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837



--- Comment #14 from Fedora Update System  ---
python-pydicom-1.0.0-0.3.gitf6191c7.fc23 has been pushed to the Fedora 23
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
python-pydicom-1.0.0-0.3.gitf6191c7.fc23 has been pushed to the Fedora 23
testing repository. If problems still persist, please make note of it in this
bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-pydicom'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-2803c1bf3b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837



--- Comment #6 from Igor Gnatenko  ---
i got few free mins:
New SRPM:
https://ignatenkobrain.fedorapeople.org/neurofedora/python-pydicom-1.0.0-0.2.gitf6191c7.fc24.src.rpm
New SPEC:
https://ignatenkobrain.fedorapeople.org/neurofedora/python-pydicom.spec

- Include license file
- Add BSD to license list (generated data) from GDCM

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837



--- Comment #4 from Igor Gnatenko  ---
(In reply to Julien Enselme from comment #3)
> Hi,
Hi,
> 
> Before doing a full review of this package, I have some questions/remarks:
> 
> - I think the initial release tag is incorrect and should be
> 0.1.git%{shortcommit}%{?dist} instead of 0.0.git%{shortcommit}%{?dist} (so
> the current release tag should be 0.2.git%{shortcommit}%{?dist}) See
> https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
> - Please add %license pydicom/license.txt to all subpackage to install the
> license file where it is expected to be.
ok, I will add license.txt to all subpkgs. Please do full review and if no
other issues will found - I will do when will import to fedora infra.

Regarding version I don't think that there are problems, I will bump to
0.1.git.. once I will bump. It's initial package and I don't see any
problems. Anyway if you want - I will do this when will import to fedora git.
> 
> - According to the license file, some part of the software are bundled with
> pydicom and distributed under a different license:
I unbundled all libraries.
> 
> > Portions of pydicom (private dictionary file(s)) were generated from the 
> > private dictionary of the GDCM library, released under the following 
> > license:
> 
> >  Program: GDCM (Grassroots DICOM). A DICOM library
> >  Module:  http://gdcm.sourceforge.net/Copyright.html
> 
> However, I don't know which files this relates to. Do you have more
> information on that?
GDCM itself licensed under BSD. Regarding licensing for those part, I will add
also BSD to license list.

But please do full review first and if it's all, set fedora-review+ and I will
add this when import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837

Julien Enselme  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||juj...@jujens.eu
   Assignee|nob...@fedoraproject.org|juj...@jujens.eu
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837



--- Comment #3 from Julien Enselme  ---
Hi,

Before doing a full review of this package, I have some questions/remarks:

- I think the initial release tag is incorrect and should be
0.1.git%{shortcommit}%{?dist} instead of 0.0.git%{shortcommit}%{?dist} (so the
current release tag should be 0.2.git%{shortcommit}%{?dist}) See
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
- Please add %license pydicom/license.txt to all subpackage to install the
license file where it is expected to be.

- According to the license file, some part of the software are bundled with
pydicom and distributed under a different license:

> Portions of pydicom (private dictionary file(s)) were generated from the 
> private dictionary of the GDCM library, released under the following license:

>  Program: GDCM (Grassroots DICOM). A DICOM library
>  Module:  http://gdcm.sourceforge.net/Copyright.html

However, I don't know which files this relates to. Do you have more information
on that?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837



--- Comment #5 from Igor Gnatenko  ---
But.

its just that he autogenerates some python dicts from GDCM thats under one of
those "you have to include this notice that says CREATIS is not responsible for
anything you do with this code"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837



--- Comment #7 from Julien Enselme  ---
Almost good. See below my comment on the rpmlint error and on the incorrect
provides.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[X]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 177 files have unknown license.
 Detailed output of licensecheck in /tmp/1276837-python-
 pydicom/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[X]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
 names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 675840 bytes in 74 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[X]: Python eggs must not download any dependencies during the build
 process.
[X]: A package which is used by another package via an egg interface should
 provide egg info.
[!]: Package meets the Packaging Guidelines::Python
Please correct the rpmlint error: E: non-executable-script. You can use in
%install:
sed -i '1{\@^#!/usr/bin/env python@d}'
%{buildroot}%{python2_sitearch}/%{modname}/contrib/dicom_dao.py
sed -i '1{\@^#!/usr/bin/env python@d}'
%{buildroot}%{python3_sitearch}/%{modname}/contrib/dicom_dao.py

[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[X]: Uses parallel make %{?_smp_mflags} macro.
make is used to build doc, the _smp_mflags is not needed in this case.

[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
They should be:
python3-pydicom:
python3-pydicom(x86-64)
python3-pydicom

python2-pydicom:
python-pydicom
python-pydicom(x86-64)
python2-pydicom(x86-64)
python2-pydicom

It may come from the 

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837

Julien Enselme  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Julien Enselme  ---
Looks good. Approved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837



--- Comment #8 from Igor Gnatenko  ---
Many thanks for quick review. Will fix in few minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837



--- Comment #9 from Igor Gnatenko  ---
New SRPM:
https://ignatenkobrain.fedorapeople.org/neurofedora/python-pydicom-1.0.0-0.3.gitf6191c7.fc24.src.rpm
New SPEC:
https://ignatenkobrain.fedorapeople.org/neurofedora/python-pydicom.spec

- Fix provide macro for py3 (typo)
- Remove shebang from dicom_dao.py (non-executable-script)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837



--- Comment #11 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-pydicom

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837



--- Comment #12 from Fedora Update System  ---
python-pydicom-1.0.0-0.3.gitf6191c7.fc23 has been submitted as an update to
Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-2803c1bf3b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837

Igor Gnatenko  changed:

   What|Removed |Added

  Alias||python-pydicom



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837



--- Comment #2 from Igor Gnatenko  ---
New SPEC:
https://ignatenkobrain.fedorapeople.org/neurofedora/python-pydicom.spec
New SRPM:
https://ignatenkobrain.fedorapeople.org/neurofedora/python-pydicom-1.0.0-0.1.gitf6191c7.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1276941 (fedora-neuro)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1276941
[Bug 1276941] (fedora-neuro) Fedora NeuroImaging and NeuroScience tracking
bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1276871




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1276871
[Bug 1276871] Review Request: python-nibabel - Python package to access a
cacophony of neuro-imaging file formats
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837



--- Comment #1 from Igor Gnatenko  ---
New SPEC:
https://ignatenkobrain.fedorapeople.org/for-review/python-pydicom.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review