[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901

Didik Supriadi  changed:

   What|Removed |Added

 CC||didiksupriad...@gmail.com
  Flags||needinfo?(pete0verse@gmail.
   ||com)




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901

Petr Menšík  changed:

   What|Removed |Added

 CC||pemen...@redhat.com



--- Comment #16 from Petr Menšík  ---
If you still want include this package, please update links to working spec and
srpm archive. And update to latest upstream version available. If not, please
close the review.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

needinfo canceled: [Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Package Review  has canceled Package
Review 's request for Björn 'besser82'
Esser 's needinfo:
Bug 1276901: Review Request: xoscope - Simple but powerful sound card
oscilloscope
https://bugzilla.redhat.com/show_bug.cgi?id=1276901



--- Comment #15 from Package Review 
---
This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901

PeteV  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901



--- Comment #12 from PeteV  ---
Thanks Björn, much to learn.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901



--- Comment #13 from PeteV  ---
(In reply to Björn "besser82" Esser from comment #11)
> Spec URL:
> https://raw.githubusercontent.com/PeteV/RPM-Repo/master/xoscope.spec
> SRPM URL:
> https://copr-be.cloud.fedoraproject.org/results/petev/xoscope/fedora-rawhide-
> x86_64/00131632-xoscope/xoscope-2.1-1.fc24.src.rpm
> * * *
> 
> srpm-url corrected

thanks again Björn, I made some changes to the spec file and rebuild on copr
if you could do a quick check that will be great :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901



--- Comment #10 from Björn "besser82" Esser  ---
Spec URL: https://raw.githubusercontent.com/PeteV/RPM-Repo/master/xoscope.spec
SRPM URL:
https://raw.githubusercontent.com/PeteV/RPM-Repo/master/xoscope-2.1-1.fc22.x86_64.rpm

* * *

github-urls corrected

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||fed...@besser82.io
   Assignee|nob...@fedoraproject.org|fed...@besser82.io
  Flags||fedora-review?



--- Comment #9 from Björn "besser82" Esser  ---
Hey!

It's better to provide direct-download urls for reviewers, so
fedora-review-tool can pick-up the files directly.  =)

e.g. like this:

Spec URL: https://raw.githubusercontent.com/PeteV/RPM-Repo/master/xoscope.spec
SRPM URL:
https://github.com/PeteV/RPM-Repo/raw/master/xoscope-2.1-1.fc22.x86_64.rpm

* * *

Taking this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901



--- Comment #11 from Björn "besser82" Esser  ---
Spec URL: https://raw.githubusercontent.com/PeteV/RPM-Repo/master/xoscope.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/petev/xoscope/fedora-rawhide-x86_64/00131632-xoscope/xoscope-2.1-1.fc24.src.rpm
* * *

srpm-url corrected

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it
   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901



--- Comment #1 from gil cattaneo  ---
can you take this for me https://bugzilla.redhat.com/show_bug.cgi?id=1266804 ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901



--- Comment #2 from gil cattaneo  ---
know the meaning of Spec URL and SRPM URL ? why I do not know what to make of
these references you provided ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901



--- Comment #3 from gil cattaneo  ---
Please, remove "rm -rf $RPM_BUILD_ROOT" from install section

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901



--- Comment #4 from gil cattaneo  ---
It could be that you're not part of the packaging group?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901



--- Comment #5 from gil cattaneo  ---
Other issues:
%doc %{_datadir}/man/man1/%{name}.1.gz
%doc %{_datadir}/pixmaps/
%doc /usr/bin/%{name} 
please, remove %doc macro and use %{_bindir}/%{name}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901



--- Comment #6 from PeteV  ---
(In reply to gil cattaneo from comment #4)
> It could be that you're not part of the packaging group?

true I'm not, I need a sponsor for the package and myself. 
I'm willing to spend a lot of time and effort in learning the right way to do
this packaging. :)

I didn't quite understand what you meant by not making sense on the urls and
such
but now I'm connecting the two and deducing you meant to question why they are
that way.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |



--- Comment #7 from gil cattaneo  ---
(In reply to PeteV from comment #6)
> (In reply to gil cattaneo from comment #4)
> > It could be that you're not part of the packaging group?
> 
> true I'm not, I need a sponsor for the package and myself. 
> I'm willing to spend a lot of time and effort in learning the right way to
> do this packaging. :)

Please, read
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
https://fedoraproject.org/wiki/Package_Review_Process

> I didn't quite understand what you meant by not making sense on the urls and
> such
> but now I'm connecting the two and deducing you meant to question why they
> are that way.

I leave this bug to others, who could become your sponsor (i cant help you in
this)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901

gil cattaneo  changed:

   What|Removed |Added

   Assignee|punto...@libero.it  |nob...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276901] Review Request: xoscope - Simple but powerful sound card oscilloscope

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276901



--- Comment #8 from PeteV  ---
Ok Gil thanks have a great day!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review