[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #40 from Fedora Update System --- codec2-0.5-1.el7, freedv-1.1-5.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2016-01-31 21:24:37 |2016-02-16 20:57:47 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords||Reopened --- Comment #39 from Fedora Update System --- codec2-0.5-1.el7, freedv-1.1-5.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #38 from Fedora Update System --- freedv-1.1-4.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2016-01-31 21:24:37 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #37 from Fedora Update System --- freedv-1.1-4.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #36 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-5.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #35 from Fedora Update System --- freedv-1.1-4.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-86353fa95c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #34 from Fedora Update System --- codec2-0.5-1.el7, freedv-1.1-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #33 from Fedora Update System --- freedv-1.1-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #32 from Fedora Update System --- freedv-1.1-4.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-86353fa95c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #22 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #23 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #24 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #25 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #26 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #27 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #28 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #22 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #23 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #22 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #23 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #24 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #25 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #22 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #23 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #24 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #25 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #26 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #27 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #28 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #29 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #30 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #22 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #23 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #24 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #25 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #26 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #27 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #28 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #29 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #30 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #31 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #22 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #23 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #24 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #22 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #23 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #24 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #25 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #26 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #27 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #28 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #29 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #22 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #23 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #24 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #25 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #26 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #31 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #22 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #23 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #24 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #25 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa --- Comment #26 from Fedora Update System --- freedv-1.1-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8343a0e9 --- Comment #27 from Fedora Update System --- codec2-0.5-1.el7 freedv-1.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d007a8affa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #21 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/freedv -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #20 from Richard Shaw --- Thanks for the thorough review and patience! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638
Antonio Trande changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #19 from Antonio Trande ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
== Note ==
Still not ready for EPEL.
'About' window shows a text bug.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* LGPL (v2.1)", "*No copyright* GPL (v2.1)", "GPL
(v2 or later)", "Unknown or generated", "LGPL (v2.1)". 22 files have
unknown license. Detailed output of licensecheck in
/home/sagitter/FedoraReview/1278638-freedv/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/256x256/apps,
/usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/128x128,
/usr/share/icons/hicolor/128x128/apps,
/usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/64x64,
/usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/256x256,
/usr/share/icons/hicolor
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in freedv
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #18 from Upstream Release Monitoring --- sagitter's scratch build of freedv-1.1-4.fc22.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12633479 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #17 from Upstream Release Monitoring --- sagitter's scratch build of freedv-1.1-4.fc22.src.rpm for epel7 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12633419 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #16 from Richard Shaw --- (In reply to Antonio Trande from comment #15) > appstream-util check is failed. > Add dconf as BuildRequires and Requires package. Turns out it just didn't like my use of . It still shows the same error but then reports "OK" and continues. Interesting that it doesn't have any issue on F22 but does have an issue in rawhide. I just removed it from the appdata file and reuploaded the spec and SRPM. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #15 from Antonio Trande --- appstream-util check is failed. Add dconf as BuildRequires and Requires package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #14 from Richard Shaw --- SPEC: https://hobbes1069.fedorapeople.org/freedv.spec SRPM: https://hobbes1069.fedorapeople.org/freedv-1.1-4.fc22.src.rpm * Wed Jan 20 2016 Richard Shaw - 1.1-4 - Create appdata file. Got derailed by the holidays and it took a little while to get a properly formatted screenshot from upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #13 from Richard Shaw --- (In reply to Antonio Trande from comment #12) > Hardened builds are required for all packages: > https://fedoraproject.org/wiki/Changes/Harden_All_Packages It's not required as freedv does not meet any of the requirements in the guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines#PIE But it is a good idea nonetheless and already done. > - Please, leave a comment to additional SourceX and Patches. > > - Appdata file? Forgot about those, I will address them as soon as I can. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638
--- Comment #12 from Antonio Trande ---
(In reply to Richard Shaw from comment #10)
> Ok, I've taken care of the sox issue but I'm not exactly sure what to do
> about PIC/PIE... Since freedv is not a daemon or "long running application"
> I'm not sure full RELO is required but I would prefer it that way but I
> don't really understand the build flags well enough to know exactly what I'm
> doing.
Hardened builds are required for all packages:
https://fedoraproject.org/wiki/Changes/Harden_All_Packages
- Please, leave a comment to additional SourceX and Patches.
- Appdata file?
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* LGPL (v2.1)", "*No copyright* GPL (v2.1)", "GPL
(v2 or later)", "LGPL (v2.1)", "Unknown or generated". 54 files have
unknown license. Detailed output of licensecheck in
/home/sagitter/1278638-freedv/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/256x256/apps,
/usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/128x128,
/usr/share/icons/hicolor/128x128/apps,
/usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/64x64,
/usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/256x256,
/usr/share/icons/hicolor
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in freedv
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a nam
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #11 from Richard Shaw --- Spec URL: http://hobbes1069.fedorapeople.org/freedv.spec SRPM URL: http://hobbes1069.fedorapeople.org/freedv-1.1-3.fc22.src.rpm * Tue Dec 8 2015 Richard Shaw - 1.1-3 - Add sox to sources so it is not downloaded during the build. - Add necessary build flags for RELO and PIE. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #10 from Richard Shaw --- Ok, I've taken care of the sox issue but I'm not exactly sure what to do about PIC/PIE... Since freedv is not a daemon or "long running application" I'm not sure full RELO is required but I would prefer it that way but I don't really understand the build flags well enough to know exactly what I'm doing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #9 from Richard Shaw --- (In reply to Antonio Trande from comment #7) > - A temporary bundling of Sox libraries is permitted but you cannot download > Sox during build process, i think. You're right, I didn't even think about that. I'm working on a solution but even if I put sox in the right place before configuration or make it still insists on redownloading. I'll have to dig into that one. Since I wrote the build system I don't really have anyone else to ask for help! :) > - 'freedv' executable file results Not PIE, Partial RELRO. Some > compiler/linker flags are missing. Cmake is generally good about honoring build flags specified in environment variables, I'll dig into this one next. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #8 from Antonio Trande --- > 'freedv' executable file results Not PIE, Partial RELRO. Some compiler/linker > flags are missing. - 'freedv' executable file is 'Not PIE, Partial RELRO'. Some compiler/linker flags are missing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #7 from Antonio Trande --- - A temporary bundling of Sox libraries is permitted but you cannot download Sox during build process, i think. - 'freedv' executable file results Not PIE, Partial RELRO. Some compiler/linker flags are missing. - Make an appdata file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #6 from Richard Shaw --- Spec URL: http://hobbes1069.fedorapeople.org/freedv.spec SRPM URL: http://hobbes1069.fedorapeople.org/freedv-1.1-2.fc22.src.rpm Fixed dist tag in the link since I've upgraded Fedora releases since this was posted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #5 from Richard Shaw --- Spec URL: http://hobbes1069.fedorapeople.org/freedv.spec SRPM URL: http://hobbes1069.fedorapeople.org/freedv-1.1-2.fc21.src.rpm * Fri Dec 4 2015 Richard Shaw - 1.1-2 - Move to bundled sox to work around now private function in sox 14.4.2. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #4 from Richard Shaw --- Darn, I forgot about that. With the sox 14.4.2 release they made a bunch of previously public functions private. The only workaround for now is bundling sox which I don't want to do but it's currently acceptable. I'll update the package and add the Provides for bundled sox. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 --- Comment #3 from Antonio Trande --- Linking fails: /builddir/build/BUILD/freedv-1.1/src/sox_biquad.c:97: undefined reference to `lsx_biquad_flow' /builddir/build/BUILD/freedv-1.1/src/sox_biquad.c:97: undefined reference to `lsx_biquad_flow' collect2: error: ld returned 1 exit status -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638 Antonio Trande changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638
--- Comment #2 from Richard Shaw ---
(In reply to Antonio Trande from comment #1)
> %if 0%{?fedora} > 21
> BuildRequires: speexdsp-devel
> %else
I'll probably leave it in for one release as someone may want to build
themselves.
> - %{!?_licensedir:%global license %doc}
>
> Will be this software packaged for EPEL6?
For EPEL 7 at least but I like to include that since it's a one liner and may
help for other distro's that don't use %license (Suse, etc) that may want to
use my SRPM.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1278638] Review Request: freedv - FreeDV Digital Voice
https://bugzilla.redhat.com/show_bug.cgi?id=1278638
Antonio Trande changed:
What|Removed |Added
CC||anto.tra...@gmail.com
--- Comment #1 from Antonio Trande ---
%if 0%{?fedora} > 21
BuildRequires: speexdsp-devel
%else
None new package can be pushed for F21 since it's in EOL. I think this
conditional macro can be removed.
- %{!?_licensedir:%global license %doc}
Will be this software packaged for EPEL6?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
