[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191

James Hogarth  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2016-02-20 17:30:32



--- Comment #14 from James Hogarth  ---
Closing review bug as it's been pushed to all current Fedora releases.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191



--- Comment #12 from Fedora Update System  ---
python-pyrfc3339-1.0-1.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191



--- Comment #13 from Fedora Update System  ---
python-pyrfc3339-1.0-1.fc22 has been pushed to the Fedora 22 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
python-pyrfc3339-1.0-1.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-pyrfc3339'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-14c9c2e8a6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191



--- Comment #11 from Fedora Update System  ---
python-pyrfc3339-1.0-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-pyrfc3339'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-61f17ca6c0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191



--- Comment #8 from Fedora Update System  ---
python-pyrfc3339-1.0-1.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-14c9c2e8a6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191



--- Comment #9 from Fedora Update System  ---
python-pyrfc3339-1.0-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-61f17ca6c0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
Ping?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to James Hogarth from comment #6)
> I was made redundant shortly after ths
Sorry to hear that.

> That's sorted now
Pfff, at least that's not bad. That's pretty quick.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191



--- Comment #6 from James Hogarth  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #5)
> Ping?

Apologies...

I was made redundant shortly after this and other priorities got ahead of me
(ie work to afford my recent arrival).

That's sorted now so can get this pushed into git and built tomorrow night.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-pyrfc3339

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191



--- Comment #3 from James Hogarth  ---
Thanks for the notes and review.

New spec/srpm in place with the 1.0 version including the license properly and
added back in the installed tests, along with removed the setuptools dependency

Spec URL:
https://jhogarth.fedorapeople.org/python-pyrfc3339/python-pyrfc3339.spec
SRPM URL:
https://jhogarth.fedorapeople.org/python-pyrfc3339/python-pyrfc3339-1.0-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
Apart from the missing LICENSE file, everything is OK, so I'll continue the
review based on the current version, assuming the updated tarball.

Package Review
==

Legend:
[x] = Pass, [-] = Not applicable, [ ] = Other

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
MIT license.

[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 14 files have unknown license. Detailed
 output of licensecheck in /var/tmp/1279191-python-
 pyrfc3339/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: 

[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191



--- Comment #1 from James Hogarth  ---
There has been a new package uploaded to PyPi including the license file
appropriately.

I'll update this review request this evening with the new tarball being used.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191

James Hogarth  changed:

   What|Removed |Added

 Blocks||1215478




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1215478
[Bug 1215478] Review Request: lets-encrypt - A free, automated certificate
authority
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279191] Review Request: python-pyrfc3339 - pyRFC3339 parses and generates RFC 3339-compliant timestamps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279191

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review