[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 Bug 1281876 depends on bug 1273601, which changed state. Bug 1273601 Summary: Review Request: python-qutepart - Code editor widget https://bugzilla.redhat.com/show_bug.cgi?id=1273601 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #40 from Fedora Update System --- enki-15.11.0-2.el7, python-qutepart-2.2.2-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #39 from Fedora Update System --- enki-15.11.0-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 Raphael Groner changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed|2015-12-16 04:53:54 |2016-01-11 16:54:26 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #38 from Fedora Update System --- enki-15.11.0-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f154dc4371 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #37 from Fedora Update System --- enki-15.11.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-35eb73f03b -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords||Reopened --- Comment #36 from Fedora Update System --- enki-15.11.0-2.el7, python-qutepart-2.2.2-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-c3e2a2e9f9 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 Bug 1281876 depends on bug 1273601, which changed state. Bug 1273601 Summary: Review Request: python-qutepart - Code editor widget https://bugzilla.redhat.com/show_bug.cgi?id=1273601 What|Removed |Added Status|CLOSED |ON_QA Resolution|ERRATA |--- -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #35 from Fedora Update System --- enki-15.11.0-2.el7 python-qutepart-2.2.2-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-c3e2a2e9f9 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #34 from Fedora Update System --- enki-15.11.0-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-35eb73f03b -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #33 from Fedora Update System --- enki-15.11.0-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f154dc4371 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 Raphael Groner changed: What|Removed |Added Alias|enki| -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #32 from Yajo --- Could you remove the alias for this bug please? I cannot search for Enki bugs. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #31 from Fedora Update System --- enki-15.11.0-1.fc23, python-qutepart-2.2.2-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2015-12-16 04:53:54 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #30 from Fedora Update System --- enki-15.11.0-1.fc22, python-qutepart-2.2.2-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 Bug 1281876 depends on bug 1273601, which changed state. Bug 1273601 Summary: Review Request: python-qutepart - Code editor widget https://bugzilla.redhat.com/show_bug.cgi?id=1273601 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #29 from Fedora Update System --- enki-15.11.0-1.fc23, python-qutepart-2.2.2-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-qutepart enki' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-175d04c097 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #28 from Fedora Update System --- enki-15.11.0-1.el7, python-qutepart-2.2.2-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update python-qutepart enki' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-c3e2a2e9f9 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #27 from Fedora Update System --- enki-15.11.0-1.fc22, python-qutepart-2.2.2-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-qutepart enki' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-85b822e636 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #26 from Fedora Update System --- enki-15.11.0-1.el7 python-qutepart-2.2.2-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-c3e2a2e9f9 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #25 from Fedora Update System --- enki-15.11.0-1.el7 python-qutepart-2.2.2-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-c3e2a2e9f9 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #23 from Fedora Update System --- enki-15.11.0-1.fc22 python-qutepart-2.2.2-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-85b822e636 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #24 from Fedora Update System --- enki-15.11.0-1.fc22 python-qutepart-2.2.2-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-85b822e636 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #22 from Fedora Update System --- enki-15.11.0-1.fc23 python-qutepart-2.2.2-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-175d04c097 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #21 from Fedora Update System --- enki-15.11.0-1.fc23 python-qutepart-2.2.2-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-175d04c097 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #20 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/enki -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #19 from Upstream Release Monitoring --- raphgro's scratch build of enki-15.11.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12041466 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #18 from Upstream Release Monitoring --- raphgro's scratch build of enki-15.11.0-1.fc23.src.rpm for epel7 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12041470 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876
Christian Dersch changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #17 from Christian Dersch ---
Package looks fine now => APPROVED!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 350 files have unknown license.
Detailed output of licensecheck in
/home/review/1281876-enki/licensecheck.txt
> Whole package is GPLv2+ now as mentioned explicitly by upstream => fine
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in enki
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in enki
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requ
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #16 from Raphael Groner --- test builds: https://copr.fedoraproject.org/coprs/raphgro/playground/build/144648/ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #15 from Raphael Groner --- SPEC: https://raphgro.fedorapeople.org/review/qt/enki/enki.spec SRPM: https://raphgro.fedorapeople.org/review/qt/enki/enki-15.11.0-1.fc23.src.rpm rawhide Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=12041466 epel7 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=12041470 * Thu Dec 03 2015 Raphael Groner <> - 15.11.0-1 - new version - add python-regex - remove license breakdown, now generally GPLv2+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #14 from Christian Dersch --- I think we should wait for new 15.11 release https://github.com/hlamer/enki/issues/344#issuecomment-158680829 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876
--- Comment #13 from Christian Dersch ---
Package itself is fine now :) I'll approve when upstream clarified GPLv2 vs
GPLv3 stuff.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[?]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[?]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v3 or later)", "Unknown or generated". 343 files have
unknown license. Detailed output of licensecheck in
/home/review/1281876-enki/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in enki
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in enki
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
> Done by Raphael, https://github.com/hlamer/enki/issues/344
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in enki-d
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #12 from Upstream Release Monitoring --- raphgro's scratch build of enki-15.05.0-2.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11887946 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #11 from Raphael Groner --- SPEC: https://raphgro.fedorapeople.org/review/qt/enki/enki.spec SRPM: https://raphgro.fedorapeople.org/review/qt/enki/enki-15.05.0-2.fc23.src.rpm Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=11887946 * Tue Nov 17 2015 Raphael Groner <> - 15.05.0-2 - fix license breakdown - ignore useless distribution folders - use python macros to build and install - split plugins into subpackage -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #10 from Raphael Groner --- License clarification: https://github.com/hlamer/enki/issues/344 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #9 from Christian Dersch --- Created attachment 1094220 --> https://bugzilla.redhat.com/attachment.cgi?id=1094220&action=edit Output of licensecheck -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876
--- Comment #8 from Christian Dersch ---
Review done :) Solution: Not approved
TODO:
* License tag should be GPLv2+ and GPLv3+
* Please add licensing breakdown
* Ask upstream about license of files with unknown license
* Ask upstream to include a copy of GPLv3 too
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[?]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
> ask upstream about license of files with unknown license
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v3 or later) GPL (v3 or later)", "GPL (v2 or later)",
"GPL (v3 or later)", "Unknown or generated". 359 files have unknown
license. Detailed output of licensecheck in
/home/review/1281876-enki/licensecheck.txt
> License tag should be GPLv2+ and GPLv3+
[x]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
> Please add this, ask upstream about license of files with unknown license
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in enki
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in enki
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: If the sour
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 Christian Dersch changed: What|Removed |Added Status|NEW |ASSIGNED CC||lupi...@mailbox.org Assignee|nob...@fedoraproject.org|lupi...@mailbox.org Flags||fedora-review? --- Comment #7 from Christian Dersch --- Taken and already reviewing :) -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #6 from Upstream Release Monitoring --- raphgro's scratch build of enki-15.05.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11822674 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #5 from Raphael Groner --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=11822674 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 Raphael Groner changed: What|Removed |Added CC|extras...@fedoraproject.org | |, nob...@fedoraproject.org, | |package-review@lists.fedora | |project.org,| |projects...@smart.ms| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #4 from Raphael Groner --- SPEC: https://raphgro.fedorapeople.org/review/qt/enki/enki.spec SRPM: https://raphgro.fedorapeople.org/review/qt/enki/enki-15.05.0-1.fc23.src.rpm Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=1187 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #3 from Upstream Release Monitoring --- raphgro's scratch build of enki-15.05.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=1187 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 Raphael Groner changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=984560 Blocks|177841 (FE-NEEDSPONSOR) | Alias||enki Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #2 from Upstream Release Monitoring --- raphgro's scratch build of enki-15.05.0-1.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11821962 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 Raphael Groner changed: What|Removed |Added Depends On|984560 | --- Comment #1 from Raphael Groner --- *** Bug 984560 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=984560 [Bug 984560] Review Request: enki - Extensible text editor for programmers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1281876] Review Request: enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=1281876 --- Comment #2 from Upstream Release Monitoring --- raphgro's scratch build of enki-15.05.0-1.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11821962 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
