[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063

Jeremy Newton  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |DUPLICATE
  Flags|needinfo?(frap...@gmail.com |
   |)   |
Last Closed||2018-03-07 14:20:46



--- Comment #32 from Jeremy Newton  ---
It seems so, thanks!

*** This bug has been marked as a duplicate of bug 1503461 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063

Eric Sandeen  changed:

   What|Removed |Added

 CC||esand...@redhat.com
  Flags||needinfo?(frap...@gmail.com
   ||)



--- Comment #31 from Eric Sandeen  ---
Seems that xxhash (which contains xxsum) is now packaged and this can be
closed?

https://src.fedoraproject.org/rpms/xxhash

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #30 from Jeremy Newton  ---
(In reply to Francesco Frassinelli (frafra) from comment #29)
> (In reply to Jeremy Newton from comment #28)
> > Are you still interested in submitting this package?
> > 
> > I have specified a few concerns in the review notes above, please let me
> > know if you need any clarifications or you feel my judgement is incorrect.
> 
> I am sorry Jeremy, I do not have time for this review request now and I
> would be glad to see someone else continue with it; otherwise I will do it
> when I'll have more free time, sorry.

That's alright, thank you for letting me know. We can put the review on hold
for now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063

Francesco Frassinelli (frafra)  changed:

   What|Removed |Added

  Flags|needinfo?(frap...@gmail.com |
   |)   |



--- Comment #29 from Francesco Frassinelli (frafra)  ---
(In reply to Jeremy Newton from comment #28)
> Are you still interested in submitting this package?
> 
> I have specified a few concerns in the review notes above, please let me
> know if you need any clarifications or you feel my judgement is incorrect.

I am sorry Jeremy, I do not have time for this review request now and I would
be glad to see someone else continue with it; otherwise I will do it when I'll
have more free time, sorry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063

Jeremy Newton  changed:

   What|Removed |Added

  Flags||needinfo?(frap...@gmail.com
   ||)



--- Comment #28 from Jeremy Newton  ---
Are you still interested in submitting this package?

I have specified a few concerns in the review notes above, please let me know
if you need any clarifications or you feel my judgement is incorrect.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #27 from Jeremy Newton  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "GPL (v2 or later)", "Unknown or generated".
 6 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec..
>You should have a quick breakdown in a comment, like so:
>#xxhash is licensed as BSD and xxhsum is licensed as GPLv2+

[!]: %build honors applicable compiler flags or justifies otherwise.
>Is there a reason you're using CFLAGS="${CFLAGS:-%optflags}"?
>Also the build section seems odd, see below for how I think it should be 
>restructured.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
 names).
>The build section can be simified to:
cd cmake_unofficial
%cmake .
%make_build xxhash
cd ..
%make_build %{name}

>Or similar, note the use of the macros.
>As well, "make install DESTDIR=%{buildroot} -C cmake_unofficial" can be 
>replaced with "%make_install -C cmake_unofficial"
>and the following:
mkdir -p %{buildroot}%{_bindir}/
cp -p %{name} %{buildroot}%{_bindir}/
>can also be cleaned up to:
install -D %{name} %{buildroot}%{_bindir}/
>
>Also, if it makes packaging easier for you, you can also consider backporting 
>a fix via a patch from upstream to use cmake to build both xxhash and xxhsum 
>together via cmake and combine your prep sed commands with it:
>https://github.com/Cyan4973/xxHash/commit/43fa796c210f311bfedb061ee6c627ae227acec3

[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines
>I would think you should address the invalid-soname error via rpmlint.
>I can't give any comment on this as I haven't looked into it deep enough, but 
>there is some documentation on this issue on the wiki:
>https://fedoraproject.org/wiki/Common_Rpmlint_issues#invalid-soname
>
>Speaking of rpmlint output, can you also install and package the manpage 
>xxhsum.1?
>The other warnings can be ignored, but since you have the manpage, please use 
>it :)
>like so:
install -D %{name}.1 %{buildroot}%{_mandir}/man1/
>or something like that.

[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063

Jeremy Newton  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|alexjn...@gmail.com
  Flags||fedora-review?



--- Comment #26 from Jeremy Newton  ---
I'll take this

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #25 from Francesco Frassinelli (frafra)  ---
Ops, I forgot to link the koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17135592

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #24 from Francesco Frassinelli (frafra)  ---
Thank you Jeremy :)

It builds correctly, as expected :)
I also updated my Copr repository
https://copr.fedorainfracloud.org/coprs/frafra/duperemove/build/494305/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #23 from Jeremy Newton  ---
Its a new security policy. You have to run:

>kinit u...@fedoraproject.com

Replacing user with your fas username. It only lasts 24 hours before you have
to renew it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #22 from Francesco Frassinelli (frafra)  ---
Here we are!
https://frafra.fedorapeople.org/srpm/xxhsum.spec
https://frafra.fedorapeople.org/srpm/xxhsum-0.6.2-1.fc25.src.rpm

(still having to figure out why koji is still giving me a Kerberos error...)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #21 from Jeremy Newton  ---
Any progress on this? Or is it a dead review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063

James Hogarth  changed:

   What|Removed |Added

 Blocks|1244678 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1244678
[Bug 1244678] Review Request: duperemove - Tools for deduping file systems
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063

Francesco Frassinelli (frafra)  changed:

   What|Removed |Added

  Flags|needinfo?(frap...@gmail.com |
   |)   |



--- Comment #20 from Francesco Frassinelli (frafra)  ---
(In reply to James Hogarth from comment #19)
> Are you still interested in this? I'm getting a 404 on the srpm and the bug
> hasn't been touched in nearly two months (three by requester)?

I was waiting for a review and I didn't have much time to follow this package.
Here's the srpm: https://frafra.fedorapeople.org/copr/xxhsum-42-5.fc23.src.rpm

> If you aren't then I'd be interesting in picking up where this left of as
> I'd really like to get a packaged duperemove in Fedora.

Me too :)
I think we could co-maintain xxhash and duperemove. Please pick them up if you
have time to conclude this procedure (I'm quite busy for the next 2 weeks).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063

James Hogarth  changed:

   What|Removed |Added

 CC||frap...@gmail.com,
   ||james.hoga...@gmail.com
  Flags||needinfo?(frap...@gmail.com
   ||)



--- Comment #19 from James Hogarth  ---
Are you still interested in this? I'm getting a 404 on the srpm and the bug
hasn't been touched in nearly two months (three by requester)?

If you aren't then I'd be interesting in picking up where this left of as I'd
really like to get a packaged duperemove in Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #18 from Upstream Release Monitoring 
 ---
gil's scratch build of xxhsum-0.5.0-1.fc23.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=13096674

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063

Jonny Heggheim  changed:

   What|Removed |Added

 CC||heg...@gmail.com



--- Comment #17 from Jonny Heggheim  ---
gil cattaneo asked me to have a look at this ticket. I am just curious, should
we use the upstream cmake script? We spend more lines changing how it work,
instead of just calling GCC directly (only two files we need to compile)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063

James Hogarth  changed:

   What|Removed |Added

 Blocks||1244678




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1244678
[Bug 1244678] Review Request: duperemove - Tools for deduping file systems
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #16 from Francesco Frassinelli (frafra)  ---
Ahahah ok sorry :D I thought it could be some strange operator :D

rpmbuild fails: /usr/bin/ld: cannot find -lxxhash
I compiled libxxhash first (moving the code upward and adding "make xxhash" in
the subprocess) and now it seems to build correctly.

https://copr.fedoraproject.org/coprs/frafra/duperemove/build/154105/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063

Simone Caronni  changed:

   What|Removed |Added

 CC||negativ...@gmail.com



--- Comment #15 from Simone Caronni  ---
(In reply to Francesco Frassinelli (frafra) from comment #14)
> (In reply to gil cattaneo from comment #13)
> > can you change the spec file adding the above sed instructions, and to the
> > main package 
> > Requires:  libxxhash%{?_isa} = %{version}-%{release} ?
> 
> Sure!
> 
> $ LC_ALL=C rpmbuild -ba xxhsum.spec 
> error: line 12: Dependency tokens must begin with alpha-numeric, '_' or '/':
> Requires:   libxxhash(x86-64) = 42-5.fc23 ?
> 
> Thanks for your help :)

The last question mark on the "Requires" line was a question to you, not
actually something you need to put in the line :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #13 from gil cattaneo  ---
(In reply to gil cattaneo from comment #11)
> Maybe now the only problem is xxhash.c
> shared by libxxhash and xxhsum during build

i tried adding:
sed -i 's|xxhsum: xxhash.c xxhsum.c|xxhsum: xxhsum.c|' Makefile
sed -i 's|-o| -Lcmake_unofficial/ -lxxhash -o|' Makefile

testing result
$ LD_LIBRARY_PATH=~/rpmbuild/BUILD/xxHash-r42/cmake_unofficial ./xxhsum *
ef46db3751d8e999  cmake_unofficial
832d7b6430cfe4cb  LICENSE
4201ca2618ababe9  Makefile
861efbad96899cdf  README.md
ba57c4eee885089c  xxh32sum
ba57c4eee885089c  xxh64sum
0d8342021e5366c5  xxhash.c
c256b0cd7b86609b  xxhash.h
ba57c4eee885089c  xxhsum
bb7559fbd9461a75  xxhsum.c

$ LD_LIBRARY_PATH=~/rpmbuild/BUILD/xxHash-r42/cmake_unofficial ./xxhsum -bi1
xxhash.c 
./xxhsum  (32-bits little endian), by Yann Collet (Jan  6 2016) 
Loading xxhash.c...
XXH32   :  28922 ->  3402.4 MB/s   
XXH32 unaligned :  28921 ->  3205.6 MB/s   
XXH64   :  28922 ->  1326.4 MB/s   
XXH64 unaligned :  28921 ->  1288.2 MB/s


$ LD_LIBRARY_PATH=~/rpmbuild/BUILD/xxHash-r42/cmake_unofficial ./xxhsum -h
./xxhsum  (32-bits little endian), by Yann Collet (Jan  6 2016) 
Usage :
  ./xxhsum [arg] [filename]
When no filename provided, or - provided : use stdin as input
Arguments :
 -H# : hash selection : 0=32bits, 1=64bits (default 1)
 -b  : benchmark mode 
 -i# : number of iterations (benchmark mode; default 3)
 -h  : help (this text)

can you change the spec file adding the above sed instructions, and to the main
package 
Requires:  libxxhash%{?_isa} = %{version}-%{release} ?
regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #14 from Francesco Frassinelli (frafra)  ---
(In reply to gil cattaneo from comment #13)
> can you change the spec file adding the above sed instructions, and to the
> main package 
> Requires:  libxxhash%{?_isa} = %{version}-%{release} ?

Sure!

$ LC_ALL=C rpmbuild -ba xxhsum.spec 
error: line 12: Dependency tokens must begin with alpha-numeric, '_' or '/':
Requires:   libxxhash(x86-64) = 42-5.fc23 ?

Thanks for your help :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #9 from Francesco Frassinelli (frafra)  ---
Ok, thank you :) Here it comes:

Spec URL: https://frafra.fedorapeople.org/copr/xxhsum.spec
SRPM URL: https://frafra.fedorapeople.org/copr/xxhsum-42-3.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #8 from Upstream Release Monitoring 
 ---
frafra's scratch build of xxhsum-42-3.fc23.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12066749

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #11 from gil cattaneo  ---
Maybe now the only problem is xxhash.c
shared by libxxhash and xxhsum during build

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #12 from Upstream Release Monitoring 
 ---
frafra's scratch build of xxhsum-42-4.fc23.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12067362

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #10 from gil cattaneo  ---
Please, remove %license LICENSE in devel subpackage is not ncessary
and add 
%post -n libxxhash -p /sbin/ldconfig
%postun -n libxxhash -p /sbin/ldconfig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #2 from Upstream Release Monitoring 
 ---
frafra's scratch build of xxhsum-42-2.fc23.src.rpm for rawhide failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12066357

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #6 from gil cattaneo  ---
sorry for the noise forgot ...

Please remove rm -rf %{buildroot} in %install section

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #7 from gil cattaneo  ---
my bad, xxhsum is licensed as BSD and GPLv2+

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #3 from Upstream Release Monitoring 
 ---
frafra's scratch build of xxhsum-42-2.fc23.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12066418

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #4 from Francesco Frassinelli (frafra)  ---
It seems to work. Maybe it should be included under a different %package.

Spec URL: https://frafra.fedorapeople.org/copr/xxhsum.spec
SRPM URL: https://frafra.fedorapeople.org/copr/xxhsum-42-2.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #5 from gil cattaneo  ---
(In reply to Francesco Frassinelli (frafra) from comment #4)
> It seems to work. Maybe it should be included under a different %package.
> 
> Spec URL: https://frafra.fedorapeople.org/copr/xxhsum.spec
> SRPM URL: https://frafra.fedorapeople.org/copr/xxhsum-42-2.fc23.src.rpm

Yes, Thanks!

xxhsum is under GPLv2+ license instead libxxhash and licensed BSD
see the heder of the .c/.h files

Strange problem with cmake macros ...

can add to the spec file this part?

%package -n libxxhash
License:   BSD
Summary:   %{name} Shared Libraries

%description -n libxxhash
This package contains %{name} Shared Libraries

%package -n libxxhash-devel
License:   BSD
Summary:   Development files for libxxhash
Requires:  libxxhash%{?_isa} = %{version}-%{release}

%description -n libxxhash-devel
The libxxhash-devel package contains libraries and header files for
developing applications that use libxxhash

%files -n libxxhash
%{_libdir}/libxxhash.so.*
%license LICENSE

%files -n libxxhash-devel
%{_includedir}/xxhash.h
%{_libdir}/libxxhash.so
%license LICENSE

because xxhsum do not require libxxhash

thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063

Thomas Spura  changed:

   What|Removed |Added

 CC||toms...@fedoraproject.org
Summary|Review Request: Extremely   |Review Request: xxhsum -
   |fast hash algorithm |Extremely fast hash
   ||algorithm



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #1 from gil cattaneo  ---
HI
could you build libxxhash? is a BuildRequires for
https://bugzilla.redhat.com/show_bug.cgi?id=1270317

can you add this part in your spec file?

# Use ${LIB_INSTALL_DIR} instead of hardcoded lib in cmake file
sed -i 's|DESTINATION lib|DESTINATION ${LIB_INSTALL_DIR}|'
cmake_unofficial/CMakeLists.txt

%build

CFLAGS="${CFLAGS:-%optflags}"
#CPPFLAGS="CPPFLAGS"
export CFLAGS
(
 cd cmake_unofficial
 %{__cmake} -DCMAKE_INSTALL_PREFIX:PATH=%{_prefix}
-DLIB_INSTALL_DIR:PATH=%{_libdir}
)



%install
make install DESTDIR=%{buildroot} -C cmake_unofficial
find %{buildroot} -name '*.a' -delete
find %{buildroot} -name '*.la' -delete

Thanks in advance

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063

gil cattaneo  changed:

   What|Removed |Added

 Blocks||1270317




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1270317
[Bug 1270317] Review Request: lz4-java - LZ4 compression for Java
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review