[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1284132 Athmane Madjoudj changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |CANTFIX Last Closed||2018-02-24 15:07:53 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1284132 --- Comment #12 from Athmane Madjoudj --- Robert-André, thank you for catching that, it's definitively not a floss license (not listed by OSI either) [1]. I'll drop this request and ask upstream to change license (GH #32). [1] Linux foundation license tracking: https://github.com/spdx/license-list-data/blob/master/licenses.md -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1284132 --- Comment #11 from Robert-André Mauchin --- Also: 6. The Software may only be used in conjunction with products, projects, and other software distributed by the Company. Any standalone use of the Software, or use of the Software in conjunction with products, projects, or other software not authored or distributed by the Company - including third-party software that competes with the offerings of Company - is strictly prohibited and is a direct violation of the terms of the license. Definitively doesn't sound like free software to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1284132
--- Comment #10 from Robert-André Mauchin ---
- Nagios Open Software License Version 1.3:
Nagios Enterprises, LLC (the "Company") hereby grants, free of charge, to any
person, company, or legal entity (each a "User") obtaining a copy of this
software and associated documentation files (the "Software"), to deal in the
Software without restriction, including without limitation the rights to use,
copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the
Software (each a "Use"), and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
3. The Software may not be Forked. "Forking" and "to Fork" means to create or
distribute a product or a derivative work of the object or source code of the
Software under a new or different brand.
Both statements are contradictory and is really free software if it prevents
forking?
Also, NOSL is the shorthand for Netizen Open Source License, not Nagios Open
Software License.
- You should own /etc/nrdp
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/nrdp
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[?]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "Unknown or generated". 19 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/nrdp/review-nrdp/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /etc/nrdp
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/nrdp
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the pack
[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1284132 Athmane Madjoudj changed: What|Removed |Added Flags|needinfo?(athma...@gmail.co | |m) | --- Comment #9 from Athmane Madjoudj --- Thanks Xavier for the updates, I'm still interested in this pkg, unfortunately it still stuck in review queue. Updates: SPEC: https://athmane.fedorapeople.org/pkgs/nrdp.spec SRPM: https://athmane.fedorapeople.org/pkgs/nrdp-1.5.1-3.fc27.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25268468 Rpmlint: nrdp.src: W: spelling-error Summary(en_US) Nagios -> Adagios nrdp.src: W: spelling-error %description -l en_US Nagios -> Adagios nrdp.noarch: W: spelling-error Summary(en_US) Nagios -> Adagios nrdp.noarch: W: spelling-error %description -l en_US Nagios -> Adagios nrdp-client-php.noarch: W: no-documentation nrdp-client-php.noarch: W: no-manual-page-for-binary send_nrdp.php nrdp-client-python.noarch: W: no-documentation nrdp-client-python.noarch: W: no-manual-page-for-binary send_nrdp.py nrdp-client-shell.noarch: W: no-documentation nrdp-client-shell.noarch: W: no-manual-page-for-binary send_nrdp.sh 5 packages and 1 specfiles checked; 0 errors, 10 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1284132 Xavier Bachelot changed: What|Removed |Added CC||athma...@gmail.com Flags||needinfo?(athma...@gmail.co ||m) --- Comment #8 from Xavier Bachelot --- Yet another update, I'll wait for an answer before working more on this. Spec URL: https://www.bachelot.org/fedora/SPECS/nrdp.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/nrdp-1.5.1-2.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1284132 --- Comment #7 from Xavier Bachelot --- Here's a quick refresh of the spec to latest version. There is still some work to do and it's not been tested. Just adding it here for reference, feel free to take it if you wish to pursue the review. If you don't, I'll finish up the refresh and open a new review. Spec URL: https://www.bachelot.org/fedora/SPECS/nrdp.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/nrdp-1.5.1-1.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1284132 Xavier Bachelot changed: What|Removed |Added CC||xav...@bachelot.org --- Comment #6 from Xavier Bachelot --- Hi, Are you still interested in this review ? Can you please update to latest release ? Regards, Xavier -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1284132 --- Comment #5 from Upstream Release Monitoring --- athmane's scratch build of nrdp-0.20150122gitbd1b5d0-2.fc23.src.rpm for dist-6E-epel completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11936283 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1284132 --- Comment #4 from Upstream Release Monitoring --- athmane's scratch build of nrdp-0.20150122gitbd1b5d0-2.fc23.src.rpm for dist-5E-epel failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11936277 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1284132 --- Comment #3 from Athmane Madjoudj --- Updated version tag: Spec URL: https://athmane.fedorapeople.org/pkgs/nrdp.spec SRPM URL: https://athmane.fedorapeople.org/pkgs/nrdp-0.20150122gitbd1b5d0-2.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1284132 --- Comment #2 from Athmane Madjoudj --- rpmlint output: SPECS/nrdp.spec: W: no-%build-section SPECS/nrdp.spec: W: invalid-url Source0: nrdp-0.bd1b5d0git.tar.gz nrdp.noarch: W: spelling-error Summary(en_US) Nagios -> Adagios nrdp.noarch: W: spelling-error %description -l en_US Nagios -> Adagios nrdp.noarch: W: file-not-utf8 /usr/share/doc/nrdp/CHANGES.TXT nrdp-client-php.noarch: W: no-documentation nrdp-client-php.noarch: W: no-manual-page-for-binary send_nrdp.php nrdp-client-python.noarch: W: no-documentation nrdp-client-python.noarch: W: no-manual-page-for-binary send_nrdp.py nrdp-client-shell.noarch: W: no-documentation nrdp-client-shell.noarch: W: no-manual-page-for-binary send_nrdp.sh nrdp.src: W: spelling-error Summary(en_US) Nagios -> Adagios nrdp.src: W: spelling-error %description -l en_US Nagios -> Adagios nrdp.src: W: no-%build-section nrdp.src: W: invalid-url Source0: nrdp-0.bd1b5d0git.tar.gz 5 packages and 1 specfiles checked; 0 errors, 15 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1284132 --- Comment #1 from Upstream Release Monitoring --- athmane's scratch build of nrdp-0.bd1b5d0git-1.fc23.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11926780 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
