[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #39 from Fedora Update System  ---
borgbackup-1.0.3-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-04-12 05:38:41 |2016-06-08 01:20:26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #38 from Fedora Update System  ---
borgbackup-1.0.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-1b4d00dabe

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #37 from Fedora Update System  ---
borgbackup-1.0.3-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-1b4d00dabe

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #36 from Matthias Hensler  ---
borgbackup-1.0.2-1.el7.x86_64 is missing a dependency for python34-setuptools.

[root@cams ~]# yum install --enablerepo=epel-testing borgbackup
Loaded plugins: fastestmirror
Loading mirror speeds from cached hostfile
 * base: ftp.halifax.rwth-aachen.de
 * epel: mirror.de.leaseweb.net
 * epel-testing: mirror.imt-systems.com
 * extras: ftp.halifax.rwth-aachen.de
 * updates: ftp.halifax.rwth-aachen.de
Resolving Dependencies
--> Running transaction check
---> Package borgbackup.x86_64 0:1.0.2-1.el7 will be installed
--> Processing Dependency: python(abi) = 3.4 for package:
borgbackup-1.0.2-1.el7.x86_64
--> Processing Dependency: python34-msgpack >= 0.4.6 for package:
borgbackup-1.0.2-1.el7.x86_64
--> Processing Dependency: python34-llfuse for package:
borgbackup-1.0.2-1.el7.x86_64
--> Processing Dependency: /usr/bin/python3.4 for package:
borgbackup-1.0.2-1.el7.x86_64
--> Processing Dependency: libpython3.4m.so.1.0()(64bit) for package:
borgbackup-1.0.2-1.el7.x86_64
--> Processing Dependency: liblz4.so.1()(64bit) for package:
borgbackup-1.0.2-1.el7.x86_64
--> Running transaction check
---> Package lz4.x86_64 0:r131-1.el7 will be installed
---> Package python34.x86_64 0:3.4.3-4.el7 will be installed
---> Package python34-libs.x86_64 0:3.4.3-4.el7 will be installed
---> Package python34-llfuse.x86_64 0:1.0-1.el7 will be installed
--> Processing Dependency: libfuse.so.2(FUSE_2.9)(64bit) for package:
python34-llfuse-1.0-1.el7.x86_64
--> Processing Dependency: libfuse.so.2(FUSE_2.8)(64bit) for package:
python34-llfuse-1.0-1.el7.x86_64
--> Processing Dependency: libfuse.so.2(FUSE_2.6)(64bit) for package:
python34-llfuse-1.0-1.el7.x86_64
--> Processing Dependency: libfuse.so.2(FUSE_2.5)(64bit) for package:
python34-llfuse-1.0-1.el7.x86_64
--> Processing Dependency: libfuse.so.2(FUSE_2.4)(64bit) for package:
python34-llfuse-1.0-1.el7.x86_64
--> Processing Dependency: libfuse.so.2()(64bit) for package:
python34-llfuse-1.0-1.el7.x86_64
---> Package python34-msgpack.x86_64 0:0.4.7-3.el7 will be installed
--> Running transaction check
---> Package fuse-libs.x86_64 0:2.9.2-6.el7 will be installed
--> Finished Dependency Resolution

Dependencies Resolved

=
 PackageArch   
 Version   
Repository 
Size
=
Installing:
 borgbackup x86_64 
 1.0.2-1.el7   
epel-testing   
   393 k
Installing for dependencies:
 fuse-libs  x86_64 
 2.9.2-6.el7   
base   
93 k
 lz4x86_64 
 r131-1.el7
epel   
70 k
 python34   x86_64 
 3.4.3-4.el7   
epel   
49 k
 python34-libs  x86_64 
 3.4.3-4.el7   
epel   
   6.7 M
 python34-llfusex86_64 
 1.0-1.el7 
epel   
   364 k
 python34-msgpack   x86_64 
 0.4.7-3.el7   
 

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #35 from Fedora Update System  ---
borgbackup-1.0.2-1.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-016b5b1678

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #34 from Fedora Update System  ---
borgbackup-1.0.0-2.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #33 from Fedora Update System  ---
borgbackup-1.0.2-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-016b5b1678

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #32 from Fedora Update System  ---
borgbackup-1.0.0-2.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-04-12 05:38:41



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #31 from Fedora Update System  ---
borgbackup-1.0.0-2.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-05a0787f3c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #30 from Fedora Update System  ---
borgbackup-1.0.0-2.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e9bd5cf00b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #29 from Fedora Update System  ---
borgbackup-1.0.0-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-05a0787f3c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #28 from Fedora Update System  ---
borgbackup-1.0.0-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e9bd5cf00b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #27 from Fedora Update System  ---
borgbackup-1.0.0-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-bd1515f44d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #26 from Fedora Update System  ---
borgbackup-1.0.0-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4ffaff98a7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #25 from Fedora Update System  ---
borgbackup-1.0.0-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-bd1515f44d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #24 from Fedora Update System  ---
borgbackup-1.0.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4ffaff98a7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #23 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/borgbackup

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #22 from Benjamin Pereto  ---
Thank you for you support.

@Orion, thank you for the sponsoring.
I missed to look into bodhi for updates.

@felix, I will try the custom definition, thanks for your participation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #21 from Felix Schwarz  ---
Of course you're right about Cython - I forgot that I built that locally (which
was pretty painless).

The macro should be fixable with this custom defintion:
  %{!?python3_pkgversion:%global python3_pkgversion 3}

However I think focussing on Fedora first is probably the right thing. I
suggest you update the package to 1.0, get a new review (which should be
simple). In parallel you should try to get sponsored. I assume you know
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
already? If you like I can introduce you to a few sponsors I worked with in the
past.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837

Orion Poplawski  changed:

   What|Removed |Added

 CC||or...@cora.nwra.com
 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #20 from Orion Poplawski  ---
(In reply to Benjamin Pereto from comment #19)
> I'm still interested in maintaining the package, but as you said, I need a
> sponsor.

I've sponsored you.

> The mentioned FPC above is still not through, but progress were made. the
> python34-setuptools and python3-rpm-macros was added to EPEL7.
> 
> Results of my try's building against epel7 showed missing dependencies:
> Error: No Package found for python34-Cython

In testing: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-a140c12508

> Sadly, the updated python3 macros are not added to buildroot in F23, and the
> build is failing with a unified spec file.
> 
> https://copr.fedorainfracloud.org/coprs/bpereto/borgbackup/build/173284/

This is coming: https://bodhi.fedoraproject.org/updates/FEDORA-2016-dcddcc1f06

In fact, I think I'll add buildroot overrides soon so we can test building in
koji.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #19 from Benjamin Pereto  ---
I'm still interested in maintaining the package, but as you said, I need a
sponsor.
There are other packages which I can prepare an keep this as reference.
So if someone interested of the packagers group, he can take this packge.

The mentioned FPC above is still not through, but progress were made. the
python34-setuptools and python3-rpm-macros was added to EPEL7.

Results of my try's building against epel7 showed missing dependencies:
Error: No Package found for python34-Cython
Error: No Package found for python34-pytest-cov
Error: No Package found for python34-sphinx
Error: No Package found for python34-sphinx_rtd_theme

If you remove docs + test and its requirements, there is only python34-Cython,
which is needed for the performance critical part of borgbackup.
We/I will look what is needed to bring it to epel.

Sadly, the updated python3 macros are not added to buildroot in F23, and the
build is failing with a unified spec file.

https://copr.fedorainfracloud.org/coprs/bpereto/borgbackup/build/173284/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #18 from Felix Schwarz  ---
Benjamin: What's your plan with this package? Seems like the review is approved
but you still need a sponsor, right? Are you still interested in maintaining
the package?

Also you updated the package after it was already approved. Even though I think
the changes are ok, I guess we should see a new formal review for it... While
we're at it could you upgrade the spec to 1.0.0 ?

I rebuilt your borgbackup on EL7 with a few changes (upgraded to 1.0.0 though)
and it seems to work fine (didn't build the docs, no coverage tests). So that's
a thing you might want to look into.

Also I found two missing requires (at least on EL7): It needs
python34-setuptools and python34-llfuse (the latter is only a BuildRequires at
the moment).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #15 from Peter Meier  ---
There is also a packaging draft for python 3 on EPEL 7:
https://fedoraproject.org/wiki/PackagingDrafts:Python3EPEL

Would be awesome to have it there...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #16 from Benjamin Pereto  ---
Hi,

thanks for you suggestions.

Spec URL: https://data.sandchaschte.ch/pub/fedora/borgbackup.spec
SRPM URL:
https://data.sandchaschte.ch/pub/fedora/borgbackup-0.29.0-3.fc23.src.rpm

Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12381070
F23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12381074

I changed the url and added the buildrequires sphinx_rtd_theme.
Thank you Peter, now its working for f23.

I also like to see it in EPEL 7, but it looks like not everything is in place
for python34 to build borgbackup against epel:

https://bugzilla.redhat.com/show_bug.cgi?id=1249039#c1
https://fedorahosted.org/fpc/ticket/567

Borgbackup has alot of dependencies and needs some work to bring it to epel,
after the Packaging Guidlines passed the FPC.

Would be awesome.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #17 from Upstream Release Monitoring 
 ---
bpereto's scratch build of borgbackup-0.29.0-3.fc23.src.rpm for f23 completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12381074

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #14 from Tadej Janež  ---
Hi Benjamin,

thanks for packaging up BorgBackup!

I have two short comments/suggestions:

1. Change the URL to https://borgbackup.readthedocs.org/ as it is deemed as the
project's main web site (https://borgbackup.readthedocs.org/en/stable/#links).

2. For making it available in EPEL 7, you can use python34, which is the
official Python 3 package for EPEL 7
(https://apps.fedoraproject.org/packages/python34).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837



--- Comment #13 from Peter Meier  ---
Adding python3-sphinx_rtd_theme to the python3-sphinx BuildRequires makes it
also build on F23, otherwise I got the following error:

+ make -C docs SPHINXBUILD=sphinx-build-3 man
make: Entering directory '/builddir/build/BUILD/borgbackup-0.29.0/docs'
sphinx-build-3 -b man -d _build/doctrees   . _build/man
Making output directory...
Running Sphinx v1.2.3

Exception occurred:
  File "conf.py", line 99, in 
import sphinx_rtd_theme
ImportError: No module named 'sphinx_rtd_theme'
The full traceback has been saved in /tmp/sphinx-err-k0mqe8kx.log, if you want
to report the issue to the developers.
Please also report this if it was a user error, so that a better error message
can be provided next time.
A bug report can be filed in the tracker at
. Thanks!
Makefile:112: recipe for target 'man' failed
make: Leaving directory '/builddir/build/BUILD/borgbackup-0.29.0/docs'
make: *** [man] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.CsGvEV (%build)
Bad exit status from /var/tmp/rpm-tmp.CsGvEV (%build)

Thanks a lot for the packaging, I was just starting the same effort.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837

Benjamin Pereto  changed:

   What|Removed |Added

Summary|Review Request: |Review Request: borgbackup
   |python-borgbackup - A   |- A deduplicating backup
   |deduplicating backup|program
   |program |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287837] Review Request: borgbackup - A deduplicating backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287837

Antonio Trande  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #12 from Antonio Trande  ---
Package approved.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

--> fedora-review bug.

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 102 files have
 unknown license. Detailed output of licensecheck in
 /home/sagitter/1287837-borgbackup/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib64/python3.5/site-packages,
 /usr/lib64/python3.5
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/python3.5/site-
 packages, /usr/lib64/python3.5
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: