[Bug 1288100] Review Request: ConsoleImageViewer - Terminal image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1288100 --- Comment #5 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/ConsoleImageViewer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1288100] Review Request: ConsoleImageViewer - Terminal image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1288100 jiri vanek changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1288100] Review Request: ConsoleImageViewer - Terminal image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1288100 Omair Majid changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1288100] Review Request: ConsoleImageViewer - Terminal image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1288100 jiri vanek changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #3 from jiri vanek --- Spec URL: https://jvanek.fedorapeople.org/ConsoleImageViewer/v2/console-image-viewer.spec SRPM URL: https://jvanek.fedorapeople.org/ConsoleImageViewer/v2/console-image-viewer-1.2-1.fc22.src.rpm RPM URL: https://jvanek.fedorapeople.org/ConsoleImageViewer/v2/console-image-viewer-1.2-1.fc22.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1288100] Review Request: ConsoleImageViewer - Terminal image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1288100 --- Comment #2 from jiri vanek --- Hi Omair! Thank you fro review! (In reply to Omair Majid from comment #1) > Package Review > == > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > > Issues: > === > - Missing Requires on jpackage-utils. You mean javapackages-tools, right? javapackages-tools added. TY! > - Missing Dist tag. fixed > - The actual license seems to be "MIT" instead of "BSD". Fix the > license field. Hmm.. are you sure? Well.. You know them better. Fixed. > - Package name should be in lower case. renamed > - Deletion of class files and jars should be in %prep, not %build. fixed > > Optional: > - Include a LICENSE file upstream and package it. Not followed for now. As it is one class project, The license in header looks ok for now. Sorry. > [!]: Rpmlint is run on all rpms the build produces. > Note: There are rpmlint messages (see attachment). I'm not able to silence the setup output.I think it is caused by way ho github is packing releases. But I added man page at least... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1288100] Review Request: ConsoleImageViewer - Terminal image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1288100
--- Comment #1 from Omair Majid ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Missing Requires on jpackage-utils.
- Missing Dist tag.
- The actual license seems to be "MIT" instead of "BSD". Fix the
license field.
- Package name should be in lower case.
- Deletion of class files and jars should be in %prep, not %build.
Optional:
- Include a LICENSE file upstream and package it.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 6 files have
unknown license. Detailed output of licensecheck in
/home/omajid/temp/1288100-ConsoleImageViewer/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[!]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
Maven:
[-]: If package contains pom.xml files install it (including metadata) even
when building with ant
[x]: Old add_to_maven_depmap macro is not being used
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package
[Bug 1288100] Review Request: ConsoleImageViewer - Terminal image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1288100 Omair Majid changed: What|Removed |Added CC||oma...@redhat.com Assignee|nob...@fedoraproject.org|oma...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1288100] Review Request: ConsoleImageViewer - Terminal image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1288100 jiri vanek changed: What|Removed |Added Summary|Review Request: -|Terminal image viewer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
