[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-01-01 08:37:29 |2016-01-28 19:23:10



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169



--- Comment #15 from Fedora Update System  ---
ccdciel-0.2.0-10.20160105svn.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
ccdciel-0.2.0-10.20160105svn.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-132a0dbc91

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169



--- Comment #13 from Fedora Update System  ---
ccdciel-0.2.0-10.20160105svn.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-132a0dbc91

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169

Mattia Verga  changed:

   What|Removed |Added

 Status|CLOSED  |NEW
 Resolution|NOTABUG |---
   Keywords||Reopened



--- Comment #5 from Mattia Verga  ---
Spec URL: http://coolbits.it/fedora/ccdciel.spec
SRPM URL: http://coolbits.it/fedora/ccdciel-0.2.0-9.20160105svn.fc23.src.rpm

Libpasastro is now in Fedora repositories, so I can reopen this review request.
Please note that CCDciel requires libpasastro for full functionality, but rpm 
doesn't find this requires automatically, so I need to explicit require it in
.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169



--- Comment #9 from Mattia Verga  ---
Spec URL: http://coolbits.it/fedora/ccdciel.spec
SRPM URL: http://coolbits.it/fedora/ccdciel-0.2.0-10.20160105svn.fc23.src.rpm

Sorry, wrong revision number after cut/paste...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169



--- Comment #8 from Mattia Verga  ---
Spec URL: http://coolbits.it/fedora/ccdciel.spec
SRPM URL: http://coolbits.it/fedora/ccdciel-0.2.0-9.20160105svn.fc23.src.rpm

* Sat Jan 16 2016 Mattia Verga  - 0.2.0-10.20160105svn
- Moved tests into %%check
- Added architecture to libpasastro dependency
- Fixed wrong FSF address in sources (and reported upstream)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169

Christian Dersch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lupi...@mailbox.org
   Assignee|nob...@fedoraproject.org|lupi...@mailbox.org
  Flags||fedora-review?



--- Comment #6 from Christian Dersch  ---
Taken

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169



--- Comment #10 from Upstream Release Monitoring 
 ---
mattia's scratch build of ccdciel-0.2.0-10.20160105svn.fc23.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12574929

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169



--- Comment #7 from Christian Dersch  ---
Package already looks good, but needs some small fixes before i'll approve:


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

===> False positive, is dnf debuginfo install bug

- Move tests to %check
- Please add architecture to libpasastro dependency


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2 or later)", "GPL (with incorrect FSF address)", "GPL
 (v3 or later)", "Unknown or generated", "BSD (3 clause)", "GPL (v2 or
 later) (with incorrect FSF address)". 141 files have unknown license.
 Detailed output of licensecheck in
 /home/review/ccdciel/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.

===> Please add architecture to libpasastro dependency
(Requires: libpasastro%{?_isa})

[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in ccdciel
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.

===> For fpc packages we need it => is fine

[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.

===> Different for fpc like, commented in spec => fine

[-]: If the source package does not include license text(s) as a separate
 file 

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169

Christian Dersch  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #11 from Christian Dersch  ---
Fine now, APPROVED and thank you very much for packaging astronomy stuff!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169

Mattia Verga  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2016-01-01 08:37:29



--- Comment #4 from Mattia Verga  ---
I'm closing this for the moment: all libraries included in Ccdciel are being
ported in a separate package (libpasastro) that is now under review.

I will reopen this review when libpasastro will be ready and I can make major
changes to Ccdciel.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169

Mattia Verga  changed:

   What|Removed |Added

 Blocks||115 (Astronomy-SIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=115
[Bug 115] Astronomy SIG - review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169



--- Comment #2 from Mattia Verga  ---
Spec URL: http://coolbits.it/files/ccdciel.spec
SRPM URL: http://coolbits.it/files/ccdciel-0.2.0-5.20151216svn.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169



--- Comment #3 from Mattia Verga  ---
Spec URL: http://coolbits.it/fedora/ccdciel.spec
SRPM URL: http://coolbits.it/fedora/ccdciel-0.2.0-5.20151216svn.fc23.src.rpm

Sorry, broken link, now it's ok.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169



--- Comment #1 from Upstream Release Monitoring 
 ---
mattia's scratch build of ccdciel-0.2.0-3.20151214svn.fc23.src.rpm for f24
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12180678

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review