[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040

Susi Lehtola  changed:

   What|Removed |Added

 Blocks|505154 (FE-SCITECH) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #23 from Fedora Update System  ---
tng-1.7.8-3.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #22 from Fedora Update System  ---
tng-1.7.8-3.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-03-26 13:59:26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #17 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Antonio Trande from comment #15)
> Package approved.

Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #20 from Fedora Update System  ---
tng-1.7.8-3.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-526243015e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #14 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Antonio Trande from comment #13)
> (In reply to Dominik 'Rathann' Mierzejewski from comment #12)
> > (In reply to Antonio Trande from comment #11)
> > > Package Review
> > > ==
> > > 
> > > Legend:
> > > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> > > [ ] = Manual review needed
> > > 
> > >  Issues 
> > > 
> > > - Please, use %{_pkgdocdir} or %doc macro for documentation files.
> > 
> > I don't understand what you mean here. The spec already does this:
> > %files doc
> > %{_pkgdocdir}
> > 
> > 
> 
> -doc sub-package should provide its own license file;

Right, I'll add it, though I think it's trivial enough to do upon import.

> inside it, I guess you can tag all documentation with %doc without making a
> %{buildroot}%{_defaultdocdir}/tng directory.

No, because then it'll end up in /usr/share/doc/tng-doc. Right now it installs
nicely into /usr/share/doc/tng.

If there's nothing else, please approve.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #12 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Antonio Trande from comment #11)
> Package Review
> ==
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
> 
>  Issues 
> 
> - Please, use %{_pkgdocdir} or %doc macro for documentation files.

I don't understand what you mean here. The spec already does this:
%files doc
%{_pkgdocdir}


> - Include zlib license with License tag.

Done.

Spec URL: https://rathann.fedorapeople.org/review/tng/tng.spec
SRPM URL: https://rathann.fedorapeople.org/review/tng/tng-1.7.8-3.fc23.src.rpm

* Wed Mar 15 2016 Dominik Mierzejewski  1.7.8-3
- add zlib to license list

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #18 from Fedora Update System  ---
tng-1.7.8-3.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d5397411e9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #13 from Antonio Trande  ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #12)
> (In reply to Antonio Trande from comment #11)
> > Package Review
> > ==
> > 
> > Legend:
> > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> > [ ] = Manual review needed
> > 
> >  Issues 
> > 
> > - Please, use %{_pkgdocdir} or %doc macro for documentation files.
> 
> I don't understand what you mean here. The spec already does this:
> %files doc
> %{_pkgdocdir}
> 
> 

-doc sub-package should provide its own license file; inside it, I guess you
can tag all documentation with %doc without making a
%{buildroot}%{_defaultdocdir}/tng directory.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #16 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/tng

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040

Antonio Trande  changed:

   What|Removed |Added

 CC|anto.tra...@gmail.com   |
  Flags|fedora-review?  |fedora-review+



--- Comment #15 from Antonio Trande  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #19 from Fedora Update System  ---
tng-1.7.8-3.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-526243015e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #21 from Fedora Update System  ---
tng-1.7.8-3.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d5397411e9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #11 from Antonio Trande  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

 Issues 

- Please, use %{_pkgdocdir} or %doc macro for documentation files.

- Include zlib license with License tag.

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated", "zlib/libpng". 128
 files have unknown license. Detailed output of licensecheck in
 /home/sagitter/FedoraReview/1292040-tng/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in tng-
 devel , tng-doc , tng-debuginfo
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: SourceX tarball generation or download is documented.
 Note: Package contains tarball without URL, check comments

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #10 from Dominik 'Rathann' Mierzejewski  ---
Spec URL: https://rathann.fedorapeople.org/review/tng/tng.spec
SRPM URL: https://rathann.fedorapeople.org/review/tng/tng-1.7.8-2.fc23.src.rpm

* Tue Mar 15 2016 Dominik Mierzejewski  1.7.8-2
- make devel subpackage depend on arched main package
- move docs to -doc subpackage

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #9 from Antonio Trande  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 2355200 bytes in 144 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

- 'Requires: %{name} = %{version}-%{release}' in -devel sub-package is not
arched

- Diff spec file in url and in SRPM
-
--- /home/sagitter/FedoraReview/1292040-tng/srpm/tng.spec2016-02-24
11:50:16.394392162 +0100
+++ /home/sagitter/FedoraReview/1292040-tng/srpm-unpacked/tng.spec   
2015-12-27 01:11:16.0 +0100
@@ -1,3 +1,2 @@
-# compression tests take up 3GB of disk space and a lot of time
 %global compression_tests 0


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated", "zlib/libpng". 128
 files have unknown license. Detailed output of licensecheck in
 /home/sagitter/FedoraReview/1292040-tng/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in 

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040

Antonio Trande  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags|needinfo?(anto.trande@gmail |fedora-review?
   |.com)   |



--- Comment #8 from Antonio Trande  ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #7)
> Sorry for missing that review. Do you have any other packages ready for
> review? I need this package so that I can unbundle tng from gromacs.

No need.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

  Flags||needinfo?(anto.trande@gmail
   ||.com)



--- Comment #7 from Dominik 'Rathann' Mierzejewski  ---
Sorry for missing that review. Do you have any other packages ready for review?
I need this package so that I can unbundle tng from gromacs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #6 from Dominik 'Rathann' Mierzejewski  ---
Sure, I'll try to review yours before the end of this week.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040

Antonio Trande  changed:

   What|Removed |Added

 CC||anto.tra...@gmail.com



--- Comment #5 from Antonio Trande  ---
Review swap?
https://bugzilla.redhat.com/show_bug.cgi?id=1292392

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #4 from Dominik 'Rathann' Mierzejewski  ---
Spec URL: https://rathann.fedorapeople.org/review/tng/tng.spec
SRPM URL: https://rathann.fedorapeople.org/review/tng/tng-1.7.8-1.fc24.src.rpm

* Sat Dec 26 2015 Dominik Mierzejewski  1.7.8-1
- update to 1.7.8
- drop upstream'd patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #3 from Dominik 'Rathann' Mierzejewski  ---
rpmlint output:

tng-devel.x86_64: W: only-non-binary-in-usr-lib
tng.x86_64: W: shared-lib-calls-exit /usr/lib64/libtng_io.so.1.7.7
exit@GLIBC_2.2.5
tng.src: W: strange-permission tng-mktarball.sh 755
tng.src:17: W: unversioned-explicit-provides bundled(md5-deutsch)
tng.src: W: invalid-url Source0: tng-1.7.7.tar.xz
4 packages and 0 specfiles checked; 0 errors, 5 warnings.

I'll talk to upstream about that exit call.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 Blocks||505154 (FE-SCITECH)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review