[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149
Bug 1292149 depends on bug 1292429, which changed state.

Bug 1292429 Summary: Review Request: nodejs-memoizee - Memoize/cache function 
results
https://bugzilla.redhat.com/show_bug.cgi?id=1292429

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149
Bug 1292149 depends on bug 1292415, which changed state.

Bug 1292415 Summary: Review Request: nodejs-timers-ext - Timers extension
https://bugzilla.redhat.com/show_bug.cgi?id=1292415

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149
Bug 1292149 depends on bug 1292413, which changed state.

Bug 1292413 Summary: Review Request: nodejs-es6-iterator - Iterator abstraction 
based on ES6 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1292413

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149
Bug 1292149 depends on bug 1292413, which changed state.

Bug 1292413 Summary: Review Request: nodejs-es6-iterator - Iterator abstraction 
based on ES6 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1292413

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149
Bug 1292149 depends on bug 1292416, which changed state.

Bug 1292416 Summary: Review Request: nodejs-es5-ext - ECMAScript 5 extensions 
and ES6 shims
https://bugzilla.redhat.com/show_bug.cgi?id=1292416

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149



--- Comment #5 from Patrick Uiterwijk  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/nodejs-cli-color

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149

Parag AN(पराग)  changed:

   What|Removed |Added

 Blocks||1294078




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1294078
[Bug 1294078] Review Request: nodejs-json-diff - JSON diff
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149

Tom Hughes  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Tom Hughes  ---
It needs BRs on the dependencies when tests are enabled, and there's a whole
circular dependency thing with the tests that might warrant a comment but other
than that it's fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149



--- Comment #2 from Jared Smith  ---
All dependencies are now in Rawhide, so this review should be able to move
forward.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149



--- Comment #3 from Tom Hughes  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 48 files have
 unknown license. Detailed output of licensecheck in /home/tom/1292149
 -nodejs-cli-color/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 51200 bytes in 7 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =

Generic:
[!]: Rpmlint is run on all installed packages.
 Note: Mock build failed
 See: 

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149
Bug 1292149 depends on bug 1292416, which changed state.

Bug 1292416 Summary: Review Request: nodejs-es5-ext - ECMAScript 5 extensions 
and ES6 shims
https://bugzilla.redhat.com/show_bug.cgi?id=1292416

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149
Bug 1292149 depends on bug 1292424, which changed state.

Bug 1292424 Summary: Review Request: nodejs-d - Property descriptor factory
https://bugzilla.redhat.com/show_bug.cgi?id=1292424

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149
Bug 1292149 depends on bug 1292413, which changed state.

Bug 1292413 Summary: Review Request: nodejs-es6-iterator - Iterator abstraction 
based on ES6 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1292413

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149
Bug 1292149 depends on bug 1292413, which changed state.

Bug 1292413 Summary: Review Request: nodejs-es6-iterator - Iterator abstraction 
based on ES6 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1292413

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149
Bug 1292149 depends on bug 1292424, which changed state.

Bug 1292424 Summary: Review Request: nodejs-d - Property descriptor factory
https://bugzilla.redhat.com/show_bug.cgi?id=1292424

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149
Bug 1292149 depends on bug 1292416, which changed state.

Bug 1292416 Summary: Review Request: nodejs-es5-ext - ECMAScript 5 extensions 
and ES6 shims
https://bugzilla.redhat.com/show_bug.cgi?id=1292416

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149
Bug 1292149 depends on bug 1292424, which changed state.

Bug 1292424 Summary: Review Request: nodejs-d - Property descriptor factory
https://bugzilla.redhat.com/show_bug.cgi?id=1292424

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149

Jared Smith  changed:

   What|Removed |Added

 Depends On||1292429, 1292424, 1292416




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1292416
[Bug 1292416] Review Request: nodejs-es5-ext - ECMAScript 5 extensions and
ES6 shims
https://bugzilla.redhat.com/show_bug.cgi?id=1292424
[Bug 1292424] Review Request: nodejs-d - Property descriptor factory
https://bugzilla.redhat.com/show_bug.cgi?id=1292429
[Bug 1292429] Review Request: nodejs-memoizee -- Memoize/cache function
results
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149

Jared Smith  changed:

   What|Removed |Added

 Depends On||1292415




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1292415
[Bug 1292415] Review Request: nodejs-timers-ext - Timers extension
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149

Jared Smith  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review