[Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292287

Piotr Popieluch  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-05-27 17:00:05



--- Comment #7 from Piotr Popieluch  ---
in f24 and rawhide

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292287
Bug 1292287 depends on bug 1292293, which changed state.

Bug 1292293 Summary: Review Request: nodejs-is-relative - Returns `true` if the 
path appears to be relative
https://bugzilla.redhat.com/show_bug.cgi?id=1292293

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292287
Bug 1292287 depends on bug 1292295, which changed state.

Bug 1292295 Summary: Review Request: nodejs-is-windows - Returns true if the 
platform is windows
https://bugzilla.redhat.com/show_bug.cgi?id=1292295

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292287



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/nodejs-is-absolute

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292287



--- Comment #4 from Jared Smith  ---
Updated.

Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-is-absolute/nodejs-is-absolute.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-is-absolute/nodejs-is-absolute-0.2.3-3.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292287

Tom Hughes  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Tom Hughes  ---
That looks good now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292287

Tom Hughes  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||t...@compton.nu
   Assignee|nob...@fedoraproject.org|t...@compton.nu
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292287



--- Comment #3 from Tom Hughes  ---
As Piotr said it doesn't really use ava so get rid of that BR and comment and
enable the tests. It also needs BRs on is-relative and is-windows for the
tests.

The only ohter thing is that test.js is getting included in the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292287



--- Comment #2 from Tom Hughes  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 4 files have
 unknown license. Detailed output of licensecheck in /home/tom/1292287
 -nodejs-is-absolute/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =

Generic:
[x]: Rpmlint is run on all installed packages.
 Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
---
Checking: 

[Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292287

Piotr Popieluch  changed:

   What|Removed |Added

 CC||piotr1...@gmail.com



--- Comment #1 from Piotr Popieluch  ---
Test don't seem to require ava but mocha, could you enable them?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292287
Bug 1292287 depends on bug 1292295, which changed state.

Bug 1292295 Summary: Review Request: nodejs-is-windows - Returns true if the 
platform is windows
https://bugzilla.redhat.com/show_bug.cgi?id=1292295

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292287
Bug 1292287 depends on bug 1292295, which changed state.

Bug 1292295 Summary: Review Request: nodejs-is-windows - Returns true if the 
platform is windows
https://bugzilla.redhat.com/show_bug.cgi?id=1292295

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292287

Jared Smith  changed:

   What|Removed |Added

 Depends On||1292295




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1292295
[Bug 1292295] Review Request: nodejs-is-windows - Returns true if the
platform is windows
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292287

Jared Smith  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292287

Jared Smith  changed:

   What|Removed |Added

 Depends On||1292293




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1292293
[Bug 1292293] Review Request: nodejs-is-relative - Returns `true` if the
path appears to be relative
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review