[Bug 1293630] Review Request: wallch - A wallpaper changer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293630

Jakub Jelen  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(jje...@redhat.com |
   |)   |
Last Closed||2020-07-13 11:12:46



--- Comment #10 from Jakub Jelen  ---
I no longer care for this package and as it looks like the upstream is dead
too, lets drop it.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

needinfo canceled: [Bug 1293630] Review Request: wallch - A wallpaper changer

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Jakub Jelen  has canceled Package Review
's request for Jakub Jelen
's needinfo:
Bug 1293630: Review Request: wallch - A wallpaper changer
https://bugzilla.redhat.com/show_bug.cgi?id=1293630



--- Comment #10 from Jakub Jelen  ---
I no longer care for this package and as it looks like the upstream is dead
too, lets drop it.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1293630] Review Request: wallch - A wallpaper changer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293630



--- Comment #8 from philip.worr...@googlemail.com ---
Oh I didn't see that page.

But remember the patch will only use wikipedia directly IIF the imageurl does
not have an entry for today, so like a fallback case to prevent raising an
error to the user. For today for example, its using imageurl because links were
added for the 18th and 19th of May.

Writing the script should be easy assuming there is somewhere to host it and
add a cronjob. Let me know if you need help with the former.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1293630] Review Request: wallch - A wallpaper changer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293630

Jakub Jelen  changed:

   What|Removed |Added

  Flags|needinfo?(jje...@redhat.com |
   |)   |



--- Comment #7 from Jakub Jelen  ---
Thank you for the patch. It looks nice, but I believe loading images directly
from wikipedia is exactly the case the authors are trying to avoid, as
described in the POTD page [1].

Problem is that the method of downloading the image once and uploading it to
imgur is probably not as reliable as expected and this can not be solved by the
end-user application.

As another possibility, would be to run another mirror with independent way of
downloading and re-uploading pictures, but it would require also having the
backend part opensource and run it in some other service (I can put it on mine
VPS or somewhere else). I will propose this to the authors, but I am not sure
when I will get a time to do that. It will depend on the complexity of the task
itself.

Anyway POTD is now working fine.

[1] http://melloristudio.com/wallch/picture_of_the_day

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1293630] Review Request: wallch - A wallpaper changer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293630



--- Comment #6 from philip.worr...@googlemail.com ---
Upstream bug: https://bugs.launchpad.net/wallpaper-changer/+bug/1553897

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1293630] Review Request: wallch - A wallpaper changer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293630

philip.worr...@googlemail.com changed:

   What|Removed |Added

 CC||jje...@redhat.com
  Flags||needinfo?(jje...@redhat.com
   ||)



--- Comment #5 from philip.worr...@googlemail.com ---
Hi Jakub,

I tried the new version but im still having problems getting the picture of the
day.

After going through the code the potd are scraped from a dropbox file. the
problem is that if there is no entry for todays date (as it is showing now
https://dl.dropboxusercontent.com/u/257493884/potd) then it will complain there
is no image.

Please see attached patch which adds functions to fetch the potd directly from
wikipedia if the dropbox link is out-of-date i.e. no entry for today.

Also as i dont have a LP account please feel free to send this upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1293630] Review Request: wallch - A wallpaper changer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293630



--- Comment #4 from philip.worr...@googlemail.com ---
Created attachment 1158537
  --> https://bugzilla.redhat.com/attachment.cgi?id=1158537=edit
wallch wikipedia-direct

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1293630] Review Request: wallch - A wallpaper changer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293630



--- Comment #3 from Jakub Jelen  ---
Hello,
thank you for comments. I didn't move on with the package since submitting
review request, but I was using it on my own from copr (with more or less
problems). I also contributed the change with conditionally removed Unity and
qt4 compatibility (before I build it with qt5), which apply on the master well:
https://code.launchpad.net/~wallch/wallpaper-changer/trunk/+activereviews

But it didn't get through to the "master" yet. They also get to official Ubuntu
repositories and have a lot of bugs there. I built latest revision from bzr and
updated the copr. But I am not sure about the release numbering when doing
bazaar snapshots.

Also there was problem on Fedora 24 with missing cmath include (solved now)

I also updated the SPEC and SRPM files attached:

Spec URL: https://jjelen.fedorapeople.org/wallch.spec
SRPM URL: https://jjelen.fedorapeople.org/wallch-4.15.r213-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1293630] Review Request: wallch - A wallpaper changer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293630

philip.worr...@googlemail.com changed:

   What|Removed |Added

 CC||philip.worrall@googlemail.c
   ||om



--- Comment #2 from philip.worr...@googlemail.com ---
Hello Jakub,

I am NOT an official packager but i have tried to do an informal review.

The application installs but just running it for a few minutes I noticed a
couple of key bugs. For example the wallpaper of the day does not work because
some of the websites images are fetched from now use https. Furthermore, I
couldn't get wallpaper clocks to work either.

I think the upstream have stopped doing regular releases but you can find a
more recent (non-released) revision in launchpad where a couple of these issues
have been fixed. I started to modify the specfile (adding a generate-tarball
script to checkout the latest revision from launchpad) but it wont build until
your patches are rebased on the later revision i.e. the dependency on unity
needs removing. I started to have a look at this but its not trivial because a
lot of files have been moved around.

I have attached the script i wrote, id be happy to take another look if you
revised your patches against the newer revision of this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1293630] Review Request: wallch - A wallpaper changer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293630



--- Comment #1 from philip.worr...@googlemail.com ---
Created attachment 1158061
  --> https://bugzilla.redhat.com/attachment.cgi?id=1158061=edit
generate tarball from launchpad

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org