[Bug 1294216] Review Request: xcape - Use a modifier key as a different key when quickly pressed and released
https://bugzilla.redhat.com/show_bug.cgi?id=1294216 Filip Szymański changed: What|Removed |Added Status|NEW |CLOSED CC|fszymanski...@gmail.com | Resolution|--- |NOTABUG Last Closed||2018-01-07 05:25:08 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1294216] Review Request: xcape - Use a modifier key as a different key when quickly pressed and released
https://bugzilla.redhat.com/show_bug.cgi?id=1294216 Dhiru Kholia changed: What|Removed |Added CC||dkho...@redhat.com --- Comment #6 from Dhiru Kholia --- Hi Filip, Please go ahead. I am no longer using this package. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1294216] Review Request: xcape - Use a modifier key as a different key when quickly pressed and released
https://bugzilla.redhat.com/show_bug.cgi?id=1294216 Filip Szymański changed: What|Removed |Added CC||fszymanski...@gmail.com --- Comment #5 from Filip Szymański --- Hi, Dhiru are you still interested in submitting this package? If not, I will gladly do it. My spec: https://fszymanski.fedorapeople.org/xcape/xcape.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1294216] Review Request: xcape - Use a modifier key as a different key when quickly pressed and released
https://bugzilla.redhat.com/show_bug.cgi?id=1294216 Parag AN(पराग) changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|panem...@gmail.com |nob...@fedoraproject.org Flags|fedora-review? | --- Comment #4 from Parag AN(पराग) --- Sorry I am just clearing bug tracker to give preference to priority bugs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1294216] Review Request: xcape - Use a modifier key as a different key when quickly pressed and released
https://bugzilla.redhat.com/show_bug.cgi?id=1294216 Parag AN(पराग) changed: What|Removed |Added Flags|fedora-review+ |fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1294216] Review Request: xcape - Use a modifier key as a different key when quickly pressed and released
https://bugzilla.redhat.com/show_bug.cgi?id=1294216
Parag AN(पराग) changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|panem...@gmail.com
Flags||fedora-review+
--- Comment #3 from Parag AN(पराग) ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Suggestions:
1) rpmlint output showed
xcape.src: W: strange-permission xcape-1.1.tar.gz 640
==> use the source file permissions as 664
xcape-debuginfo.x86_64: E: debuginfo-without-sources
==> This will be fixed if compiler flags are used while compilation
2) License tag should be GPLv3+ as there is wording of "(or any later version)
3) BuildRequires: gcc should be added as its now recommended to add all the
BuildRequires: for a package to build.
4) Compiler flags while compilation are not followed. Just add this line at the
beginning to %build section
export CFLAGS="%{optflags}"
5) Latest upstream release is 1.2 version. Submit updated package.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v3 or later)", "Unknown or generated". 4 files have
unknown license. Detailed output of licensecheck in
/home/parag/1294216-xcape/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[!]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include l
[Bug 1294216] Review Request: xcape - Use a modifier key as a different key when quickly pressed and released
https://bugzilla.redhat.com/show_bug.cgi?id=1294216 Mario Blättermann changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #2 from Mario Blättermann --- According to the source file, the license is GPLv3+. Please add README.md to %doc and LICENSE to %license in %files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1294216] Review Request: xcape - Use a modifier key as a different key when quickly pressed and released
https://bugzilla.redhat.com/show_bug.cgi?id=1294216 Parag AN(पराग) changed: What|Removed |Added CC||panem...@gmail.com --- Comment #1 from Parag AN(पराग) --- Hi Dhiru, You should first post comment on previous review that if that submitter is still willing to continue to submit that package. If he is willing then maybe you can review it and have this package in Fedora. We have https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews#Submitter_not_responding policy. You need to check if submitter is not responding and then mark that FE-DEADREVIEW and close it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
